Add Japanese translation for kubectl #45562

girikuncoro · 2017-05-09T21:32:38Z

What this PR does / why we need it:
This PR provides first attempt to translate kubectl in Japanese (related to #40645 and #40591).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
No issues

Special notes for your reviewer:
Should be reviewed by member of Japanese k8s community (I stayed in Japan for 4 years, but my language is not as good as native Japanese)

k8s-ci-robot · 2017-05-09T21:32:41Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-reviewable · 2017-05-09T21:32:45Z

This change is

k8s-ci-robot · 2017-05-09T21:32:46Z

Hi @girikuncoro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

girikuncoro · 2017-05-09T21:42:51Z

I've just sign up the CLA

soltysh · 2017-05-09T21:59:26Z

@kubernetes/sig-cli-pr-reviews do we have someone who knows Japanese to verify this?

brendandburns · 2017-05-10T04:20:35Z

Calling @ianlewis who knows Japanese afaik...

brendandburns · 2017-05-10T04:24:02Z

@k8s-bot ok to test

brendandburns · 2017-05-10T04:26:29Z

@girikuncoro Thanks for the contribution!

Spot checks via Google Translate look ok. We'll wait a couple days to see if another Japanese speaker can do a check, then I'll LGTM.

vfreex · 2017-05-10T04:31:43Z

Shouldn't the language code of Japanese be ja_JP?

superbrothers · 2017-05-10T04:32:55Z

translations/kubectl/jp_JP/LC_MESSAGES/k8s.po

+msgstr "kubeconfigに単一値の設定を削除する"
+
+msgid "Update the annotations on a resource"
+msgstr "リソースでのあのテーショーンを更新する"


リソースのアノテーションを更新する

superbrothers · 2017-05-10T04:40:53Z

translations/kubectl/jp_JP/LC_MESSAGES/k8s.po

+"%d resources were found"
+msgstr[0] ""
+"watchは単一リソース及びリソースコレクションでのみサポートされている - "
+"リソース　%d　が見つかった"


%d個のリソースが見つかりました

superbrothers · 2017-05-10T04:41:16Z

translations/kubectl/jp_JP/LC_MESSAGES/k8s.po

+"リソース　%d　が見つかった"
+msgstr[1] ""
+"watchは単一リソース及びリソースコレクションでのみサポートされている - "
+"リソース　%d　が見つかった"


%d個のリソースが見つかりました

TakanariKo · 2017-05-10T04:43:02Z

pkg/util/i18n/i18n.go

 		"default",
 		"en_US",
 		"fr_FR",
+		"jp_JP",


superbrothers · 2017-05-10T04:43:31Z

translations/kubectl/jp_JP/LC_MESSAGES/k8s.po

+
+# https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/config/use_context.go#L48
+msgid "Sets the current-context in a kubeconfig file"
+msgstr "kubeconfigに現在のコンテキストを設定する"


kubeconfigにカレントコンテキストを設定する

vfreex · 2017-05-10T04:43:11Z

pkg/util/i18n/i18n.go

 		"default",
 		"en_US",
 		"fr_FR",
+		"jp_JP",


The ISO 639 language code of Japanese language is ja, so this should be changed to ja_JP.

k8s-ci-robot · 2017-06-01T05:40:46Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2017-06-01T05:43:06Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @brendandburns @girikuncoro

k8s-github-robot · 2017-06-01T05:43:07Z

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

warmchang · 2017-06-01T05:54:31Z

@girikuncoro , 2565 files changed, It look like better to rebase the PR.

This reverts commit 28f485a, reversing changes made to 125d1d4.

shiywang · 2017-06-01T06:08:45Z

seems you "rebased" too much

girikuncoro · 2017-06-01T06:25:55Z

@brendandburns sorry my bad, I messed up the PR. I've moved it to the new one at #46756. closing this for now

girikuncoro · 2017-06-01T06:26:45Z

@shiywang @warmchang my bad, accidentally pushed some mistake 😓 moved to #46756

k8s-ci-robot · 2017-06-01T08:07:40Z

@girikuncoro: The following test(s) failed:

Test name	Commit	Details	Rerun command
pull-kubernetes-cross	`923690b`	link	`@k8s-bot pull-kubernetes-cross test this`
pull-kubernetes-e2e-gce-etcd3	`923690b`	link	`@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669) Add Japanese translation for kubectl **What this PR does / why we need it**: I messed up the original PR(#45562) which was already been reviewed and approved. This PR provides first attempt to translate kubectl in Japanese (related to #40645 and #40591). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: Should be reviewed by member of Japanese k8s community (I stayed in Japan for 4 years, but my language is not as good as native Japanese)

Automatic merge from submit-queue Add Traditional Chinese translation for kubectl **What this PR does / why we need it**: This PR provides first attempt to translate kubectl in Traditional Chinese (related to #40645, #45573, #45562, #40591). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires Chinese people to assist in the review, especially Chinese speaking Taiwanese or Cantonese, thanks!

Automatic merge from submit-queue (batch tested with PRs 46986, 51214, 51169, 50155, 51261) Add Italian translation for kubectl **What this PR does / why we need it:** This PR provides first attempt to translate kubectl in Italian (related to #40645, #45573, #45562, #40591, #46559). **Which issue this PR fixes** _(`optional, in fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes # No issues **Special notes for your reviewer:** This PR requires Italian people to assist in the review. I'm native in Italian with BS in Computer Science. ```release-note Adding Italian translation for kubectl ```

Automatic merge from submit-queue Add German translation for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in German (related to #40645, #45573, #45562, #40591, #46559, #50155). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires German people to assist in the review. I'm native in German with BSc in Business Information Technology. **Release note**: ```release-note Adding German translation for kubectl ```

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adds initial Korean translations for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in Korean (related to kubernetes#51867, kubernetes#40645, kubernetes#45573, kubernetes#45562, kubernetes#40591, kubernetes#46559, kubernetes#50155). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: No issues **Special notes for your reviewer**: This PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ). **Release note**: ```release-note Adding initial Korean translation for kubectl ```

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 9, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2017

k8s-github-robot assigned smarterclayton and soltysh May 9, 2017

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels May 9, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 9, 2017

soltysh removed their assignment May 9, 2017

k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label May 9, 2017

brendandburns assigned brendandburns and unassigned smarterclayton May 10, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2017

brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 10, 2017

superbrothers reviewed May 10, 2017

View reviewed changes

TakanariKo reviewed May 10, 2017

View reviewed changes

pkg/util/i18n/i18n.go Outdated

"default",

"en_US",

"fr_FR",

"jp_JP",

Copy link

TakanariKo May 10, 2017 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja_JP

superbrothers reviewed May 10, 2017

View reviewed changes

vfreex suggested changes May 10, 2017

View reviewed changes

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 1, 2017

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 1, 2017

Revert "Rebase and resolve conflicts"

923690b

This reverts commit 28f485a, reversing changes made to 125d1d4.

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed kind/old-docs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 1, 2017

girikuncoro mentioned this pull request Jun 1, 2017

Add Japanese translation for kubectl #46756

Merged

girikuncoro closed this Jun 1, 2017

lucab85 mentioned this pull request Aug 5, 2017

Add Italian translation for kubectl #50155

Merged

Steffen911 mentioned this pull request Sep 3, 2017

Add German translation for kubectl #51867

Merged

cpanato mentioned this pull request Mar 23, 2018

add initial translation for pt_BR for kubectl #61595

Merged

ianychoi mentioned this pull request Apr 2, 2018

Adds initial Korean translations for kubectl #62040

Merged

Add Japanese translation for kubectl #45562

Add Japanese translation for kubectl #45562

Uh oh!

Conversation

girikuncoro commented May 9, 2017

Uh oh!

k8s-ci-robot commented May 9, 2017

Uh oh!

k8s-reviewable commented May 9, 2017

Uh oh!

k8s-ci-robot commented May 9, 2017

Uh oh!

girikuncoro commented May 9, 2017

Uh oh!

soltysh commented May 9, 2017

Uh oh!

brendandburns commented May 10, 2017

Uh oh!

brendandburns commented May 10, 2017

Uh oh!

brendandburns commented May 10, 2017

Uh oh!

vfreex commented May 10, 2017

Uh oh!

superbrothers May 10, 2017

Choose a reason for hiding this comment

Uh oh!

superbrothers May 10, 2017

Choose a reason for hiding this comment

Uh oh!

superbrothers May 10, 2017

Choose a reason for hiding this comment

Uh oh!

TakanariKo May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

superbrothers May 10, 2017

Choose a reason for hiding this comment

Uh oh!

vfreex May 10, 2017

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 1, 2017

Uh oh!

k8s-github-robot commented Jun 1, 2017

Uh oh!

k8s-github-robot commented Jun 1, 2017

Uh oh!

warmchang commented Jun 1, 2017

Uh oh!

shiywang commented Jun 1, 2017

Uh oh!

girikuncoro commented Jun 1, 2017

Uh oh!

girikuncoro commented Jun 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

TakanariKo May 10, 2017 •

edited

Loading

girikuncoro commented Jun 1, 2017 •

edited

Loading