Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese translation for kubectl #46756

Merged
merged 7 commits into from
Jun 7, 2017
Merged

Add Japanese translation for kubectl #46756

merged 7 commits into from
Jun 7, 2017
+229 −0

Conversation

girikuncoro
Copy link
Contributor

What this PR does / why we need it:
I messed up the original PR(#45562) which was already been reviewed and approved. This PR provides first attempt to translate kubectl in Japanese (related to #40645 and #40591).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
No issues

Special notes for your reviewer:
Should be reviewed by member of Japanese k8s community (I stayed in Japan for 4 years, but my language is not as good as native Japanese)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @girikuncoro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jun 1, 2017
@girikuncoro girikuncoro mentioned this pull request Jun 1, 2017
Closed
@girikuncoro
Copy link
Contributor Author

/assign @brendandburns

@dims
Copy link
Member

dims commented Jun 1, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2017
@brendandburns
Copy link
Contributor

Thanks @girikuncoro I think you need to re-run hack/generate-bindata.sh

@girikuncoro
Copy link
Contributor Author

girikuncoro commented Jun 2, 2017 •
edited
Loading

@brendandburns seems like I just passed the CI now after rebase and regenerate bindata, can you kindly approve?

edit: ah just realized there's a code freeze for release, probably wait for a while

@brendandburns
Copy link
Contributor

brendandburns commented Jun 3, 2017 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, girikuncoro

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 3, 2017
@girikuncoro
Copy link
Contributor Author

/release-note
This might use the title as the release note

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 3, 2017
@girikuncoro
Copy link
Contributor Author

@brendandburns can you remove the do-not-merge label also? thanks!

@brendandburns brendandburns added this to the v1.7 milestone Jun 7, 2017
@brendandburns brendandburns removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 7, 2017
@brendandburns
Copy link
Contributor

@girikuncoro done, sorry for the delay.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)

@k8s-github-robot k8s-github-robot merged commit 443ed35 into kubernetes:master Jun 7, 2017
@girikuncoro girikuncoro deleted the japanese-translate branch June 7, 2017 08:30
@warmchang warmchang mentioned this pull request Jun 7, 2017
Merged
@girikuncoro girikuncoro mentioned this pull request Nov 19, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@dshulyak dshulyak

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@girikuncoro @k8s-ci-robot @dims @brendandburns @k8s-github-robot @dshulyak