Polish pl_PL translation for kubectl #40591

zen · 2017-01-27T12:02:45Z

What this PR does / why we need it:
PR provides first pl_PL (Polish) translation for kubectl

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

No issues

Special notes for your reviewer:

No code changes. Should be reviewed by member of polish k8s community.

k8s-reviewable · 2017-01-27T12:03:51Z

This change is

zen · 2017-01-27T12:03:52Z

@jellonek @pigmej @nebril Please review from language perspective

k8s-github-robot · 2017-01-27T12:13:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

Needs approval from an approver in each of these OWNERS Files:

OWNERS

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

pigmej

I like it.

k8s-ci-robot · 2017-01-27T13:37:21Z

@nebril: you can't LGTM a PR unless you are an assignee.

Details

In response to this comment:

/lgtm

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nebril · 2017-01-27T13:37:43Z

lgtm

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

jellonek · 2017-01-29T10:48:26Z

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

translations/kubectl/pl_PL/LC_MESSAGES/pl_PL.po, line 37 at r1 (raw file):

"%d resources were found"
msgstr[0] ""
"czujka jest wspierana tylko dla pojedynczego zasobu lub kolekcji zasobów - "

Odradza się używać określenia "wspierać" w tego typu tłumaczeniach. Polskim odpowiednikiem w tym kontekście jest "obsługiwać", tak więc proponuję: czujka obsługuje jedynie pojedynczy zasób, lub kolekcję zasobów".

Comments from Reviewable

brendandburns · 2017-01-30T04:30:20Z

@zen
Awesome, thanks!

You need to add a reference to the language here:

https://github.com/kubernetes/kubernetes/blob/master/pkg/util/i18n/i18n.go#L36

Also, you need to run:

hack/generate-bindata.sh

To regenerate the bindata that is linked in.

Thanks again for all your help with this.

(also, there are a bunch of new strings if you want to translate them too...)

brendandburns · 2017-03-07T04:06:15Z

@zen where do we stand on this, do you want me to take it over?

0xmichalis · 2017-03-07T16:48:46Z

@soltysh

0xmichalis · 2017-03-07T16:50:48Z

@brendandburns is there a doc somewhere about adding translations to kubectl?

soltysh · 2017-03-08T13:42:38Z

translations/kubectl/pl_PL/LC_MESSAGES/pl_PL.po

@@ -0,0 +1,44 @@
+# Test translations for unit tests.
+# Copyright (C) 2016


soltysh · 2017-03-08T13:43:44Z

translations/kubectl/pl_PL/LC_MESSAGES/pl_PL.po

+# Test translations for unit tests.
+# Copyright (C) 2016
+# This file is distributed under the same license as the PACKAGE package.
+# FIRST AUTHOR [email protected], 2016.


@zen it should be you not Brendan, I'm guessing. And again 2017.

soltysh · 2017-03-08T13:48:14Z

translations/kubectl/pl_PL/LC_MESSAGES/pl_PL.po

+
+msgctxt "Update the annotations on a resource"
+msgid "Update the annotations on a resource"
+msgstr "Zaktualizuj adnotacje dla zasobu"


Suggestion:
Zaktualizuj adnotacje zasobu.
Seems more natural to me.

I would argue here, in polish annotation is "for" something. This is more general questions, whether we follow language rules or use casual language. Based on my previous experience, we should keep language clean.

Yeah, but here the annotation is on a resource, not for. For suggests being something separate, like normal annotation in a book, not on a object. I was also considering word "anotacja" instead of adnotacja to make the difference cleaner, but I'm not convinced :/

soltysh · 2017-03-08T13:52:14Z

translations/kubectl/pl_PL/LC_MESSAGES/pl_PL.po

+"watch is only supported on individual resources and resource collections - "
+"%d resources were found"
+msgstr[0] ""
+"czujka jest wspierana tylko dla pojedynczego zasobu lub kolekcji zasobów - "


I don't like czujka word, I'm worried that we'll end up with translations causing misunderstandings . Similarly how I read the gang of four book translation to polish and I kept scratching my head what 'zrąb' was, only to find out at the end in the translation section they've meant framework :/ Unfortunately I can't think of a better word, yet.

I don't like it either. There are other alternatives like "obserwator" or "straż" or even "sensor", but I don't like them neither.
We can go completely another path and just concentrate on the core meaning. Unfortunately, software translation is always hard ;)

That's why I always prefer to go with English ones ;) But seriously "obserwator" although lengthy seems the closest, kinda.

brendandburns · 2017-03-13T23:38:00Z

@Kargakis The doc is here:

https://github.com/kubernetes/kubernetes/blob/master/translations/README.md

brendandburns · 2017-05-03T03:31:18Z

@zen would you like me to carry this across the finish line? I'm happy to do so, let me know.

Thanks!
--brendan

brendandburns · 2017-05-28T04:48:22Z

@zen ping on this again, want me to finish it off?

zen · 2017-05-29T09:03:22Z

@brendandburns sorry for delay, it slept through the cracks. I'll take care of it ASAP

zen · 2017-05-29T09:28:23Z

@brendandburns Is translations/kubectl/template.pot up to date? It somehow does not contain the strings I translated anymore and also it is much smaller than translations/kubectl/en_US/LC_MESSAGES/k8s.po

brendandburns · 2017-06-01T16:51:24Z

@zen I'll check the history. It should, but it's always possible there are bugs in my script...

Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669) Add Japanese translation for kubectl **What this PR does / why we need it**: I messed up the original PR(#45562) which was already been reviewed and approved. This PR provides first attempt to translate kubectl in Japanese (related to #40645 and #40591). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: Should be reviewed by member of Japanese k8s community (I stayed in Japan for 4 years, but my language is not as good as native Japanese)

Automatic merge from submit-queue Add Traditional Chinese translation for kubectl **What this PR does / why we need it**: This PR provides first attempt to translate kubectl in Traditional Chinese (related to #40645, #45573, #45562, #40591). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires Chinese people to assist in the review, especially Chinese speaking Taiwanese or Cantonese, thanks!

Automatic merge from submit-queue (batch tested with PRs 46986, 51214, 51169, 50155, 51261) Add Italian translation for kubectl **What this PR does / why we need it:** This PR provides first attempt to translate kubectl in Italian (related to #40645, #45573, #45562, #40591, #46559). **Which issue this PR fixes** _(`optional, in fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes # No issues **Special notes for your reviewer:** This PR requires Italian people to assist in the review. I'm native in Italian with BS in Computer Science. ```release-note Adding Italian translation for kubectl ```

k8s-github-robot · 2017-08-30T21:45:11Z

Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

k8s-github-robot · 2017-08-30T21:45:11Z

This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @adohe @brendandburns @soltysh @zen

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

Automatic merge from submit-queue Add German translation for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in German (related to #40645, #45573, #45562, #40591, #46559, #50155). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires German people to assist in the review. I'm native in German with BSc in Business Information Technology. **Release note**: ```release-note Adding German translation for kubectl ```

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adds initial Korean translations for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in Korean (related to kubernetes#51867, kubernetes#40645, kubernetes#45573, kubernetes#45562, kubernetes#40591, kubernetes#46559, kubernetes#50155). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: No issues **Special notes for your reviewer**: This PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ). **Release note**: ```release-note Adding initial Korean translation for kubectl ```

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2017

k8s-github-robot assigned brendandburns Jan 27, 2017

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jan 27, 2017

zen force-pushed the kubectl_pl_translation branch from b2517cc to 86fa1c3 Compare January 27, 2017 12:55

Polish pl_PL translation for kubectl

f5af0d5

zen force-pushed the kubectl_pl_translation branch from 86fa1c3 to f5af0d5 Compare January 27, 2017 12:58

pigmej approved these changes Jan 27, 2017

View reviewed changes

k8s-github-robot assigned adohe-zz and unassigned brendandburns Jan 30, 2017

apelisse assigned brendandburns Jan 31, 2017

k8s-github-robot assigned smarterclayton Jan 31, 2017

0xmichalis assigned soltysh and unassigned smarterclayton Mar 7, 2017

soltysh reviewed Mar 8, 2017

View reviewed changes

girikuncoro mentioned this pull request May 9, 2017

Add Japanese translation for kubectl #45562

Closed

warmchang mentioned this pull request May 27, 2017

Add Traditional Chinese translation for kubectl #46559

Merged

girikuncoro mentioned this pull request Jun 1, 2017

Add Japanese translation for kubectl #46756

Merged

lucab85 mentioned this pull request Aug 5, 2017

Add Italian translation for kubectl #50155

Merged

k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 30, 2017

k8s-github-robot closed this Aug 30, 2017

Steffen911 mentioned this pull request Sep 3, 2017

Add German translation for kubectl #51867

Merged

cpanato mentioned this pull request Mar 23, 2018

add initial translation for pt_BR for kubectl #61595

Merged

ianychoi mentioned this pull request Apr 2, 2018

Adds initial Korean translations for kubectl #62040

Merged

		@@ -0,0 +1,44 @@
		# Test translations for unit tests.
		# Copyright (C) 2016

Polish pl_PL translation for kubectl #40591

Polish pl_PL translation for kubectl #40591

Uh oh!

Conversation

zen commented Jan 27, 2017 • edited by k8s-github-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-reviewable commented Jan 27, 2017

Uh oh!

zen commented Jan 27, 2017

Uh oh!

k8s-github-robot commented Jan 27, 2017

Uh oh!

pigmej left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 27, 2017

Uh oh!

nebril commented Jan 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jellonek commented Jan 29, 2017

Uh oh!

brendandburns commented Jan 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendandburns commented Mar 7, 2017

Uh oh!

0xmichalis commented Mar 7, 2017

Uh oh!

0xmichalis commented Mar 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Mar 13, 2017

Uh oh!

brendandburns commented May 3, 2017

Uh oh!

brendandburns commented May 28, 2017

Uh oh!

zen commented May 29, 2017

Uh oh!

zen commented May 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendandburns commented Jun 1, 2017

Uh oh!

k8s-github-robot commented Aug 30, 2017

Uh oh!

k8s-github-robot commented Aug 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

zen commented Jan 27, 2017 •

edited by k8s-github-robot

Loading

nebril commented Jan 27, 2017 •

edited

Loading

brendandburns commented Jan 30, 2017 •

edited

Loading

zen commented May 29, 2017 •

edited

Loading