Add Traditional Chinese translation for kubectl #46559

warmchang · 2017-05-27T03:38:38Z

What this PR does / why we need it:
This PR provides first attempt to translate kubectl in Traditional Chinese (related to #40645, #45573,
#45562, #40591).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
No issues

Special notes for your reviewer:
This PR requires Chinese people to assist in the review, especially Chinese speaking Taiwanese or Cantonese, thanks!

k8s-ci-robot · 2017-05-27T03:38:45Z

Hi @warmchang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2017-05-27T06:38:24Z

@zhangxiaoyu-zidif: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zhangxiaoyu-zidif · 2017-05-27T06:40:36Z

/assign @janetkuo
You may have a good knowledge of Traditional Chinese.

shiywang · 2017-05-27T11:33:40Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/delete_cluster.go:39
+msgid "Delete the specified cluster from the kubeconfig"
+msgstr "刪除 kubeconfig 檔中指定的集群"


文檔？文件 ?

Well, I can adjust the "檔" to "文檔" or "檔案", any other suggestions?

warmchang · 2017-05-31T03:30:07Z

@shiywang , I've changed all "檔" to "文檔", rebuild the "bindata.go" & "k8s.mo".
Pls check it and review again.

janetkuo · 2017-05-31T23:43:35Z

@k8s-bot ok to test

janetkuo · 2017-05-31T23:44:46Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/delete_cluster.go:39
+msgid "Delete the specified cluster from the kubeconfig"
+msgstr "刪除 kubeconfig 文檔中指定的集群"


change all 文檔 to 檔案

集群 --> 叢集, or 叢集(cluster)

ok, I will change them.

janetkuo · 2017-05-31T23:48:21Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/delete_context.go:39
+msgid "Delete the specified context from the kubeconfig"
+msgstr "刪除 kubeconfig 文檔中指定的上下文"


I'd suggest not translating context, since it's a specific term used in kubeconfig

Also, context is more like 環境, not 上下文. You'd probably need to update the zh_CN one too.

You can also do 環境(context)

@shiywang , you may consider this suggestion about the zh_CN translation of context.
I'll keep context not translating in zh_TW.

janetkuo · 2017-05-31T23:50:13Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/set.go:60
+msgid "Sets an individual value in a kubeconfig file"
+msgstr "設置 kubeconfig 文檔中的一個單個值"


一個單個值 --> 一個值 or 某個值

janetkuo · 2017-05-31T23:51:19Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/annotate.go:116
+msgid "Update the annotations on a resource"
+msgstr "更新一個資源的注解"


注解(annotation), since it's a special term in K8s

you mean keep annotation not translating, just like the context?

janetkuo · 2017-05-31T23:52:55Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+msgid_plural ""
+"watch is only supported on individual resources and resource collections - "
+"%d resources were found"
+msgstr[0] "watch 僅支援單獨的資源或者資源集合 - 找到了 %d 個資源"


Edit: watch 僅支援單獨的資源或者資源集合 --> 一次只能 watch 一個資源或資料集合

I'll change it, thanks!

warmchang · 2017-06-01T03:01:10Z

@janetkuo , I've changed the translation, rebased the master branch and committed.
Please check it, thank you.

janetkuo · 2017-06-01T18:13:47Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/current_context.go:49
+msgid "Displays the current-context"
+msgstr "顯示當前的context"


當前 --> 目前

janetkuo

Some final comments, LGTM otherwise

janetkuo · 2017-06-01T18:14:10Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/use_context.go:49
+msgid "Sets the current-context in a kubeconfig file"
+msgstr "設置 kubeconfig 檔案中的當前context"


當前 --> 目前

janetkuo · 2017-06-01T18:14:51Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/annotate.go:116
+msgid "Update the annotations on a resource"
+msgstr "更新一個資源的annotations"


This can be 注解(annotations) or just annotations, it's up to you

janetkuo · 2017-06-01T18:16:53Z

translations/kubectl/zh_TW/LC_MESSAGES/k8s.po

+
+#: pkg/kubectl/cmd/config/delete_context.go:39
+msgid "Delete the specified context from the kubeconfig"
+msgstr "刪除 kubeconfig 檔案中指定的context"


Optional: Add a space between Chinese & English character so that it looks consistent

warmchang · 2017-06-02T01:21:47Z

@janetkuo , Based on your kind comments, I changed and committed it again. 😄

shashidharatd · 2017-06-02T05:32:15Z

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref: #46827

janetkuo · 2017-06-02T17:43:28Z

/release-note-none
/lgtm
/approve

warmchang · 2017-06-03T02:46:41Z

/assign @brendandburns
This PR has been approved by @janetkuo , Pls check it and make the additional decisions, thx.

brendandburns · 2017-06-07T04:49:06Z

@k8s-bot pull-kubernetes-federation-e2e-gce test this

warmchang · 2017-06-07T13:29:58Z

Resolve conflicts after #46756.

warmchang · 2017-06-08T01:42:32Z

@janetkuo @shashidharatd @brendandburns , all the test result are ok, please recheck this, and approve to merge, thx!

janetkuo · 2017-06-08T06:47:34Z

@warmchang would you squash the commits into one?

warmchang · 2017-06-08T07:31:35Z

@janetkuo , thank you for your advice. I've done, and waiting for the end of the pull-kubernetes-xxx test.

k8s-ci-robot · 2017-06-08T08:31:12Z

@warmchang: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-federation-e2e-gce	dd2b7434f282208c260f4cd30ed621ee566cf4b5	link	`@k8s-bot pull-kubernetes-federation-e2e-gce test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

warmchang · 2017-06-08T11:39:06Z

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

brendandburns · 2017-06-08T16:25:57Z

/lgtm
/approve

brendandburns · 2017-06-08T16:30:31Z

/approve no-issue

Pre-code freeze LGTM, plus very low risk == approve.

k8s-github-robot · 2017-06-08T16:30:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, janetkuo, warmchang

Associated issue requirement bypassed by: brendandburns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/OWNERS~~ [brendandburns]
~~translations/kubectl/OWNERS~~ [brendandburns,janetkuo]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-06-08T18:11:04Z

Automatic merge from submit-queue

Automatic merge from submit-queue (batch tested with PRs 46986, 51214, 51169, 50155, 51261) Add Italian translation for kubectl **What this PR does / why we need it:** This PR provides first attempt to translate kubectl in Italian (related to #40645, #45573, #45562, #40591, #46559). **Which issue this PR fixes** _(`optional, in fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes # No issues **Special notes for your reviewer:** This PR requires Italian people to assist in the review. I'm native in Italian with BS in Computer Science. ```release-note Adding Italian translation for kubectl ```

Automatic merge from submit-queue Add German translation for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in German (related to #40645, #45573, #45562, #40591, #46559, #50155). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires German people to assist in the review. I'm native in German with BSc in Business Information Technology. **Release note**: ```release-note Adding German translation for kubectl ```

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adds initial Korean translations for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in Korean (related to kubernetes#51867, kubernetes#40645, kubernetes#45573, kubernetes#45562, kubernetes#40591, kubernetes#46559, kubernetes#50155). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: No issues **Special notes for your reviewer**: This PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ). **Release note**: ```release-note Adding initial Korean translation for kubectl ```

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2017

k8s-github-robot assigned ericchiang and deads2k May 27, 2017

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 27, 2017

k8s-ci-robot assigned janetkuo May 27, 2017

shiywang reviewed May 27, 2017

View reviewed changes

deads2k removed their assignment May 30, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2017

janetkuo reviewed May 31, 2017

View reviewed changes

janetkuo reviewed Jun 1, 2017

View reviewed changes

janetkuo approved these changes Jun 2, 2017

View reviewed changes

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 2, 2017

k8s-ci-robot assigned brendandburns Jun 3, 2017

brendandburns added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 7, 2017

brendandburns removed the release-note-none Denotes a PR that doesn't merit a release note. label Jun 7, 2017

brendandburns added this to the v1.7 milestone Jun 7, 2017

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2017

Add Traditional Chinese translation for kubectl

9ac9601

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2017

marun added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jun 8, 2017

k8s-github-robot merged commit 165a17b into kubernetes:master Jun 8, 2017

shiywang mentioned this pull request Jul 26, 2017

Add shiywang to sig-cli help out review code #47587

Merged

lucab85 mentioned this pull request Aug 5, 2017

Add Italian translation for kubectl #50155

Merged

Steffen911 mentioned this pull request Sep 3, 2017

Add German translation for kubectl #51867

Merged

cpanato mentioned this pull request Mar 23, 2018

add initial translation for pt_BR for kubectl #61595

Merged

ianychoi mentioned this pull request Apr 2, 2018

Adds initial Korean translations for kubectl #62040

Merged

warmchang deleted the zh_TW branch September 12, 2019 07:53

Add Traditional Chinese translation for kubectl #46559

Add Traditional Chinese translation for kubectl #46559

Conversation

warmchang commented May 27, 2017

k8s-ci-robot commented May 27, 2017

k8s-ci-robot commented May 27, 2017

zhangxiaoyu-zidif commented May 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

warmchang commented May 31, 2017

janetkuo commented May 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janetkuo May 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janetkuo May 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

warmchang commented Jun 1, 2017

janetkuo Jun 1, 2017 • edited Loading

Choose a reason for hiding this comment

janetkuo left a comment

Choose a reason for hiding this comment

janetkuo Jun 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

warmchang commented Jun 2, 2017

shashidharatd commented Jun 2, 2017

janetkuo commented Jun 2, 2017

warmchang commented Jun 3, 2017

brendandburns commented Jun 7, 2017

warmchang commented Jun 7, 2017

warmchang commented Jun 8, 2017

janetkuo commented Jun 8, 2017

warmchang commented Jun 8, 2017

k8s-ci-robot commented Jun 8, 2017 • edited Loading

warmchang commented Jun 8, 2017 • edited Loading

brendandburns commented Jun 8, 2017

brendandburns commented Jun 8, 2017

k8s-github-robot commented Jun 8, 2017

k8s-github-robot commented Jun 8, 2017

janetkuo May 31, 2017 •

edited

Loading

janetkuo May 31, 2017 •

edited

Loading

janetkuo Jun 1, 2017 •

edited

Loading

janetkuo Jun 1, 2017 •

edited

Loading

k8s-ci-robot commented Jun 8, 2017 •

edited

Loading

warmchang commented Jun 8, 2017 •

edited

Loading