Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simplified Chinese translation for kubectl #45573

Merged
merged 1 commit into from
May 25, 2017

Conversation

shiywang
Copy link
Contributor

@shiywang shiywang commented May 10, 2017

What this PR does / why we need it:
This PR provides first attempt to translate kubectl in Simplified Chinese.

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
No issues

Special notes for your reviewer:
Although I'm a native speaker for Mandarin Chinese, but I think translation is a whole different knowledge which I'm not good at it, so this pr absolutely need to be polished.
@adohe @mengqiy @resouer @k82cn @caesarxuchao @wanghaoran1988 sorry I think there are so many folks who are good at Chinese I haven't mention, feel free to leave a comment on it : )
also cc @brendandburns

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 10, 2017
@shiywang shiywang force-pushed the zh branch 2 times, most recently from d137e62 to dc42fa3 Compare May 10, 2017 06:39

# https://github.com/kubernetes/kubernetes/blob/masterpkg/kubectl/cmd/apply.go#L98
msgid "Apply a configuration to a resource by filename or stdin"
msgstr "通过文件或者标准输入的读取方式apply一个资源"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通过文件名或标准输入流(stdin)对资源进行配置。


# https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/config/delete_cluster.go#L38
msgid "Delete the specified cluster from the kubeconfig"
msgstr "从kubeconfig文件中删除指定的集群"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“删除 kubeconfig 文件中指定的集群”
中英文混排时用空格隔开。


# https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/config/get_contexts.go#L62
msgid "Describe one or many contexts"
msgstr "描述一个或更多上下文"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更多->多个


# https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/config/get_clusters.go#L40
msgid "Display clusters defined in the kubeconfig"
msgstr "从kubeconfig配置文件中显示指定的集群"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

显示 kubeconfig 文件中指定的集群

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

显示kubeconfig配置文件中定义的集群

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specified cluster -> 指定的集群
clusters defined -> 定义的集群 ?

msgid_plural ""
"watch is only supported on individual resources and resource collections - "
"%d resources were found"
msgstr[0] "watch 仅在单独的一个资源或者一个资源集合上被支持 -资源 %d 被发现"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议改为主动语态,如
watch 仅支持单独的资源或者资源集合 - 找到了 %d 个资源

@shiywang shiywang changed the title [WIP] Add Simplified Chinese translation for kubectl Add Simplified Chinese translation for kubectl May 10, 2017

# https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/config/view.go#L64
msgid "Display merged kubeconfig settings or a specified kubeconfig file"
msgstr "显示合并的集群或者指定的kubeconfig配置文件"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合并的kubeconfig配置?

@shiywang shiywang force-pushed the zh branch 2 times, most recently from 35c3594 to 57b02e9 Compare May 10, 2017 07:59

# https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/config/unset.go#L47
msgid "Unsets an individual value in a kubeconfig file"
msgstr "取消设置 kubeconfig 文件中的一个单独值"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单独值 sounds odd, anything better?

Copy link
Contributor Author

@shiywang shiywang May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 单个值 , how about now ?

@pwittrock
Copy link
Member

I was actually joking when I said I could review this :P

Looks like this doesn't impact non-chinese aspects of kubectl, so I can approve once @rootfs lgtm's

@pwittrock pwittrock assigned mengqiy and unassigned pwittrock May 10, 2017
"Plural-Forms: nplurals=2; plural=(n > 1);\n"
"Language: zh\n"

# https://github.com/kubernetes/kubernetes/blob/masterpkg/kubectl/cmd/apply.go#L98
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the url is pointing to the wrong line.
Not sure if it matters.
Same issue for the urls below.

Should be master/pkg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@mengqiy
Copy link
Member

mengqiy commented May 23, 2017

LGTM
@rootfs Any more comments?

@rootfs
Copy link
Contributor

rootfs commented May 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 23, 2017
@rootfs
Copy link
Contributor

rootfs commented May 23, 2017

great work @shiywang @mengqiy

@rootfs
Copy link
Contributor

rootfs commented May 23, 2017

/release-note-action-required
Add Simplified Chinese translation for kubectl

@mengqiy
Copy link
Member

mengqiy commented May 23, 2017

/release-note
I think this will use the title as the release note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 23, 2017
@mengqiy
Copy link
Member

mengqiy commented May 23, 2017

@pwittrock ping for approval

@brendandburns brendandburns self-assigned this May 24, 2017
@brendandburns
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, rootfs, shiywang

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2017
@brendandburns
Copy link
Contributor

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@brendandburns brendandburns removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 25, 2017
@shiywang
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@shiywang
Copy link
Contributor Author

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 25, 2017

@shiywang: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-unit 95fb791 link @k8s-bot pull-kubernetes-unit test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45573, 46354, 46376, 46162, 46366)

@k8s-github-robot k8s-github-robot merged commit 4234d79 into kubernetes:master May 25, 2017
@shiywang shiywang deleted the zh branch May 25, 2017 13:54
@CaoShuFeng
Copy link
Contributor

I would like invate you to review this change:
#46487

k8s-github-robot pushed a commit that referenced this pull request Jun 8, 2017
Automatic merge from submit-queue

Add Traditional Chinese translation for kubectl

**What this PR does / why we need it**:
This PR provides first attempt to translate kubectl in Traditional Chinese (related to #40645, #45573, 
#45562, #40591).

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
No issues

**Special notes for your reviewer**:
This PR requires Chinese people to assist in the review, especially Chinese speaking Taiwanese or Cantonese, thanks!
k8s-github-robot pushed a commit that referenced this pull request Aug 25, 2017
Automatic merge from submit-queue (batch tested with PRs 46986, 51214, 51169, 50155, 51261)

Add Italian translation for kubectl

**What this PR does / why we need it:**
This PR provides first attempt to translate kubectl in Italian (related to #40645, #45573,
#45562, #40591, #46559).

**Which issue this PR fixes** _(`optional, in fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes #
No issues

**Special notes for your reviewer:**
This PR requires Italian people to assist in the review. I'm native in Italian with BS in Computer Science.

```release-note
Adding Italian translation for kubectl
```
k8s-github-robot pushed a commit that referenced this pull request Sep 8, 2017
Automatic merge from submit-queue

Add German translation for kubectl

**What this PR does / why we need it**:
This PR provides a first attempt to translate kubectl in German (related to #40645, #45573, #45562, #40591, #46559, #50155).

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
No issues

**Special notes for your reviewer**:
This PR requires German people to assist in the review. I'm native in German with BSc in Business Information Technology.

**Release note**:
```release-note
Adding German translation for kubectl
```
feiskyer pushed a commit to feiskyer/kubernetes that referenced this pull request May 14, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Adds initial Korean translations for kubectl

**What this PR does / why we need it**:
This PR provides a first attempt to translate kubectl in Korean (related to kubernetes#51867, kubernetes#40645, kubernetes#45573, kubernetes#45562, kubernetes#40591, kubernetes#46559, kubernetes#50155).

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
No issues

**Special notes for your reviewer**:
This PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ).

**Release note**:
```release-note
Adding initial Korean translation for kubectl
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.