Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test coverage in Kubelet is lousy. (~30%) #1

Closed
jbeda opened this issue Jun 6, 2014 · 3 comments
Closed

Unit test coverage in Kubelet is lousy. (~30%) #1

jbeda opened this issue Jun 6, 2014 · 3 comments
Labels
area/test

Comments

@jbeda
Copy link
Contributor

jbeda commented Jun 6, 2014

No description provided.

@jbeda
Copy link
Contributor Author

jbeda commented Jun 6, 2014

@brendandburns originally filed.

brendandburns referenced this issue in brendandburns/kubernetes Jun 19, 2014
@brendandburns
Part #1 of synchronous requests: Add channels and a mechanism for wai…
2640de5 
…ting on them
lavalamp added a commit that referenced this issue Jun 19, 2014
@lavalamp
Merge pull request #166 from brendandburns/sync
466be48 
Part #1 of synchronous requests: Add channels and a mechanism for waiting
@brendandburns
Copy link
Contributor

We're now at 58%, still not great, but I think we can close this issue, and track improving coverage as a general project goal.

@brendandburns brendandburns mentioned this issue Jul 14, 2014
Closed
rafael pushed a commit to rafael/kubernetes that referenced this issue Jul 24, 2014
@derekwaynecarr
Merge pull request kubernetes#1 from csrwng/env_num_minions
f42091f 
Fix issue when specifiying number of minions as env var
jhadvig referenced this issue in jhadvig/kubernetes Aug 26, 2014
@csrwng
Merge pull request #1 from jhadvig/salt_update
3c33b42 
Update salt script for build-controller
brendandburns added a commit that referenced this issue Sep 2, 2014
@brendandburns
Step #1 in migrating the service controller away from the apiserver.
fee2b90 
Start using the API server for listing services.
lavalamp added a commit that referenced this issue Sep 2, 2014
@lavalamp
Merge pull request #1077 from brendandburns/service
d202643 
Step #1 in migrating the service controller away from the apiserver.
@thockin thockin mentioned this issue Sep 6, 2014
Closed
@bgrant0607 bgrant0607 mentioned this issue Sep 8, 2014
Merged
proppy added a commit that referenced this issue Sep 26, 2014
@proppy
Merge pull request #1 from Gurpartap/patch-1
f6e688f 
Remove DOCKER_BIN and boot2docker instructions from README.md
@satnam6502 satnam6502 mentioned this issue Oct 3, 2014
Merged
@lavalamp lavalamp mentioned this issue Oct 14, 2014
Closed
This was referenced Nov 3, 2014
Closed
Merged
vmarmol referenced this issue in vmarmol/kubernetes Nov 15, 2014
@rjnagal
Merge pull request #1 from rjnagal/scaler0
2448836 
Introducing auto scaler for kubernetes.
@arthurala arthurala mentioned this issue Aug 11, 2023
Closed
@ganeshgunasekaran ganeshgunasekaran mentioned this issue Aug 21, 2023
Closed
@nagygergo nagygergo mentioned this issue Aug 24, 2023
Closed
@aroshan aroshan mentioned this issue Sep 18, 2023
Closed
@andre161292 andre161292 mentioned this issue Sep 27, 2023
Closed
@alexzielenski alexzielenski mentioned this issue Oct 12, 2023
Merged
k8s-ci-robot pushed a commit that referenced this issue Oct 16, 2023
@pohly
fix invalid log calls
957adfa 
These were found with a modified klog that enables "go vet" to check klog call
parameters:

    cmd/kubeadm/app/features/features.go:149:4: printf: k8s.io/klog/v2.Warningf format %t has arg v of wrong type string (govet)
    			klog.Warningf("Setting deprecated feature gate %s=%t. It will be removed in a future release.", k, v)
    test/images/sample-device-plugin/sampledeviceplugin.go:147:5: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
    				klog.Errorf("error: %w", err)
    test/images/sample-device-plugin/sampledeviceplugin.go:155:3: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
    		klog.Errorf("Failed to add watch to %q: %w", triggerPath, err)
    staging/src/k8s.io/code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go:207:5: printf: k8s.io/klog/v2.Fatalf does not support error-wrapping directive %w (govet)
    				klog.Fatalf("Package %v: unsupported %s value: %q :%w", i, tagEnabledName, ptag.value, err)
    staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:286:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet)
    		klog.V(4).Infof("Node %s missing in vSphere cloud provider cache, trying node informer")
    staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:302:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet)
    		klog.V(4).Infof("Node %s missing in vSphere cloud provider caches, trying the API server")
Sharpz7 pushed a commit to Sharpz7/kubernetes that referenced this issue Oct 27, 2023
@pohly @Sharpz7
fix invalid log calls
62d6d4f 
These were found with a modified klog that enables "go vet" to check klog call
parameters:

    cmd/kubeadm/app/features/features.go:149:4: printf: k8s.io/klog/v2.Warningf format %t has arg v of wrong type string (govet)
    			klog.Warningf("Setting deprecated feature gate %s=%t. It will be removed in a future release.", k, v)
    test/images/sample-device-plugin/sampledeviceplugin.go:147:5: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
    				klog.Errorf("error: %w", err)
    test/images/sample-device-plugin/sampledeviceplugin.go:155:3: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
    		klog.Errorf("Failed to add watch to %q: %w", triggerPath, err)
    staging/src/k8s.io/code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go:207:5: printf: k8s.io/klog/v2.Fatalf does not support error-wrapping directive %w (govet)
    				klog.Fatalf("Package %v: unsupported %s value: %q :%w", i, tagEnabledName, ptag.value, err)
    staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:286:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg kubernetes#1, but call has 0 args (govet)
    		klog.V(4).Infof("Node %s missing in vSphere cloud provider cache, trying node informer")
    staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:302:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg kubernetes#1, but call has 0 args (govet)
    		klog.V(4).Infof("Node %s missing in vSphere cloud provider caches, trying the API server")
@chaseSpace chaseSpace mentioned this issue Nov 20, 2023
Closed
@eroji eroji mentioned this issue Nov 25, 2023
Closed
@kishoremakkena kishoremakkena mentioned this issue Nov 26, 2023
Closed
@aojea aojea mentioned this issue Nov 30, 2023
Closed
@shaoqin2 shaoqin2 mentioned this issue Nov 30, 2023
Open
wm775825 pushed a commit to wm775825/kubernetes that referenced this issue Dec 2, 2023
@XiShanYongYe-Chang
Merge pull request kubernetes#1 from wm775825/release-1.28
e6e42e1 
[FleetAPIServer] support --loopback-config-file && fleet clientset && GET method
@kernelpod kernelpod mentioned this issue Dec 2, 2023
Closed
wm775825 pushed a commit to wm775825/kubernetes that referenced this issue Dec 10, 2023
@karmada-bot
Merge pull request kubernetes#1 from XiShanYongYe-Chang/dev-cz
ecba69a 
Add resource routing logic to fleet-apiserver
@echibas echibas mentioned this issue Dec 11, 2023
Closed
@Reyadeyat Reyadeyat mentioned this issue Jan 4, 2024
Closed
richabanker referenced this issue in richabanker/kubernetes Jan 9, 2024
@pohly @richabanker
fix invalid log calls
c898cd0 
These were found with a modified klog that enables "go vet" to check klog call
parameters:

    cmd/kubeadm/app/features/features.go:149:4: printf: k8s.io/klog/v2.Warningf format %t has arg v of wrong type string (govet)
    			klog.Warningf("Setting deprecated feature gate %s=%t. It will be removed in a future release.", k, v)
    test/images/sample-device-plugin/sampledeviceplugin.go:147:5: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
    				klog.Errorf("error: %w", err)
    test/images/sample-device-plugin/sampledeviceplugin.go:155:3: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
    		klog.Errorf("Failed to add watch to %q: %w", triggerPath, err)
    staging/src/k8s.io/code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go:207:5: printf: k8s.io/klog/v2.Fatalf does not support error-wrapping directive %w (govet)
    				klog.Fatalf("Package %v: unsupported %s value: %q :%w", i, tagEnabledName, ptag.value, err)
    staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:286:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet)
    		klog.V(4).Infof("Node %s missing in vSphere cloud provider cache, trying node informer")
    staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:302:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet)
    		klog.V(4).Infof("Node %s missing in vSphere cloud provider caches, trying the API server")
linxiulei pushed a commit to linxiulei/kubernetes that referenced this issue Jan 18, 2024
@dchen1107
Merge pull request kubernetes#1 from Random-Liu/add-node-problem-dete…
32d7acc 
…ctor

Add initial version of node problem detector
linxiulei pushed a commit to linxiulei/kubernetes that referenced this issue Jan 18, 2024
@ForestCold
Merge pull request kubernetes#1 from ForestCold/Update-supported-prob…
041b77b 
…lem-deamon-list

Update supported problem deamon list
@richabanker richabanker mentioned this issue Mar 7, 2024
Closed
@tutorguai tutorguai mentioned this issue Apr 5, 2024
Closed
@yxz11 yxz11 mentioned this issue Jun 22, 2024
Closed
@ahus1 ahus1 mentioned this issue Jul 3, 2024
Closed
@teja-rafay teja-rafay mentioned this issue Jul 6, 2024
Closed
No5stranger pushed a commit to No5stranger/kubernetes that referenced this issue Aug 27, 2024
source code read note, kubernetes#120240827
7682167
@gecube gecube mentioned this issue Oct 7, 2024
Open
@hakuna-matatah hakuna-matatah mentioned this issue Oct 8, 2024
Open
@thockin thockin mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbeda @brendandburns @enisoc