Add initial support for StorageVersion API for CRDs #120582

richabanker · 2023-09-11T23:03:46Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is based off of #113498, but rebased off of master. This is an attempt to drive the StorageVersion API graduation toward beta by addressing requirements/concerns for the same.

Which issue(s) this PR fixes:

Fixes kubernetes/enhancements#2339

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2339-storageversion-api-for-ha-api-servers

k8s-ci-robot · 2023-09-11T23:03:48Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexzielenski · 2023-09-12T20:19:42Z

/assign @andrewsykim
/triage accepted

roycaihw · 2024-02-08T20:24:28Z

staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go

+	// StorageVersionAPI feature gate is disabled
+	if !utilfeature.DefaultFeatureGate.Enabled(features.StorageVersionAPI) ||
+		!utilfeature.DefaultFeatureGate.Enabled(features.APIServerIdentity) {
+		klog.V(2).Infof("Skipped waiting for storage version to finish updating since StorageVersionAPI and/or APIServerIdentity feature are disabled.")


IIUC this line will be logged at V2 for every CR write requests when the feature is disabled. That seems to be a lot of clusters and a lot of logs.

roycaihw · 2024-02-20T18:30:07Z

staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go

+			return nil
+		}
+		// Get the latest CRD to make sure it's not terminating or deleted
+		crd, err := r.crdLister.Get(crdName)


I don't recall why I added this. It doesn't feel StorageVersion specific. We can exclude this from the PR

roycaihw · 2024-02-20T18:32:50Z

staging/src/k8s.io/apiextensions-apiserver/pkg/storageversion/manager.go

+// Manager provides methods for updating StorageVersion for CRDs. It does
+// goroutine management to allow CRD storage version updates running in the
+// background and not blocking the caller.
+type Manager interface {


IIRC the main purpose of having the manager is to implement the queueing logic, which is unique to CRD

Signed-off-by: Andrew Sy Kim <[email protected]> Co-authored-by: Haowei Cai (Roy) <[email protected]>

k8s-ci-robot · 2024-03-11T02:56:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: richabanker
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-03-11T03:28:01Z

@richabanker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

richabanker · 2024-03-19T20:29:47Z

Created a new PR which uses a workqueue to perform async SV udpates here #123999

k8s-triage-robot · 2024-06-17T21:20:47Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-07-17T22:01:39Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-08-16T22:16:17Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-08-16T22:16:22Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot requested a review from jpbetz September 11, 2023 23:04

k8s-ci-robot added the area/apiserver label Sep 11, 2023

k8s-ci-robot requested a review from smarterclayton September 11, 2023 23:04

k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2023

richabanker force-pushed the storage-version-api-beta branch from b447044 to 62a4a3e Compare September 11, 2023 23:06

richabanker changed the title ~~add initial support for StorageVersion API for CRDs~~ Add initial support for StorageVersion API for CRDs Sep 11, 2023

k8s-ci-robot assigned andrewsykim Sep 12, 2023

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 12, 2023

richabanker force-pushed the storage-version-api-beta branch 2 times, most recently from 8b18ac9 to bde2f04 Compare September 15, 2023 23:32

k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Sep 15, 2023

richabanker force-pushed the storage-version-api-beta branch 4 times, most recently from 2b73cb9 to 1d21b54 Compare September 16, 2023 00:46

roycaihw reviewed Feb 20, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024

richabanker and others added 9 commits March 10, 2024 19:25

Promote test for kubelet resource metric to conformance test

081659f

UVIP: fix incorrect handling of a routable request

aef1c8b

add initial support for StorageVersion API for CRDs

5327227

Signed-off-by: Andrew Sy Kim <[email protected]> Co-authored-by: Haowei Cai (Roy) <[email protected]>

Address comments

c9806b0

Fix bad rebase

93046d2

Address comments

c940968

Fix broken tests

013eb83

Add new integration test

54064ca

Address comments

550fd56

richabanker force-pushed the storage-version-api-beta branch from 72b0ab8 to 588ae6a Compare March 11, 2024 02:27

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024

richabanker force-pushed the storage-version-api-beta branch from 588ae6a to b4a3ed5 Compare March 11, 2024 02:53

Address comments

d76c0f4

richabanker force-pushed the storage-version-api-beta branch from b4a3ed5 to d76c0f4 Compare March 11, 2024 02:55

This was referenced Mar 19, 2024

Storageversion API for CRDs #123998

Closed

Storageversion API for CRDs (using workqueue) #123999

Closed

richabanker mentioned this pull request Apr 26, 2024

support SV API for CRDs (using workqueue and wait channel) #124543

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 17, 2024

k8s-ci-robot closed this Aug 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial support for StorageVersion API for CRDs #120582

Add initial support for StorageVersion API for CRDs #120582

richabanker commented Sep 11, 2023 •

edited

Loading

k8s-ci-robot commented Sep 11, 2023

alexzielenski commented Sep 12, 2023

roycaihw Feb 8, 2024

roycaihw Feb 20, 2024

roycaihw Feb 20, 2024

k8s-ci-robot commented Mar 11, 2024

k8s-ci-robot commented Mar 11, 2024

richabanker commented Mar 19, 2024

k8s-triage-robot commented Jun 17, 2024

k8s-triage-robot commented Jul 17, 2024

k8s-triage-robot commented Aug 16, 2024

k8s-ci-robot commented Aug 16, 2024

Add initial support for StorageVersion API for CRDs #120582

Add initial support for StorageVersion API for CRDs #120582

Conversation

richabanker commented Sep 11, 2023 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Sep 11, 2023

alexzielenski commented Sep 12, 2023

roycaihw Feb 8, 2024

Choose a reason for hiding this comment

roycaihw Feb 20, 2024

Choose a reason for hiding this comment

roycaihw Feb 20, 2024

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 11, 2024

k8s-ci-robot commented Mar 11, 2024

richabanker commented Mar 19, 2024

k8s-triage-robot commented Jun 17, 2024

k8s-triage-robot commented Jul 17, 2024

k8s-triage-robot commented Aug 16, 2024

k8s-ci-robot commented Aug 16, 2024

richabanker commented Sep 11, 2023 •

edited

Loading