Add types, strategy, validation skeleton #1
Conversation
|
Btw after hacking a little (by commenting out code that sets up v1beta1, v1beta2), the code runs. I can use the REST interface to create a Daemon Controller, and the controller shows up in etcd :) |
|
@vishh @rjnagal 2 groups of unit tests break - the first is related to v1beta1, v1beta2 (which I sent you an email about), and I think we can fix them by rebasing with GoogleCloudPlatform/Kubernetes. The 2nd is related to deepcopy - the error messages say that I need to generate deep copies. I tried running "./hack/update-generated-deep-copies.sh" (with/without sudo, multiple times), but the script didn't create the files after 15 minutes. Do I need to leave it running for longer? Thanks! |
AnanyaKumar
force-pushed
the
daemon-controller
branch
from
e9a2163 to
36f4f6e
Compare
|
Let's discuss offline. On Tue, Jun 16, 2015 at 7:41 PM, Ananya Kumar [email protected]
|
|
Ok I've added the generated deep copies. I think there might have been a bug in the old script. Thanks @vishh ! |
|
@rjnagal @vishh I just spoke to Vishnu offline and he mentioned that he didn't know I had submitted a pull request. I realized that I forgot to mention you guys in the PR! Could you please take a look at this PR when you get a chance, and let me know if you have feedback? Thanks! I've started writing tests for the API (I'll update this PR soon), and in parallel I've started writing code for kubectl (I've implemented kubectl 'get'). |
| @@ -213,7 +213,7 @@ function start_apiserver { | |||
| --admission_control="${ADMISSION_CONTROL}" \ | |||
| --address="${API_HOST}" \ | |||
| --port="${API_PORT}" \ | |||
| --runtime_config=api/v1beta3 \ | |||
| --runtime_config=api/v1 \ | |||
There was a problem hiding this comment.
maybe we should rebase the master branch?
There was a problem hiding this comment.
For some reason master still uses v1beta3 in local-up-cluster. Should I do the same?
There was a problem hiding this comment.
Yeah, upstream master uses v1beta3 in local-up-cluster. I rebased from upstream to your branch a couple of days ago to fix some issues :)
|
LGTM, can we squash commits and we'll merge :) |
AnanyaKumar
force-pushed
the
daemon-controller
branch
from
e150744 to
faeb89f
Compare
|
Thanks, squashed :) |
|
LGTM |
Add types, strategy, validation skeleton
| // controller. | ||
| type DaemonControllerStatus struct { | ||
| // NodesRunningDaemon is the number of nodes running the Daemon. | ||
| NodesRunningDaemon int `json:"nodes_running_daemon"` |
There was a problem hiding this comment.
Fixed in the next PR :)
A note: The Replication Controller Spec contains both a PodTemplateSpec and an ObjectReference. So far I omitted the ObjectReference from the Daemon Controller Spec because I couldn't identify where the ObjectReference is used (my guess is that it's used in older versions of the API). If necessary, I'll add the ObjectReference back in.
Also, this code compiles but doesn't pass tests yet. I need to add type specifications for the Daemon Controller in v1beta1, v1beta2, v1beta3, etc. I'll work on those additions now, but I wanted to send this "partial" PR. Thanks for taking the time to review!