Files that changed from the base of the PR and between 78336c9 and f1187c0.

• metadata-jobs/mae-consumer-job/src/main/java/com/linkedin/metadata/kafka/MaeConsumerApplication.java (2 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListener.java (1 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListenerRegistrar.java (1 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/MetadataChangeLogHook.java (1 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/UpdateIndicesHook.java (3 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/event/EntityChangeEventGeneratorHook.java (5 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/form/FormAssignmentHook.java (5 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/incident/IncidentsSummaryHook.java (9 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/ingestion/IngestionSchedulerHook.java (4 hunks)
• metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/siblings/SiblingAssociationHook.java (3 hunks)
• metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/spring/MCLGMSSpringTest.java (2 hunks)
• metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/spring/MCLMAESpringTest.java (2 hunks)
• metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/spring/MCLSpringCommonTestConfiguration.java (1 hunks)
• metadata-jobs/pe-consumer/src/main/java/com/datahub/event/PlatformEventProcessor.java (3 hunks)
• metadata-service/configuration/src/main/resources/application.yaml (3 hunks)
• metadata-service/factories/src/main/java/com/linkedin/gms/factory/kafka/KafkaEventConsumerFactory.java (1 hunks)
• metadata-service/war/src/main/java/com/linkedin/gms/CommonApplicationConfig.java (1 hunks)

• metadata-service/factories/src/main/java/com/linkedin/gms/factory/kafka/KafkaEventConsumerFactory.java

metadata-service/war/src/main/java/com/linkedin/gms/CommonApplicationConfig.java (1)

41-43: Verify the impact of new packages in @ComponentScan.

The addition of "com.linkedin.gms.factory.change", "com.datahub.event.hook", and "com.linkedin.gms.factory.notifications" to the @ComponentScan annotation expands the component scanning range. Ensure that these packages do not introduce any unintended beans or configurations that could affect the application context.

Verification successful

---

Impact of New Packages in @ComponentScan Verified

The BusinessAttributeUpdateHook class in the com.datahub.event.hook package is annotated with @Component, indicating it is a Spring bean. This confirms that the addition of this package to @ComponentScan introduces new beans into the application context. Ensure that the behavior of this component is as expected and does not introduce any unintended side effects.

• Class Identified: BusinessAttributeUpdateHook in com.datahub.event.hook
• Annotation: @Component

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the presence and impact of new packages in the component scan.

# Test: List all classes in the newly added packages to check for unintended beans.
fd --type f --extension java --exec rg --files-with-matches 'class ' {} \;

Length of output: 212798

---

Script:

#!/bin/bash
# Search for class definitions in the newly added packages to check for beans or components.
# Packages to check: com.linkedin.gms.factory.change, com.datahub.event.hook, com.linkedin.gms.factory.notifications

# List all Java files in the specified packages
fd --type f --extension java | grep -E 'com/linkedin/gms/factory/change|com/datahub/event/hook|com/linkedin/gms/factory/notifications' | xargs -I {} rg 'class ' {}

Length of output: 326

---

Script:

#!/bin/bash
# Search for class definitions and Spring annotations in the newly added packages to check for beans or components.
# Packages to check: com.linkedin.gms.factory.change, com.datahub.event.hook, com.linkedin.gms.factory.notifications

# Find Java files in the specified packages and search for class definitions with Spring annotations
fd --type f --extension java | grep -E 'com/linkedin/gms/factory/change|com/datahub/event/hook|com/linkedin/gms/factory/notifications' | xargs -I {} rg -A 5 '@Component|@Service|@Configuration' {}

Length of output: 445

metadata-jobs/mae-consumer-job/src/main/java/com/linkedin/metadata/kafka/MaeConsumerApplication.java (1)

36-38: Assess the effect of new packages in @ComponentScan.

The inclusion of "com.linkedin.gms.factory.change", "com.datahub.event.hook", and "com.linkedin.gms.factory.notifications" in the @ComponentScan annotation suggests a shift towards enhanced event handling. Verify that these changes align with the application's objectives and do not introduce conflicts or redundant beans.

metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/spring/MCLGMSSpringTest.java (2)

38-39: Ensure correct bean retrieval for MCLKafkaListenerRegistrar.

The retrieval of the MCLKafkaListenerRegistrar bean from the application context is crucial for the test. Verify that the application context is correctly configured to provide this bean.

Verification successful

---

Bean Configuration Likely Correct via Auto-Configuration

The use of @EnableAutoConfiguration in the test files suggests that Spring Boot's auto-configuration is likely handling the MCLKafkaListenerRegistrar bean setup. This mechanism typically configures beans based on the classpath and other settings, indicating that the application context should be correctly providing this bean.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the configuration of `MCLKafkaListenerRegistrar` in the application context.

# Test: Search for the bean definition in the codebase. Expect: Correct configuration of the registrar bean.
rg --type java 'MCLKafkaListenerRegistrar'

Length of output: 1175

---

Script:

#!/bin/bash
# Description: Search for Spring configuration classes or XML files that define the MCLKafkaListenerRegistrar bean.

# Test: Look for @Bean annotation or XML bean definitions for MCLKafkaListenerRegistrar.
rg '@Bean.*MCLKafkaListenerRegistrar|<bean.*MCLKafkaListenerRegistrar' --type java --type xml

Length of output: 95

---

Script:

#!/bin/bash
# Description: Search for component scanning configurations that might include MCLKafkaListenerRegistrar as a bean.

# Test: Look for @ComponentScan or similar annotations that might automatically configure MCLKafkaListenerRegistrar.
rg '@ComponentScan|@SpringBootApplication|@EnableAutoConfiguration' --type java

Length of output: 3894

---

41-54: Verify hook assertions for MCLKafkaListenerRegistrar.

The assertions have been updated to reflect the new source of hooks. Ensure that these assertions are accurate and align with the expected behavior of the MCLKafkaListenerRegistrar.

Verification successful

---

Hook Assertions Verified for MCLKafkaListenerRegistrar.

The getMetadataChangeLogHooks method in MCLKafkaListenerRegistrar correctly filters and sorts hooks, aligning with the assertions in the test file. The assertions are valid and reflect the expected behavior of the registrar.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the `MCLKafkaListenerRegistrar` provides the expected hooks.

# Test: Search for the implementation details of `getMetadataChangeLogHooks`. Expect: Correct hook instances.
ast-grep --lang java --pattern $'class MCLKafkaListenerRegistrar {
  $$$
  List<MetadataChangeLogHook> getMetadataChangeLogHooks() {
    $$$
  }
  $$$  
}'

Length of output: 156

---

Script:

#!/bin/bash
# Check if the MCLKafkaListenerRegistrar class exists in the codebase
ast-grep --lang java --pattern 'class MCLKafkaListenerRegistrar { $$$ }'

# If the class exists, check for the getMetadataChangeLogHooks method
ast-grep --lang java --pattern 'List<MetadataChangeLogHook> getMetadataChangeLogHooks() { $$$ }'

Length of output: 173

---

Script:

#!/bin/bash
# Search for the MCLKafkaListenerRegistrar class in the entire codebase
rg 'class MCLKafkaListenerRegistrar' -A 10 --glob '*.java'

# If the class is found, list all methods within it
ast-grep --lang java --pattern 'class MCLKafkaListenerRegistrar { $$$ }' --json | jq '.captures[] | .text' | xargs -I {} ast-grep --lang java --pattern '$_() { $$$ }' {}

Length of output: 1783

---

Script:

#!/bin/bash
# Search for all method definitions in the MCLKafkaListenerRegistrar class file
rg '^[ \t]*public .* MCLKafkaListenerRegistrar' -A 50 --glob 'metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListenerRegistrar.java'

Length of output: 7190

metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/spring/MCLMAESpringTest.java (2)

36-37: Ensure correct bean retrieval for MCLKafkaListenerRegistrar.

The retrieval of the MCLKafkaListenerRegistrar bean from the application context is crucial for the test. Verify that the application context is correctly configured to provide this bean.

---

39-52: Verify hook assertions for MCLKafkaListenerRegistrar.

The assertions have been updated to reflect the new source of hooks. Ensure that these assertions are accurate and align with the expected behavior of the MCLKafkaListenerRegistrar.

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/UpdateIndicesHook.java (3)

55-60: Ensure testability with @VisibleForTesting constructor.

The constructor annotated with @VisibleForTesting facilitates testing by omitting the consumerGroupSuffix. Ensure that this constructor is used appropriately in test cases.

Verification successful

---

Testability confirmed for @VisibleForTesting constructor.

The @VisibleForTesting constructor of UpdateIndicesHook is appropriately used in the UpdateIndicesHookTest.java file, ensuring its intended purpose for testing. No further action is needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `@VisibleForTesting` constructor in test cases.

# Test: Search for the usage of the `@VisibleForTesting` constructor. Expect: Correct usage in test files.
rg --type java 'new UpdateIndicesHook\('

Length of output: 588

---

40-40: Ensure proper usage of @Getter for consumerGroupSuffix.

The @Getter annotation from Lombok is used to generate a getter for consumerGroupSuffix. Ensure that this field is accessed correctly throughout the codebase.

Verification successful

---

Proper usage of @Getter for consumerGroupSuffix verified.

The @Getter annotation for consumerGroupSuffix in UpdateIndicesHook is correctly used. This field is accessed via the getConsumerGroupSuffix method, as required by the MetadataChangeLogHook interface, and is used appropriately in the codebase.

• UpdateIndicesHook implements MetadataChangeLogHook, ensuring the method is correctly defined and used.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `consumerGroupSuffix` getter in the codebase.

# Test: Search for the usage of `getConsumerGroupSuffix`. Expect: Correct usage of the getter method.
rg --type java 'getConsumerGroupSuffix'

Length of output: 367

---

Script:

#!/bin/bash
# Check the context of `getConsumerGroupSuffix` usage in MCLKafkaListenerRegistrar.java
rg --type java -A 5 -B 5 'getConsumerGroupSuffix' metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListenerRegistrar.java

# Check the context of `getConsumerGroupSuffix` usage in MetadataChangeLogHook.java
rg --type java -A 5 -B 5 'getConsumerGroupSuffix' metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/MetadataChangeLogHook.java

Length of output: 955

---

Script:

#!/bin/bash
# Check if UpdateIndicesHook implements or extends MetadataChangeLogHook or any related interface/abstract class
rg --type java 'class UpdateIndicesHook' -A 5 metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/UpdateIndicesHook.java

Length of output: 401

---

42-53: Verify constructor parameter integration for consumerGroupSuffix.

The constructor now includes a consumerGroupSuffix parameter. Ensure that this parameter is correctly passed and utilized within the class.

metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/spring/MCLSpringCommonTestConfiguration.java (1)

37-43: Review the impact of modified component scanning.

The changes to the @ComponentScan annotation have expanded the scope of component scanning to include additional packages. Ensure that the newly included packages contain the necessary Spring-managed beans and that there are no conflicts or unintended dependencies introduced.

Verification successful

---

No impact from modified component scanning due to absence of files.

The specified directories for the expanded component scanning do not contain any Java files. Therefore, the modification to the @ComponentScan annotation does not introduce any new Spring-managed beans or dependencies.

• Directories checked:
  • metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/dao/producer
  • metadata-jobs/mae-consumer/src/main/java/com/linkedin/gms/factory/change
  • metadata-jobs/mae-consumer/src/main/java/com/datahub/event/hook
  • metadata-jobs/mae-consumer/src/main/java/com/linkedin/gms/factory/notifications

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the presence of Spring-managed beans in the newly included packages.

# Test: Search for @Component, @Service, @Repository, and @Configuration annotations in the new packages.
# Expect: Relevant Spring-managed beans should be present.
rg --type java '@Component|@Service|@Repository|@Configuration' -g 'metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/dao/producer/**' -g 'metadata-jobs/mae-consumer/src/main/java/com/linkedin/gms/factory/change/**' -g 'metadata-jobs/mae-consumer/src/main/java/com/datahub/event/hook/**' -g 'metadata-jobs/mae-consumer/src/main/java/com/linkedin/gms/factory/notifications/**'

Length of output: 539

---

Script:

#!/bin/bash
# List all Java files in the specified directories to verify their existence.
fd --type f --extension java metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/dao/producer
fd --type f --extension java metadata-jobs/mae-consumer/src/main/java/com/linkedin/gms/factory/change
fd --type f --extension java metadata-jobs/mae-consumer/src/main/java/com/datahub/event/hook
fd --type f --extension java metadata-jobs/mae-consumer/src/main/java/com/linkedin/gms/factory/notifications

Length of output: 416

metadata-jobs/pe-consumer/src/main/java/com/datahub/event/PlatformEventProcessor.java (1)

48-52: Logging enhancement for platform hooks initialization.

The added logging statement provides improved visibility into which platform hooks are enabled during the initialization of PlatformEventProcessor. This can aid in debugging and operational monitoring.

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListener.java (4)

36-39: Logging initialization of MCL hooks.

The logging statement in the constructor provides insight into the enabled MCL hooks for a given consumer group, which is useful for debugging and operational transparency.

---

42-54: Comprehensive logging for message consumption.

The detailed logging in the consume method provides valuable information about the Kafka message being processed, including consumer group, key, topic, partition, offset, and timestamp. This is beneficial for debugging and monitoring message flow.

---

57-67: Error handling during message deserialization.

The error handling mechanism for message deserialization is appropriate, as it logs the error and increments a failure counter. However, consider whether additional actions, such as alerting or retry mechanisms, are needed based on the criticality of the messages.

---

77-94: Error handling for hook invocation.

The error handling for hook invocation is designed to skip failed hooks and continue processing. This approach ensures that a single failure does not block the processing of other hooks, but it may lead to data inconsistency if not handled properly. Consider whether additional logging or alerting is required for failed hooks.

Verification successful

---

Consider Additional Alerting for Hook Invocation Failures

The current implementation logs errors for failed hook invocations using log.error. However, if these failures are critical, you might want to implement additional alerting mechanisms to ensure timely awareness and response to such issues.

• Location to Review: metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListener.java (Lines 77-94)

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if there are additional logging or alerting mechanisms for hook invocation failures.

# Test: Search for logging or alerting logic related to hook invocation failures.
# Expect: Mechanisms should be in place if critical.
rg --type java 'log.error|alert' -A 5

Length of output: 396810

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/MCLKafkaListenerRegistrar.java (2)

1-32: Ensure Proper Configuration and Initialization.

The class MCLKafkaListenerRegistrar is responsible for setting up Kafka listeners for Metadata Change Log hooks. Ensure that all configurations, such as consumerGroupBase, mclVersionedTopicName, and mclTimeseriesTopicName, are correctly set in the application properties to avoid runtime issues.

---

92-111: Validate Kafka Listener Endpoint Configuration.

The createListenerEndpoint method sets up the Kafka listener endpoint. Ensure that the method reference MCLKafkaListener.class.getMethod("consume", ConsumerRecord.class) is correct and that the MCLKafkaListener class implements the consume method with the expected signature.

Verification successful

---

Kafka Listener Endpoint Configuration Verified

The consume method in the MCLKafkaListener class exists with the correct signature. The method reference in createListenerEndpoint is valid and correctly configured.

• Method: void consume(ConsumerRecord<String, GenericRecord> consumerRecord)

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify that the `consume` method exists in the `MCLKafkaListener` class with the correct signature.

# Search for the method definition in the MCLKafkaListener class.
ast-grep --lang java --pattern $'class MCLKafkaListener {
  $$$
  void consume(ConsumerRecord<String, GenericRecord> record) {
    $$$
  }
  $$$
}'

Length of output: 148

---

Script:

#!/bin/bash
# Find the file containing the MCLKafkaListener class and list its methods to verify the consume method.

# Locate the file containing the MCLKafkaListener class.
fd 'MCLKafkaListener.java' --exec cat {} +

# List all methods in the MCLKafkaListener class to verify the consume method.
ast-grep --lang java --pattern $'class MCLKafkaListener {
  $$$
  $_() {
    $$$
  }
  $$$
}'

Length of output: 4334

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/form/FormAssignmentHook.java (4)

58-62: Field Renaming for Consistency.

The fields formService and isEnabled have been renamed for consistency with Java naming conventions. This improves code readability and maintainability.

---

74-76: Testing Constructor Provides Flexibility.

The addition of a testing constructor that defaults consumerGroupSuffix to an empty string is a good practice. It facilitates easier unit testing by reducing the dependencies required for instantiation.

---

87-87: Simplified isEnabled Method.

The isEnabled method now directly returns the isEnabled field, which simplifies the logic and improves readability.

---

67-72: Verify Configuration for Consumer Group Suffix.

The constructor now requires a consumerGroupSuffix parameter. Ensure that the configuration property ${forms.hook.consumerGroupSuffix} is correctly set in the application properties to avoid runtime issues.

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/ingestion/IngestionSchedulerHook.java (4)

33-36: Field Renaming for Consistency.

The fields scheduler and isEnabled have been renamed for consistency with Java naming conventions. This improves code readability and maintainability.

---

48-51: Testing Constructor Provides Flexibility.

The addition of a testing constructor that defaults consumerGroupSuffix to an empty string is a good practice. It facilitates easier unit testing by reducing the dependencies required for instantiation.

---

56-56: Simplified isEnabled Method.

The isEnabled method now directly returns the isEnabled field, which simplifies the logic and improves readability.

---

41-46: Verify Configuration for Consumer Group Suffix.

The constructor now requires a consumerGroupSuffix parameter. Ensure that the configuration property ${ingestionScheduler.consumerGroupSuffix} is correctly set in the application properties to avoid runtime issues.

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/event/EntityChangeEventGeneratorHook.java (2)

116-116: Confirm logical consistency of isEnabled().

The isEnabled() method now returns the isEnabled variable. Ensure that this change maintains the intended logic throughout the codebase.

Verification successful

---

Logical Consistency Verified for isEnabled() Method

The isEnabled() method in EntityChangeEventGeneratorHook.java correctly returns the isEnabled variable, which is initialized based on an external configuration with a default value of true. This ensures logical consistency with its intended purpose. No further issues were found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify logical consistency of `isEnabled()` usage.

# Test: Search for all usages of `isEnabled()` method.
# Expect: Consistent logic with previous implementation.
rg --type java 'isEnabled\(\)'

Length of output: 5537

---

Script:

#!/bin/bash
# Find the definition and usage of the `isEnabled` variable within the EntityChangeEventGeneratorHook.java file.
fd 'EntityChangeEventGeneratorHook.java' -x rg 'isEnabled' {}

Length of output: 395

---

3-3: Ensure proper usage of @VisibleForTesting.

The @VisibleForTesting annotation is used to indicate that the constructor is primarily for testing purposes. Ensure that this constructor is only used in test scenarios to maintain code clarity and prevent misuse.

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/incident/IncidentsSummaryHook.java (1)

97-97: Confirm logical consistency of isEnabled().

The isEnabled() method now returns the isEnabled variable. Ensure that this change maintains the intended logic throughout the codebase.

Verification successful

---

Logical consistency of isEnabled() is confirmed. The isEnabled() method in IncidentsSummaryHook correctly returns the isEnabled field, which is initialized via configuration and used to control the execution of the invoke method. This maintains the intended logic.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify logical consistency of `isEnabled()` usage.

# Test: Search for all usages of `isEnabled()` method.
# Expect: Consistent logic with previous implementation.
rg --type java 'isEnabled\(\)'

Length of output: 5537

---

Script:

#!/bin/bash
# Search for the definition and usage of `isEnabled` within the `IncidentsSummaryHook` class.
ast-grep --lang java --pattern 'class IncidentsSummaryHook {
  $$$
  boolean isEnabled;
  $$$
}' 

# Search for the `isEnabled()` method implementation in `IncidentsSummaryHook`.
ast-grep --lang java --pattern 'class IncidentsSummaryHook {
  $$$
  public boolean isEnabled() {
    return $_;
  }
  $$$
}'

Length of output: 226

---

Script:

#!/bin/bash
# Search for the class definition of `IncidentsSummaryHook` to understand its structure.
rg --type java 'class IncidentsSummaryHook' -A 20

# Search for the `isEnabled` field and method within `IncidentsSummaryHook` more broadly.
rg --type java 'isEnabled' metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/incident/IncidentsSummaryHook.java -A 5 -B 5

Length of output: 8808

metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/siblings/SiblingAssociationHook.java (2)

82-83: Ensure configuration property is defined.

Verify that the configuration property siblings.consumerGroupSuffix is correctly defined in the configuration files.

---

114-114: Confirm logical consistency of isEnabled().

The isEnabled() method now returns the isEnabled variable. Ensure that this change maintains the intended logic throughout the codebase.

Verification successful

---

Logical consistency of isEnabled() is maintained in SiblingAssociationHook. The isEnabled() method returns the isEnabled variable, and its usage in the invoke method is consistent with its intended purpose of conditionally executing logic based on the enabled state. No issues found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify logical consistency of `isEnabled()` usage.

# Test: Search for all usages of `isEnabled()` method.
# Expect: Consistent logic with previous implementation.
rg --type java 'isEnabled\(\)'

Length of output: 5537

---

Script:

#!/bin/bash
# Extract the implementation of the `isEnabled()` method in SiblingAssociationHook
ast-grep --lang java --pattern $'class SiblingAssociationHook {
  $$$
  public boolean isEnabled() {
    $$$
  }
  $$$
}' 

Length of output: 122

---

Script:

#!/bin/bash
# Locate and extract the `isEnabled()` method implementation in SiblingAssociationHook
rg -A 10 'public boolean isEnabled\(\)' metadata-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/siblings/SiblingAssociationHook.java

Length of output: 442

metadata-service/configuration/src/main/resources/application.yaml (6)

299-299: LGTM!

The addition of consumerGroupSuffix to the siblings section enhances configurability for Kafka consumer groups.

---

302-302: LGTM!

The addition of consumerGroupSuffix to the updateIndices section enhances configurability for Kafka consumer groups.

---

305-305: LGTM!

The addition of consumerGroupSuffix to the ingestionScheduler section enhances configurability for Kafka consumer groups.

---

306-310: LGTM!

The new properties in the incidents.hook section provide enhanced configurability for incident management and Kafka consumer groups.

---

387-387: LGTM!

The addition of consumerGroupSuffix to the entityChangeEvents section enhances configurability for Kafka consumer groups.

---

472-472: LGTM!

The addition of consumerGroupSuffix to the forms.hook section enhances configurability for Kafka consumer groups.

Files that changed from the base of the PR and between f1187c0 and 7122214.

• docs/how/kafka-config.md (1 hunks)