Files that changed from the base of the PR and between 4b9844d and d497de1.

• metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java (7 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/graph/neo4j/Neo4jGraphServiceTest.java (1 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/graph/search/SearchGraphServiceTestBase.java (8 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/search/LineageServiceTestBase.java (1 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/search/SearchServiceTestBase.java (1 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/search/TestEntityTestBase.java (1 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/search/indexbuilder/IndexBuilderTestBase.java (3 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/systemmetadata/SystemMetadataServiceTestBase.java (1 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/timeseries/search/TimeseriesAspectServiceTestBase.java (1 hunks)
• metadata-io/src/test/java/io/datahubproject/test/fixtures/search/SearchLineageFixtureConfiguration.java (2 hunks)
• metadata-io/src/test/java/io/datahubproject/test/search/BulkProcessorProxyListener.java (1 hunks)
• metadata-io/src/test/java/io/datahubproject/test/search/BulkProcessorTestUtils.java (1 hunks)
• metadata-io/src/test/java/io/datahubproject/test/search/SearchTestUtils.java (4 hunks)
• metadata-io/src/test/java/io/datahubproject/test/search/config/SearchTestContainerConfiguration.java (2 hunks)
• metadata-service/configuration/src/main/java/com/linkedin/metadata/config/search/GraphQueryConfiguration.java (1 hunks)

• metadata-io/src/test/java/com/linkedin/metadata/graph/neo4j/Neo4jGraphServiceTest.java

metadata-service/configuration/src/main/java/com/linkedin/metadata/config/search/GraphQueryConfiguration.java (1)

Line range hint 1-12:
LGTM! But verify the impact of removing testDefaults.

The removal of the testDefaults instance might affect unit tests or components relying on these default values. Ensure that all tests and components are updated to handle this change.

Verification successful

---

LGTM! But verify the impact of removing testDefaults.

The removal of the testDefaults instance might affect unit tests or components relying on these default values. Ensure that all tests and components are updated to handle this change.

• ESGraphQueryDAOTest.java references GraphQueryConfiguration but does not directly use testDefaults.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of removing `testDefaults` from `GraphQueryConfiguration`.

# Test: Search for the usage of `testDefaults`. Expect: No occurrences.
rg --type java -A 5 $'GraphQueryConfiguration.testDefaults'

Length of output: 58

---

Script:

#!/bin/bash
# Description: Verify if there are any test cases or configurations that might be impacted by the removal of `testDefaults`.

# Test: Search for any references to `GraphQueryConfiguration` within test files.
rg --type java -A 5 'GraphQueryConfiguration' --glob '**/*Test.java'

Length of output: 1722

---

Script:

#!/bin/bash
# Description: Verify if `testDefaults` was used in `ESGraphQueryDAOTest.java`.

# Test: Search for any references to `testDefaults` within `ESGraphQueryDAOTest.java`.
rg --type java -A 5 'testDefaults' metadata-io/src/test/java/com/linkedin/metadata/graph/search/ESGraphQueryDAOTest.java

Length of output: 120

metadata-io/src/test/java/io/datahubproject/test/search/BulkProcessorProxyListener.java (1)

1-43: LGTM!

The class BulkProcessorProxyListener correctly implements the BulkProcessor.Listener interface and tracks unsent bulk items. The waitForBulkProcessed method ensures all bulk items are processed, which is crucial for test stability.

metadata-io/src/test/java/io/datahubproject/test/search/BulkProcessorTestUtils.java (1)

1-67: LGTM!

The class BulkProcessorTestUtils provides well-structured utility methods for testing bulk processors. The use of ReflectionTestUtils is appropriate for accessing private fields in tests.

metadata-io/src/test/java/io/datahubproject/test/search/config/SearchTestContainerConfiguration.java (1)

69-83: Enhancement: Added listener to bulk processor.

The addition of replaceBulkProcessorListener(esBulkProcessor) enhances the bulk processor's functionality by integrating a listener. Ensure that the replaceBulkProcessorListener method is correctly implemented and does not introduce side effects.

metadata-io/src/test/java/com/linkedin/metadata/systemmetadata/SystemMetadataServiceTestBase.java (1)

47-49: Improvement: Added synchronization calls to wipe method.

The addition of syncAfterWrite(getBulkProcessor()) before and after _client.clear() ensures that any pending writes are completed, enhancing the reliability of the test setup. Verify that these synchronization calls do not introduce any performance issues.

metadata-io/src/test/java/io/datahubproject/test/search/SearchTestUtils.java (2)

46-48: Update: Added IOException to syncAfterWrite method.

The syncAfterWrite method now includes IOException in its throws clause and calls BulkProcessorTestUtils.syncAfterWrite. Ensure that the method handles I/O-related exceptions correctly and that the call to BulkProcessorTestUtils.syncAfterWrite is appropriate.

---

259-269: Addition: New method getGraphQueryConfiguration.

The new method getGraphQueryConfiguration provides a standardized way to configure graph query settings with several configuration parameters. Ensure that the configuration parameters are appropriate and meet the requirements of the graph query operations.

metadata-io/src/test/java/io/datahubproject/test/fixtures/search/SearchLineageFixtureConfiguration.java (2)

4-4: LGTM! The new import statement is necessary.

The import statement import static io.datahubproject.test.search.SearchTestUtils.getGraphQueryConfiguration is required for the changes made in the graphService method.

---

175-175: LGTM! Verify the behavior of getGraphQueryConfiguration().

The change from GraphQueryConfiguration.testDefaults to getGraphQueryConfiguration() introduces dynamic behavior. Ensure that getGraphQueryConfiguration() returns the expected configuration.

Verification successful

---

LGTM! Verify the behavior of getGraphQueryConfiguration().

The change from GraphQueryConfiguration.testDefaults to getGraphQueryConfiguration() introduces dynamic behavior. Ensure that getGraphQueryConfiguration() returns the expected configuration, which it does by setting specific properties for testing purposes.

• getGraphQueryConfiguration method returns a configuration with:
  • batchSize set to 1000
  • timeoutSeconds set to 10
  • maxResult set to 10000
  • enableMultiPathSearch set to true
  • boostViaNodes set to true

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the behavior of `getGraphQueryConfiguration()`.

# Test: Search for the implementation of `getGraphQueryConfiguration`. Expect: Verify its behavior to ensure it returns the expected configuration.
rg --type java 'getGraphQueryConfiguration'

Length of output: 929

---

Script:

#!/bin/bash
# Extract the implementation of `getGraphQueryConfiguration` from `SearchTestUtils.java`.

# Use `rg` to find and display the implementation of `getGraphQueryConfiguration`.
rg --type java --context 10 'public static GraphQueryConfiguration getGraphQueryConfiguration' metadata-io/src/test/java/io/datahubproject/test/search/SearchTestUtils.java

Length of output: 796

metadata-io/src/test/java/com/linkedin/metadata/search/TestEntityTestBase.java (2)

73-73: LGTM! The addition improves reliability.

The call to syncAfterWrite(getBulkProcessor()) before elasticSearchService.clear(opContext) ensures that any writes to the bulk processor are completed before the clearing operation, enhancing the reliability of the test setup.

---

75-75: LGTM! The addition further improves reliability.

The call to syncAfterWrite(getBulkProcessor()) after elasticSearchService.clear(opContext) ensures that any writes to the bulk processor are completed after the clearing operation, further enhancing the reliability of the test setup.

metadata-io/src/test/java/com/linkedin/metadata/search/indexbuilder/IndexBuilderTestBase.java (4)

42-42: LGTM! Promotes better test isolation.

Changing _indexClient from a static to an instance-level field promotes better test isolation and state management across different test instances.

---

44-44: LGTM! Promotes better test isolation.

Changing testDefaultBuilder from a static to an instance-level field promotes better test isolation and state management across different test instances.

---

66-66: LGTM! Improves encapsulation.

Changing the wipe method from static to an instance-level method ensures that it operates on the instance state, improving encapsulation and reducing side effects across tests.

---

89-89: LGTM! Improves encapsulation.

Changing the getTestIndex method from static to an instance-level method ensures that it operates on the instance state, improving encapsulation and reducing side effects across tests.

metadata-io/src/test/java/com/linkedin/metadata/graph/search/SearchGraphServiceTestBase.java (3)

79-79: Improvement: Added synchronization after write operations.

The call to syncAfterWrite() ensures that any necessary synchronization occurs after the client is cleared, enhancing the reliability of the setup process.

---

Line range hint 117-122: Improvement: Centralized configuration management.

The method now uses _graphQueryConfiguration.isEnableMultiPathSearch() directly, centralizing the configuration management and reducing redundancy.

---

303-311: Addition: Deduplication method for related entities.

The new method deduplicateRelatedEntitiesByRelationshipTypeAndDestination facilitates the deduplication of related entities, addressing issues with duplicates in ElasticSearchGraphService.

metadata-io/src/test/java/com/linkedin/metadata/search/SearchServiceTestBase.java (1)

111-111: Improvement: Added synchronization after write operations.

The call to syncAfterWrite(getBulkProcessor()) ensures that any write operations to the bulk processor are synchronized before proceeding with the clear() operation on the elasticSearchService, enhancing the reliability of the test setup.

metadata-io/src/test/java/com/linkedin/metadata/search/LineageServiceTestBase.java (1)

165-165: Improvement: Added synchronization after write operations.

The call to syncAfterWrite(getBulkProcessor()) ensures that any write operations to the bulk processor are synchronized before proceeding with the clear() operation on the elasticSearchService, enhancing the reliability of the test setup.

metadata-io/src/test/java/com/linkedin/metadata/timeseries/search/TimeseriesAspectServiceTestBase.java (1)

1294-1294: Broadening the scope of exceptions.

The method signature now throws a general Exception instead of InterruptedException. This change broadens the scope of exceptions that can be thrown by this method. Ensure that this change is intentional and consider if more specific exception handling is needed.

metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java (6)

1947-1950: Verify the correctness of helper method.

Ensure that the helper method deduplicateRelatedEntitiesByRelationshipTypeAndDestination is correctly implemented and does not introduce any side effects.

---

276-276: Verify the correctness of getGraphQueryConfiguration.

Ensure that the getGraphQueryConfiguration method is correctly implemented and does not introduce any side effects.

Verification successful

---

The getGraphQueryConfiguration method is correctly implemented and does not introduce any side effects.

• The method initializes a GraphQueryConfiguration object with specific settings without any complex logic.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the implementation of `getGraphQueryConfiguration`.

# Test: Search for the function implementation. Expect: Correct implementation without side effects.
rg --type java 'GraphQueryConfiguration getGraphQueryConfiguration()'

Length of output: 219

---

Script:

#!/bin/bash
# Description: Retrieve the implementation of `getGraphQueryConfiguration` from `SearchTestUtils.java`.

# Extract the implementation details of the `getGraphQueryConfiguration` method.
rg --type java 'public static GraphQueryConfiguration getGraphQueryConfiguration()' -A 20 metadata-io/src/test/java/io/datahubproject/test/search/SearchTestUtils.java

Length of output: 471

---

1909-1914: Verify the correctness of the conversion logic.

Ensure that the conversion logic in convertEdgesToRelatedEntities is accurate and does not introduce any side effects.

Verification successful

---

The conversion logic in convertEdgesToRelatedEntities is accurate and does not introduce any side effects.

The function is used in a test method to validate the output of a service method, ensuring its correctness.

• convertEdgesToRelatedEntities converts edges to related entities.
• The test method testHighlyConnectedGraphWalk confirms the accuracy of this conversion.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the conversion logic.

# Test: Search for the usage of `convertEdgesToRelatedEntities`. Expect: Accurate conversion logic without side effects.
rg --type java 'convertEdgesToRelatedEntities'

Length of output: 541

---

Script:

#!/bin/bash
# Extract the relevant lines of code around the usages of `convertEdgesToRelatedEntities` to understand the context.

# Extract lines around the first usage
rg --type java -A 10 -B 10 'convertEdgesToRelatedEntities' metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java

Length of output: 1837

---

1903-1906: Verify the correctness of helper methods.

Ensure that the helper methods convertEdgesToRelatedEntities and deduplicateRelatedEntitiesByRelationshipTypeAndDestination are correctly implemented and do not introduce any side effects.

Verification successful

---

The helper methods are correctly implemented.

• convertEdgesToRelatedEntities correctly converts a list of Edge objects to a set of RelatedEntity objects.
• deduplicateRelatedEntitiesByRelationshipTypeAndDestination correctly deduplicates RelatedEntity objects based on their relationship type and destination or URN.

No side effects were found in these implementations.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of helper methods.

# Test: Search for the implementation of helper methods. Expect: Correct implementation without side effects.
rg --type java 'Set<RelatedEntity> convertEdgesToRelatedEntities' && rg --type java 'Set<RelatedEntity> deduplicateRelatedEntitiesByRelationshipTypeAndDestination'

Length of output: 680

---

Script:

#!/bin/bash
# Extract the implementation of convertEdgesToRelatedEntities in GraphServiceTestBase.java
rg --context 20 'protected Set<RelatedEntity> convertEdgesToRelatedEntities' metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java

# Extract the implementation of deduplicateRelatedEntitiesByRelationshipTypeAndDestination in GraphServiceTestBase.java
rg --context 20 'protected Set<RelatedEntity> deduplicateRelatedEntitiesByRelationshipTypeAndDestination' metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java

# Extract the implementation of deduplicateRelatedEntitiesByRelationshipTypeAndDestination in SearchGraphServiceTestBase.java
rg --context 20 'protected Set<RelatedEntity> deduplicateRelatedEntitiesByRelationshipTypeAndDestination' metadata-io/src/test/java/com/linkedin/metadata/graph/search/SearchGraphServiceTestBase.java

Length of output: 4845

---

384-384: Verify the correctness of _graphQueryConfiguration.isEnableMultiPathSearch.

Ensure that _graphQueryConfiguration is properly initialized and isEnableMultiPathSearch returns the expected value.

Verification successful

Let's search for the initialization of _graphQueryConfiguration in the relevant files to ensure it is properly set up.

---

Let's search for the implementation of getGraphQueryConfiguration() to ensure it correctly initializes _graphQueryConfiguration.

---

Let's search for the definition of getGraphQueryConfiguration across the entire codebase to locate its implementation.

---

Let's inspect the implementation of getGraphQueryConfiguration in SearchTestUtils.java to verify how _graphQueryConfiguration is initialized.

---

The initialization of _graphQueryConfiguration is correct and isEnableMultiPathSearch will return the expected value.

• The method getGraphQueryConfiguration in SearchTestUtils.java sets enableMultiPathSearch to true, ensuring consistent behavior.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of `_graphQueryConfiguration.isEnableMultiPathSearch`.

# Test: Search for the usage of `_graphQueryConfiguration.isEnableMultiPathSearch`. Expect: Proper initialization and expected return value.
rg --type java '_graphQueryConfiguration.isEnableMultiPathSearch()'

Length of output: 598

---

Script:

#!/bin/bash
# Description: Verify the initialization of `_graphQueryConfiguration`.

# Search for the initialization of `_graphQueryConfiguration` in GraphServiceTestBase.java and SearchGraphServiceTestBase.java
rg --type java '_graphQueryConfiguration' metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java metadata-io/src/test/java/com/linkedin/metadata/graph/search/SearchGraphServiceTestBase.java

Length of output: 1279

---

Script:

#!/bin/bash
# Description: Verify the implementation of `getGraphQueryConfiguration`.

# Search for the implementation of `getGraphQueryConfiguration` in the relevant files
rg --type java 'GraphQueryConfiguration getGraphQueryConfiguration()' metadata-io/src/test/java/com/linkedin/metadata/graph/GraphServiceTestBase.java

Length of output: 151

---

Script:

#!/bin/bash
# Description: Verify the implementation of `getGraphQueryConfiguration`.

# Search for the definition of `getGraphQueryConfiguration` across the entire codebase
rg --type java 'GraphQueryConfiguration getGraphQueryConfiguration()'

Length of output: 219

---

Script:

#!/bin/bash
# Description: Display the implementation of `getGraphQueryConfiguration`.

# Display the implementation of `getGraphQueryConfiguration` in `SearchTestUtils.java`
rg --type java -A 10 'GraphQueryConfiguration getGraphQueryConfiguration()' metadata-io/src/test/java/io/datahubproject/test/search/SearchTestUtils.java

Length of output: 455

---

1916-1918: Verify the correctness of the deduplication logic.

Ensure that the deduplication logic in deduplicateRelatedEntitiesByRelationshipTypeAndDestination is accurate and does not introduce any side effects.

Verification successful

---

The deduplication logic in deduplicateRelatedEntitiesByRelationshipTypeAndDestination is accurate and does not introduce any side effects.

The test cases validate the correctness of the deduplication logic, ensuring that it functions as intended.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the deduplication logic.

# Test: Search for the usage of `deduplicateRelatedEntitiesByRelationshipTypeAndDestination`. Expect: Accurate deduplication logic without side effects.
rg --type java 'deduplicateRelatedEntitiesByRelationshipTypeAndDestination'

Length of output: 1104

---

Script:

#!/bin/bash
# Description: Gather information about the RelatedEntitiesResult class and the getEntities() method.

# Find the definition of the RelatedEntitiesResult class
rg --type java 'class RelatedEntitiesResult'

# Find the getEntities() method within the RelatedEntitiesResult class
rg --type java 'RelatedEntitiesResult' -A 20 | rg 'getEntities'

# Find the test cases that use the deduplicateRelatedEntitiesByRelationshipTypeAndDestination function
rg --type java 'deduplicateRelatedEntitiesByRelationshipTypeAndDestination' -A 10 | rg 'test'

Length of output: 9678

---

Script:

#!/bin/bash
# Description: Locate the definition of the getEntities() method within the RelatedEntitiesResult class and gather details of the test cases using deduplicateRelatedEntitiesByRelationshipTypeAndDestination.

# Find the definition of the getEntities() method within the RelatedEntitiesResult class
rg --type java 'class RelatedEntitiesResult' -A 50 | rg 'getEntities'

# Gather details of the test cases using deduplicateRelatedEntitiesByRelationshipTypeAndDestination
rg --type java 'deduplicateRelatedEntitiesByRelationshipTypeAndDestination' -A 20 | rg '@Test'

Length of output: 351

---

Script:

#!/bin/bash
# Description: Locate the definition of the getEntities() method within the RelatedEntitiesResult class and extract full details of the test cases using deduplicateRelatedEntitiesByRelationshipTypeAndDestination.

# Find the definition of the getEntities() method within the RelatedEntitiesResult class
rg --type java 'RelatedEntitiesResult' -A 100 | rg 'getEntities'

# Extract full details of the test cases using deduplicateRelatedEntitiesByRelationshipTypeAndDestination
rg --type java 'deduplicateRelatedEntitiesByRelationshipTypeAndDestination' -A 50 | rg -B 50 '@Test'

Length of output: 16435

---

Script:

#!/bin/bash
# Description: Perform an exhaustive search for the getEntities() method within the RelatedEntitiesResult class and review the full content of the test cases involving deduplicateRelatedEntitiesByRelationshipTypeAndDestination.

# Find the definition of the getEntities() method within the RelatedEntitiesResult class
rg --type java 'class RelatedEntitiesResult' -A 200 | rg 'getEntities'

# Review the full content of the test cases involving deduplicateRelatedEntitiesByRelationshipTypeAndDestination
rg --type java 'deduplicateRelatedEntitiesByRelationshipTypeAndDestination' -A 100 -B 100

Length of output: 79626