fix(ingestion/lookml): emit dummy sql condition for lookml custom condition tag #11008
Conversation
|
Warning Rate limit exceeded@sid-acryl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 21 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes enhance the Looker integration by refining SQL handling and improving metadata structures. Key updates include shifting from dynamic SQL conditions to static outputs, reorganizing import statements for clarity, and introducing new LookML views for better data querying. These modifications bolster metadata tracking and enhance error handling, facilitating improved data governance and lineage management within the framework. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LookerIntegration
participant MetadataStore
User->>LookerIntegration: Request data with conditions
LookerIntegration->>LookerIntegration: Process SQL with new static logic
LookerIntegration->>MetadataStore: Store updated metadata
MetadataStore-->>LookerIntegration: Confirm storage
LookerIntegration-->>User: Return requested data
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
the
ingestion
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (10)
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (1)
98-114: Document the function with examples.Adding examples of input and output SQL strings in the function docstring would help future maintainers understand the function's behavior.
def _complete_in_complete_sql(raw_view: dict, sql: str) -> str: """ Ensures SQL fragments include necessary SELECT and FROM clauses. Args: raw_view (dict): The raw view dictionary containing view details. sql (str): The SQL fragment to be completed. Returns: str: The completed SQL string. Example: Input: "column1, column2" Output: "SELECT column1, column2 FROM view_name" """ ...metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py (2)
317-323: Handle edge cases when retrieving transformed SQL.The
datahub_transformed_sqlmethod should include error handling for cases where the "datahub_transformed_sql" key is missing or its value is malformed. This will prevent potential runtime errors and ensure the method handles edge cases gracefully.
- File:
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py- Lines: 317-323
Suggested Update:
Add error handling in thedatahub_transformed_sqlmethod to check if the "datahub_transformed_sql" key exists and its value is valid before returning it.Analysis chain
Handle edge cases when retrieving transformed SQL.
Ensure that the method handles edge cases, such as missing or malformed SQL strings, gracefully.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Test: Ensure the method handles missing or malformed SQL strings. rg --type python -A 5 $'datahub_transformed_sql'Length of output: 78
Script:
#!/bin/bash # Search for the implementation of the `datahub_transformed_sql` method in Python files ast-grep --lang python --pattern $'def datahub_transformed_sql(self) -> str: $$$' # Search for any error handling related to `derived_table` or `datahub_transformed_sql` rg 'derived_table' -A 5 rg 'datahub_transformed_sql' -A 5Length of output: 53203
273-287: Handle edge cases when retrieving transformed SQL table names.The method
datahub_transformed_sql_table_nameshould be reviewed to ensure it handles edge cases, such as missing or malformed SQL table names, gracefully. No direct evidence of handling these edge cases was found in the current codebase.
- Ensure the method has proper error handling for missing or malformed SQL table names.
- Consider adding unit tests to cover these scenarios.
Analysis chain
Handle edge cases when retrieving transformed SQL table names.
Ensure that the method handles edge cases, such as missing or malformed SQL table names, gracefully.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Test: Ensure the method handles missing or malformed SQL table names. rg --type python -A 5 $'datahub_transformed_sql_table_name'Length of output: 89
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Search for test cases or invocations of the `datahub_transformed_sql_table_name` method rg 'datahub_transformed_sql_table_name' -A 10Length of output: 6659
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Search for unit tests or error handling logic involving the `datahub_transformed_sql_table_name` method rg 'datahub_transformed_sql_table_name' -g '*test*.py' -A 10Length of output: 60
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Search for any references to the `datahub_transformed_sql_table_name` method across the entire codebase rg 'datahub_transformed_sql_table_name' -A 10Length of output: 6659
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (2)
262-262: Handle edge cases when retrieving transformed SQL.The
datahub_transformed_sqlmethod does not handle edge cases such as missing or malformed SQL strings. It directly returns the value from thederived_tabledictionary, which could lead to errors if the key is missing or the value is malformed. Consider adding checks to handle these scenarios gracefully.
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py(lines around 262)Analysis chain
Handle edge cases when retrieving transformed SQL.
Ensure that the method handles edge cases, such as missing or malformed SQL strings, gracefully.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Test: Ensure the method handles missing or malformed SQL strings. rg --type python -A 5 $'datahub_transformed_sql'Length of output: 78
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Test: Ensure the method handles missing or malformed SQL strings. rg -A 10 'def datahub_transformed_sql'Length of output: 2549
481-483: Handle edge cases when retrieving transformed SQL table names.The method
datahub_transformed_sql_table_namedoes not handle edge cases for malformed SQL table names. It falls back to thesql_table_namemethod, which retrieves the name but does not validate or handle malformed inputs. Consider adding validation and error handling to ensure robustness.
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py:
datahub_transformed_sql_table_namesql_table_name_get_sql_table_name_fieldAnalysis chain
Handle edge cases when retrieving transformed SQL table names.
Ensure that the method handles edge cases, such as missing or malformed SQL table names, gracefully.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Test: Ensure the method handles missing or malformed SQL table names. rg --type python -A 5 $'datahub_transformed_sql_table_name'Length of output: 89
Script:
#!/bin/bash # Description: Verify the method handles edge cases gracefully. # Test: Ensure the method handles missing or malformed SQL table names. rg --type py -A 5 'datahub_transformed_sql_table_name'Length of output: 4037
Script:
#!/bin/bash # Description: Verify how the sql_table_name method handles malformed SQL table names. # Locate the sql_table_name method definition rg --type py -A 5 'def sql_table_name'Length of output: 816
Script:
#!/bin/bash # Description: Verify how the _get_sql_table_name_field method handles malformed SQL table names. # Locate the _get_sql_table_name_field method definition rg --type py -A 5 'def _get_sql_table_name_field'Length of output: 790
metadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.json (5)
1717-1765: Add descriptions for schema fields.The
descriptionfields for the schema fields are empty. Adding descriptions will improve the usability of the metadata.- "description": "", + "description": "Description of the field",
Line range hint
1476-1524:
Add descriptions for schema fields.The
descriptionfields for the schema fields are empty. Adding descriptions will improve the usability of the metadata.- "description": "", + "description": "Description of the field",
Line range hint
1291-1339:
Add descriptions for schema fields.The
descriptionfields for the schema fields are empty. Adding descriptions will improve the usability of the metadata.- "description": "", + "description": "Description of the field",
Line range hint
1100-1148:
Add descriptions for schema fields.The
descriptionfields for the schema fields are empty. Adding descriptions will improve the usability of the metadata.- "description": "", + "description": "Description of the field",
Line range hint
911-959:
Add descriptions for schema fields.The
descriptionfields for the schema fields are empty. Adding descriptions will improve the usability of the metadata.- "description": "", + "description": "Description of the field",
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (17)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py (2 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (3 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py (2 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_config.py (1 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py (1 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (3 hunks)
- metadata-ingestion/tests/integration/lookml/expected_output.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_api_bigquery.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_api_hive2.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_offline.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/refinements_ingestion_golden.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/data.model.lkml (2 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/finance_notes.view.lkml (1 hunks)
- metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (3 hunks)
Files skipped from review due to trivial changes (1)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_config.py
Additional comments not posted (38)
metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/data.model.lkml (2)
8-8: Inclusion offinance_notes.view.lkmlis approved.The new
includestatement addsfinance_notes.view.lkml, enhancing the data model by integrating additional financial notes.
25-25: Addition ofexplore: latest_account_holder_notesis approved.The new
exploreblock expands the model's functionality, allowing users to access and analyze new data dimensions related to account holder notes.metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py (1)
28-30: Simplification ofrender_to_outputis approved, but verify the removal of error handling.The new implementation simplifies the method by removing error handling and dynamic output based on the filter value. Ensure that this change aligns with the intended functionality.
metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/finance_notes.view.lkml (2)
1-35: Definition oflatest_account_holder_notes_baseview is approved.The view is well-structured and provides necessary filters and dimensions for querying account holder notes.
37-109: Definition oflatest_account_holder_notesview is approved.The view is well-structured and provides a comprehensive SQL query for retrieving the latest account holder notes.
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (3)
123-139: Verify the consistency of new keys usage.Ensure that the new keys
datahub_transformed_sql_table_nameanddatahub_transformed_sqlare used consistently throughout the codebase.Verification successful
The new keys
datahub_transformed_sql_table_nameanddatahub_transformed_sqlare used consistently throughout the codebase.
view_upstream.pylookml_concept_context.pylooker_template_language.pyScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new keys `datahub_transformed_sql_table_name` and `datahub_transformed_sql`. # Test: Ensure the new keys are used consistently. rg --type python -A 5 $'datahub_transformed_sql_table_name|datahub_transformed_sql'Length of output: 115
Script:
#!/bin/bash # Description: Verify the usage of new keys `datahub_transformed_sql_table_name` and `datahub_transformed_sql`. # Test: Ensure the new keys are used consistently. rg --glob '*.py' -A 5 'datahub_transformed_sql_table_name|datahub_transformed_sql'Length of output: 7531
98-114: Ensure the regex patterns are correct.The regex patterns used to detect
SELECTandFROMclauses should be thoroughly tested to ensure they cover all possible cases. Additionally, the pattern used inre.subshould be verified for correctness.Verification successful
The regex patterns used in
_complete_in_complete_sqlare correct.The patterns for detecting
SELECTandFROMclauses and the substitution pattern forDERIVED_VIEW_PATTERNare appropriate and should function as intended.
re.search(r"SELECT\s", sql_query, flags=re.I)re.search(r"FROM\s", sql_query, flags=re.I)re.sub(DERIVED_VIEW_PATTERN, r"\1", sql_query)whereDERIVED_VIEW_PATTERNisr"\$\{([^}]*)\}"These patterns ensure that SQL fragments are correctly completed and cleaned.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the regex patterns used in `_complete_in_complete_sql`. # Test: Ensure the regex patterns cover all possible cases. rg --type python -A 5 $'_complete_in_complete_sql'Length of output: 80
Script:
#!/bin/bash # Description: Verify the regex patterns used in `_complete_in_complete_sql`. # Test: Ensure the regex patterns cover all possible cases. rg --type py -A 5 $'_complete_in_complete_sql'Length of output: 1163
Script:
#!/bin/bash # Description: Extract the implementation of `_complete_in_complete_sql` to review regex patterns. # Extract the function implementation ast-grep --lang python --pattern $'def _complete_in_complete_sql($_, $_) -> $_:\n $$$'Length of output: 2113
Script:
#!/bin/bash # Description: Search for the definition of DERIVED_VIEW_PATTERN in the codebase. # Search for the definition rg 'DERIVED_VIEW_PATTERN'Length of output: 706
123-139: Handle edge cases when transforming SQL.Ensure that the function handles edge cases, such as missing or malformed SQL strings, gracefully.
Verification successful
Edge cases handled for SQL transformation.
The
resolve_liquid_variablefunction includes exception handling for malformed SQL strings, and the_complete_in_complete_sqlfunction ensures SQL fragments are complete by adding missing clauses. These mechanisms should adequately handle edge cases involving missing or malformed SQL strings.
resolve_liquid_variablehandlesLiquidSyntaxErrorandCustomTagExceptionby logging warnings and returning the original text._complete_in_complete_sqladds missingSELECTandFROMclauses to SQL fragments.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function handles edge cases gracefully. # Test: Ensure the function handles missing or malformed SQL strings. rg --type python -A 5 $'resolve_liquid_variable_in_view_dict'Length of output: 91
Script:
#!/bin/bash # Description: Verify the function handles edge cases gracefully. # Test: Ensure the function handles missing or malformed SQL strings. rg --type py -A 5 $'resolve_liquid_variable_in_view_dict'Length of output: 2035
Script:
#!/bin/bash # Description: Extract the full implementation of the resolve_liquid_variable_in_view_dict function. ast-grep --lang python --pattern $'def resolve_liquid_variable_in_view_dict($_, $_):\n $$$'Length of output: 94
Script:
#!/bin/bash # Description: Extract the full implementation of the resolve_liquid_variable_in_view_dict function. rg --type py -A 50 $'def resolve_liquid_variable_in_view_dict'Length of output: 3399
Script:
#!/bin/bash # Description: Extract the implementations of resolve_liquid_variable and _complete_in_complete_sql functions. # Search for the resolve_liquid_variable function implementation rg --type py -A 50 $'def resolve_liquid_variable' # Search for the _complete_in_complete_sql function implementation rg --type py -A 50 $'def _complete_in_complete_sql'Length of output: 14571
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py (4)
309-315: Verify the impact of removing thetransformedparameter.Ensure that the removal of the
transformedparameter does not impact other parts of the codebase.Verification successful
The previous script failed due to an unrecognized file type. To address this, we need to correct the file type and rerun the script. The correct file type for Python in
rgispy.
Verified: The removal of the
transformedparameter does not impact other parts of the codebase.The
rgsearch results confirm that there are no references to thetransformedparameter in thesqlmethod across the codebase.
- The
sqlmethod in the provided snippet and other parts of the codebase does not include atransformedparameter.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing the `transformed` parameter. # Test: Ensure the removal of the `transformed` parameter does not impact other parts of the codebase. rg --type python -A 5 $'sql\(self\)'Length of output: 68
Script:
#!/bin/bash # Description: Verify the impact of removing the `transformed` parameter. # Test: Ensure the removal of the `transformed` parameter does not impact other parts of the codebase. rg --type py -A 5 $'sql\(self\)'Length of output: 2133
273-287: Verify the consistency of method usage.Ensure that the
datahub_transformed_sql_table_namemethod is used consistently throughout the codebase.
317-323: Verify the consistency of method usage.Ensure that the
datahub_transformed_sqlmethod is used consistently throughout the codebase.Verification successful
The
datahub_transformed_sqlmethod is used consistently.The method
datahub_transformed_sqlis utilized in multiple files across the codebase, confirming its consistent usage.
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.pymetadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.pyScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of `datahub_transformed_sql` method usage. # Test: Ensure the method is used consistently. rg --type python -A 5 $'datahub_transformed_sql'Length of output: 78
Script:
#!/bin/bash # Description: Verify the consistency of `datahub_transformed_sql` method usage. # Test: Ensure the method is used consistently. rg -A 5 'datahub_transformed_sql'Length of output: 7480
309-315: Handle edge cases when retrieving SQL.Ensure that the method handles edge cases, such as missing or malformed SQL strings, gracefully.
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (4)
262-262: Verify the correctness and consistency of the new method usage.Ensure that the
datahub_transformed_sqlmethod is used correctly and consistently.Verification successful
The
datahub_transformed_sqlmethod is used correctly and consistently.The
datahub_transformed_sqlmethod is integrated consistently across the codebase, ensuring its correctness in various contexts.
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.pymetadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.pymetadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.pyScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness and consistency of `datahub_transformed_sql` method usage. # Test: Ensure the method is used correctly and consistently. rg --type python -A 5 $'datahub_transformed_sql'Length of output: 78
Script:
#!/bin/bash # Description: Verify the correctness and consistency of `datahub_transformed_sql` method usage. # Test: Ensure the method is used correctly and consistently. rg --glob '*.py' -A 5 'datahub_transformed_sql'Length of output: 7494
481-483: Verify the correctness and consistency of the new method usage.Ensure that the
datahub_transformed_sql_table_namemethod is used correctly and consistently.Verification successful
The
datahub_transformed_sql_table_namemethod is used correctly and consistently.The method is defined and used appropriately across the codebase, ensuring it returns a valid table name.
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.pymetadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.pymetadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.pyScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness and consistency of `datahub_transformed_sql_table_name` method usage. # Test: Ensure the method is used correctly and consistently. rg --type python -A 5 $'datahub_transformed_sql_table_name'Length of output: 89
Script:
#!/bin/bash # Description: Verify the correctness and consistency of `datahub_transformed_sql_table_name` method usage. # Test: Ensure the method is used correctly and consistently. rg --type py -A 5 $'datahub_transformed_sql_table_name'Length of output: 4037
535-538: Verify the correctness and consistency of the new method usage.Ensure that the
datahub_transformed_sql_table_namemethod is used correctly and consistently.Verification successful
Verified the correctness and consistency of the new method usage.
The
datahub_transformed_sql_table_namemethod is used correctly and consistently across the codebase.
- Defined in
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py.- Used in
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py.- Used in
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness and consistency of `datahub_transformed_sql_table_name` method usage. # Test: Ensure the method is used correctly and consistently. rg --type python -A 5 $'datahub_transformed_sql_table_name'Length of output: 89
Script:
#!/bin/bash # Description: Verify the correctness and consistency of `datahub_transformed_sql_table_name` method usage. # Test: Ensure the method is used correctly and consistently. rg --type py -A 5 'datahub_transformed_sql_table_name'Length of output: 4037
535-538: Handle edge cases when retrieving transformed SQL table names.Ensure that the method handles edge cases, such as missing or malformed SQL table names, gracefully.
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py (1)
204-206: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
view_context.sqlmatch the new usage.Verification successful
Verification successful!
All function calls to
view_context.sqlmatch the new usage pattern.
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py:204Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `view_context.sql` match the new usage. # Test: Search for the function usage. Expect: Only occurances of the new usage. rg --type python -A 5 $'view_context.sql'Length of output: 71
Script:
#!/bin/bash # Description: Verify all function calls to `view_context.sql` match the new usage. # Test: Search for the function usage. Expect: Only occurrences of the new usage. rg --type py -A 5 $'view_context.sql'Length of output: 691
metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (5)
1303-1320: LGTM!The changes to the
latest_account_holder_notes_baseentity are approved.
1620-1635: LGTM!The changes to the
latest_account_holder_notesentity are approved.
Line range hint
305-320:
LGTM!The changes to the
employee_income_sourceentity are approved.
1707-1722: LGTM!The changes to the
employee_total_incomeentity are approved.
1655-1670: LGTM!The changes to the
employee_tax_reportentity are approved.metadata-ingestion/tests/integration/lookml/expected_output.json (1)
1635-1635: LGTM! The dynamic condition enhances flexibility.The SQL query modification to use a dynamic LookML condition for
order_regionimproves the query's adaptability, allowing it to filter based on different regions dynamically.metadata-ingestion/tests/integration/lookml/lookml_mces_api_hive2.json (1)
1635-1635: Dynamic SQL condition improves flexibility.The change from a static condition to a dynamic condition in the SQL query enhances the configurability and adaptability of the query. This allows the query to dynamically filter based on the
order_regionparameter.metadata-ingestion/tests/integration/lookml/lookml_mces_api_bigquery.json (1)
1635-1635: Dynamic SQL condition enhances flexibility.The modification to use LookML syntax
{% condition order_region %} order.region {% endcondition %}in theviewLogicfield allows for dynamic filtering based on theorder_region. This change improves the flexibility of the query by enabling it to adapt to different input parameters.metadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.json (5)
1679-1714: LGTM!The JSON structure for
UpstreamLineageis correct and provides detailed lineage information.
Line range hint
1458-1474:
LGTM!The JSON structure for
UpstreamLineageis correct and provides detailed lineage information.
Line range hint
1273-1289:
LGTM!The JSON structure for
UpstreamLineageis correct and provides detailed lineage information.
Line range hint
1082-1098:
LGTM!The JSON structure for
UpstreamLineageis correct and provides detailed lineage information.
Line range hint
893-909:
LGTM!The JSON structure for
UpstreamLineageis correct and provides detailed lineage information.metadata-ingestion/tests/integration/lookml/lookml_mces_offline.json (2)
1679-1714: LGTM! TheUpstreamLineagesection is well-structured and detailed.The
UpstreamLineagesection provides a clear lineage context for data processing, enhancing traceability of data sources.
1717-1766: LGTM! TheSchemaMetadatasection is comprehensive and well-defined.The
SchemaMetadatasection includes detailed attributes and field definitions, improving the clarity of the data model.metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json (2)
1716-1766: LGTM! Ensure the correctness of theSchemaMetadatastructure.The
SchemaMetadatastructure enhances the descriptive capabilities of the dataset and ensures better integration with data lineage tracking. Verify the correctness of the data types and structure.
1678-1714: LGTM! Ensure the correctness of theUpstreamLineagestructure.The
UpstreamLineagestructure enhances data lineage tracking by providing detailed lineage information, including audit timestamps, dataset URIs, and types. Verify the correctness of the data types and structure.Verification successful
The
UpstreamLineagestructure is correctly included and consistent with the schema definitions.The structure is present in the test file
metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.jsonand matches the definitions in the schema files.
metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the `UpstreamLineage` structure. # Test: Check for the presence of `UpstreamLineage` in the schema definition. rg --type json -A 5 $'"UpstreamLineage"'Length of output: 3656
Script:
#!/bin/bash # Description: Compare the `UpstreamLineage` structure in the test file with the definitions in the schema files. # Extract `UpstreamLineage` structure from the test file. test_structure=$(rg --type json -A 20 '"UpstreamLineage"' metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json) # Extract `UpstreamLineage` structure from the schema files. schema_files=$(fd --type f --name '*.json' metadata-service/restli-api/src/main/snapshot/) schema_structures=$(rg --type json -A 20 '"UpstreamLineage"' $schema_files) # Print the extracted structures for comparison. echo "Test File Structure:" echo "$test_structure" echo echo "Schema File Structures:" echo "$schema_structures"Length of output: 39020
Script:
#!/bin/bash # Description: Compare the `UpstreamLineage` structure in the test file with the definitions in the schema files. # Extract `UpstreamLineage` structure from the test file. test_structure=$(rg --type json -A 20 '"UpstreamLineage"' metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json) # Extract `UpstreamLineage` structure from the schema files. schema_files=$(fd . --type f -e json metadata-service/restli-api/src/main/snapshot/) schema_structures=$(rg --type json -A 20 '"UpstreamLineage"' $schema_files) # Print the extracted structures for comparison. echo "Test File Structure:" echo "$test_structure" echo echo "Schema File Structures:" echo "$schema_structures"Length of output: 40598
Script:
#!/bin/bash # Description: List lines around the expected location of the `UpstreamLineage` structure in the test file. # List lines around the expected location of the `UpstreamLineage` structure. rg --type json -A 20 -B 20 '"UpstreamLineage"' metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.jsonLength of output: 135
Script:
#!/bin/bash # Description: List the contents of the test file to manually verify the presence of the `UpstreamLineage` structure and other relevant elements. # List the contents of the test file. cat metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.jsonLength of output: 110561
metadata-ingestion/tests/integration/lookml/refinements_ingestion_golden.json (2)
1659-1659: The change enhances query flexibility.Replacing the hardcoded condition with a dynamic condition using templating syntax improves the adaptability of the query to different contexts or inputs.
1659-1659: Verify the correctness and usage of the templating syntax.Ensure that the templating syntax
{% condition order_region %} order.region {% endcondition %}is correctly implemented and used throughout the codebase.metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.json (2)
1686-1723: LGTM! Verify the correctness of the lineage data.The lineage data for the
customer_factsdataset appears to be well-formed and includes detailed information about upstream datasets and fields.However, ensure that the lineage data is correct and accurately represents the relationships between datasets and fields.
Verification successful
Verified: Lineage data for
customer_factsis correctly represented.The lineage data for the
customer_factsdataset includes detailed information about upstream datasets and fields, and the relationships are accurately represented.
- Files containing lineage data:
metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_api_bigquery.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_offline.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.jsonmetadata-ingestion/tests/integration/lookml/refinements_ingestion_golden.jsonmetadata-ingestion/tests/integration/lookml/expected_output.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_api_hive2.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the lineage data for `customer_facts`. # Test: Search for the lineage data. Expect: Correct relationships between datasets and fields. rg --type json -A 10 $'"urn:li:dataset:(urn:li:dataPlatform:looker,lkml_samples.view.customer_facts,PROD)"'Length of output: 108
Script:
#!/bin/bash # Description: Verify the correctness of the lineage data for `customer_facts`. # Test: Search for the lineage data. Expect: Correct relationships between datasets and fields. rg --type json -A 20 'customer_facts'Length of output: 135820
1724-1774: LGTM! Verify the correctness of the schema metadata.The schema metadata for the
customer_factsdataset appears to be well-formed and includes detailed information about fields and their properties.However, ensure that the schema metadata is correct and accurately represents the schema of the
customer_factsdataset.Verification successful
Schema Metadata Verification Successful
The schema metadata for the
customer_factsdataset is correct and accurately represents the schema. The fieldscustomer_idandlifetime_spendare consistently defined across different files with the expected properties and types.
metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.jsonmetadata-ingestion/tests/integration/lookml/expected_output.jsonmetadata-ingestion/tests/integration/lookml/refinements_ingestion_golden.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_api_hive2.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_offline.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_api_bigquery.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the schema metadata for `customer_facts`. # Test: Search for the schema metadata. Expect: Correct field properties and types. rg --type json -A 10 $'"schemaName": "customer_facts"'Length of output: 10641
Script:
#!/bin/bash # Description: Extract the full schema metadata for `customer_facts` and verify field properties and types. # Extract schema metadata for `customer_facts` from relevant JSON files rg --type json -A 50 $'"schemaName": "customer_facts"' metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.jsonLength of output: 2427
Script:
#!/bin/bash # Description: Search for the definition or documentation of the `customer_facts` schema to validate the correctness of the extracted schema metadata. # Search for `customer_facts` schema definition or documentation rg --type json -A 10 'customer_facts'Length of output: 90530
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (17)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py (2 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (3 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py (2 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_config.py (1 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py (1 hunks)
- metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (3 hunks)
- metadata-ingestion/tests/integration/lookml/expected_output.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_api_bigquery.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_api_hive2.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_offline.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/refinements_ingestion_golden.json (1 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/data.model.lkml (2 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/finance_notes.view.lkml (1 hunks)
- metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (3 hunks)
Files skipped from review due to trivial changes (1)
- metadata-ingestion/src/datahub/ingestion/source/looker/lookml_config.py
Additional comments not posted (73)
metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/data.model.lkml (2)
8-8: LGTM!The inclusion of
finance_notes.view.lkmlaligns with the objective of enhancing the data model.
Line range hint
25-27:
LGTM!The explore declaration for
latest_account_holder_notesaligns with the objective of enhancing the data model.metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py (1)
28-30: Verify the implications of the change.The method now writes a static string "1=1" to the output buffer, removing error handling and dynamic content generation. Ensure this change does not negatively impact the functionality.
Consider adding a comment to explain the rationale behind this change.
metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/finance_notes.view.lkml (2)
1-35: LGTM!The
latest_account_holder_notes_baseview is well-defined and aligns with the objective of enhancing the data model.
37-109: LGTM! Verify the SQL logic.The
latest_account_holder_notesview is well-defined and aligns with the objective of enhancing the data model. Ensure the SQL logic is correct and efficient.metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (2)
124-139: LGTM! But verify the use ofremove_extra_spaces_and_newlinesand_complete_in_complete_sql.The function updates the
viewdictionary with transformed SQL fields. The changes look correct.However, ensure that
remove_extra_spaces_and_newlinesis necessary and that_complete_in_complete_sqlis correctly handling the transformed SQL.Verification successful
LGTM! But verify the use of
remove_extra_spaces_and_newlinesand_complete_in_complete_sql.The function updates the
viewdictionary with transformed SQL fields. The changes look correct.The use of
remove_extra_spaces_and_newlinesis necessary to ensure that extra spaces and newlines are removed from thesql_table_name, preventing issues in URNs. The function_complete_in_complete_sqlis correctly handling the transformed SQL by ensuring that necessary SQL clauses are present.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `remove_extra_spaces_and_newlines` and `_complete_in_complete_sql`. # Test: Search for the usage of `resolve_liquid_variable_in_view_dict` and check the context. rg --type python -A 5 $'resolve_liquid_variable_in_view_dict'Length of output: 91
Script:
#!/bin/bash # Search for the definition and usage of `remove_extra_spaces_and_newlines` in the codebase. rg 'def remove_extra_spaces_and_newlines' -A 10 rg 'remove_extra_spaces_and_newlines' -A 5 # Search for the definition and usage of `_complete_in_complete_sql` in the codebase. rg 'def _complete_in_complete_sql' -A 10 rg '_complete_in_complete_sql' -A 5Length of output: 6017
98-114: LGTM! But verify the regex patterns andraw_view['name'].The function ensures SQL completeness by adding missing
SELECTandFROMclauses. The regex patterns and the use ofraw_view['name']look correct.However, ensure that the regex patterns match all possible variations of
SELECTandFROMclauses and thatraw_view['name']is always available and correctly formatted.metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py (5)
273-287: LGTM! But verify the use ofraw_view['datahub_transformed_sql_table_name']andsql_table_name.The function retrieves the
datahub_transformed_sql_table_namefromraw_viewand, if not present, falls back to invoking the existingsql_table_namemethod. The changes look correct.However, ensure that
raw_view['datahub_transformed_sql_table_name']is always available and correctly formatted, and that the call tosql_table_nameis necessary.Verification successful
LGTM! But verify the use of
raw_view['datahub_transformed_sql_table_name']andsql_table_name.The function retrieves the
datahub_transformed_sql_table_namefromraw_viewand, if not present, falls back to invoking the existingsql_table_namemethod. The changes look correct.However, ensure that
raw_view['datahub_transformed_sql_table_name']is always available and correctly formatted, and that the call tosql_table_nameis necessary.
- The
datahub_transformed_sql_table_namemethod is correctly implemented.- The
sql_table_namemethod is correctly called ifdatahub_transformed_sql_table_nameis not found.- Both methods handle the necessary transformations and cleanups.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `raw_view['datahub_transformed_sql_table_name']` and `sql_table_name`. # Test: Search for the usage of `datahub_transformed_sql_table_name` and check the context. rg --type python -A 5 $'datahub_transformed_sql_table_name'Length of output: 89
Script:
#!/bin/bash # Description: Verify the use of `raw_view['datahub_transformed_sql_table_name']` and `sql_table_name`. # Test: Search for the usage of `raw_view['datahub_transformed_sql_table_name']` and check the context. rg --type py -A 5 $'raw_view\\[\'datahub_transformed_sql_table_name\'\\]' # Test: Search for the usage of `sql_table_name` and check the context. rg --type py -A 5 $'sql_table_name'Length of output: 31506
Line range hint
481-483:
LGTM! But verify the use ofdatahub_transformed_sql_table_name.The function has been updated to use
datahub_transformed_sql_table_name. The changes look correct.However, ensure that
datahub_transformed_sql_table_nameis always available and correctly formatted.Verification successful
LGTM! The function
_get_upstream_dataset_urnis correctly usingdatahub_transformed_sql_table_name.The changes look correct and the usage of
datahub_transformed_sql_table_nameis appropriate.
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py: Verified the usage of_get_upstream_dataset_urn.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `datahub_transformed_sql_table_name`. # Test: Search for the usage of `_get_upstream_dataset_urn` and check the context. rg --type python -A 5 $'_get_upstream_dataset_urn'Length of output: 80
Script:
#!/bin/bash # Description: Verify the use of `datahub_transformed_sql_table_name`. # Test: Search for the usage of `_get_upstream_dataset_urn` and check the context. rg --type py -A 5 '_get_upstream_dataset_urn'Length of output: 12345
317-323: LGTM! But verify the use ofraw_view['datahub_transformed_sql'].The function returns the
datahub_transformed_sqlfrom the derived table. The changes look correct.However, ensure that
raw_view['datahub_transformed_sql']is always available and correctly formatted.Verification successful
LGTM! The use of
raw_view['datahub_transformed_sql']is verified.The
datahub_transformed_sqlis correctly accessed from the derived table and is used appropriately in the codebase.
looker_template_language.py: Ensuresdatahub_transformed_sqlis set in the derived table.view_upstream.py: Utilizesdatahub_transformed_sqlin various contexts.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `raw_view['datahub_transformed_sql']`. # Test: Search for the usage of `datahub_transformed_sql` and check the context. rg --type python -A 5 $'datahub_transformed_sql'Length of output: 78
Script:
#!/bin/bash # Description: Verify the use of `raw_view['datahub_transformed_sql']`. # Test: Search for the usage of `datahub_transformed_sql` and check the context. rg --glob '*.py' -A 5 'datahub_transformed_sql'Length of output: 7494
309-315: LGTM! But verify the removal of thetransformedparameter.The function has been simplified by removing the
transformedparameter. The method now directly returns the SQL query from the derived table. The changes look correct.However, ensure that the removal of the
transformedparameter does not impact other parts of the codebase.Verification successful
Verified: The removal of the
transformedparameter from thesqlfunction does not impact other parts of the codebase.The
sqlfunction is used correctly without thetransformedparameter, and the termtransformedis present in different contexts unrelated to thesqlfunction.
- No issues found with the removal of the
transformedparameter.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of the `transformed` parameter. # Test: Search for the usage of `sql` and check the context. rg --type python -A 5 $'sql'Length of output: 58
Script:
#!/bin/bash # Description: Verify the removal of the `transformed` parameter. # Test: Search for the definition of the `sql` function and its usage in the codebase. rg 'def sql' -A 5 rg 'sql(' -A 5Length of output: 7108
Script:
#!/bin/bash # Description: Verify the removal of the `transformed` parameter. # Test: Search for the usage of the `sql` function in the lookml_concept_context.py file. rg 'sql(' metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py -A 5Length of output: 156
Script:
#!/bin/bash # Description: Verify the removal of the `transformed` parameter. # Test: Search for the usage of the `sql` function and the term `transformed` in the lookml_concept_context.py file. rg 'sql\(' metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py -A 5 rg 'transformed' metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.py -A 5Length of output: 1849
269-271: LGTM! But verify the use ofraw_view[NAME].The function ensures that if the
sql_table_namefield is not set, it directly assigns the lowercasedraw_view[NAME]tosql_table_name. The changes look correct.However, ensure that
raw_view[NAME]is always available and correctly formatted.Verification successful
LGTM! The usage of
raw_view[NAME]is valid and consistent.The
self.raw_viewis properly initialized, andNAMEis used correctly as a key to access elements withinself.raw_view. The changes look correct.
- The
self.raw_viewis initialized with theraw_viewparameter.- The
NAMEconstant is used consistently to access elements withinself.raw_view.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `raw_view[NAME]`. # Test: Search for the usage of `sql_table_name` and check the context. rg --type python -A 5 $'sql_table_name'Length of output: 69
Script:
#!/bin/bash # Description: Verify the use of `raw_view[NAME]`. # Test: Search for the usage of `sql_table_name` and check the context. rg --type py -A 5 $'sql_table_name'Length of output: 31429
Script:
#!/bin/bash # Description: Verify the initialization and usage of `self.raw_view` and `NAME`. # Test: Search for the initialization of `self.raw_view` and usage of `NAME` in `lookml_concept_context.py`. rg --type py 'self.raw_view' -A 5 rg --type py 'NAME' -A 5Length of output: 335557
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (2)
481-483: LGTM! But verify the use ofdatahub_transformed_sql_table_name.The function has been updated to use
datahub_transformed_sql_table_name. The changes look correct.However, ensure that
datahub_transformed_sql_table_nameis always available and correctly formatted.Verification successful
LGTM! But verify the use of
datahub_transformed_sql_table_name.The function has been updated to use
datahub_transformed_sql_table_name. The changes look correct.However, ensure that
datahub_transformed_sql_table_nameis always available and correctly formatted.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `datahub_transformed_sql_table_name`. # Test: Search for the usage of `_get_upstream_dataset_urn` and check the context. rg --type python -A 5 $'_get_upstream_dataset_urn'Length of output: 80
Script:
#!/bin/bash # Description: Verify the use of `_get_upstream_dataset_urn` and `datahub_transformed_sql_table_name`. # Test 1: Search for the usage of `_get_upstream_dataset_urn` and check the context. rg --type py -A 5 '_get_upstream_dataset_urn' # Test 2: Search for the definition and usage of `datahub_transformed_sql_table_name`. rg --type py 'datahub_transformed_sql_table_name'Length of output: 13477
262-262: LGTM! But verify the use ofdatahub_transformed_sql.The function has been updated to use
datahub_transformed_sql. The changes look correct.However, ensure that
datahub_transformed_sqlis always available and correctly formatted.Verification successful
The
datahub_transformed_sqlmethod is correctly defined and returns the expected SQL string from thederived_table.The method is implemented as follows:
- It retrieves the
derived_tableand returns the value associated with the"datahub_transformed_sql"key.- This method is used in the
view_upstream.pyfile as expected.The changes look correct and the method is properly implemented and used.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `datahub_transformed_sql`. # Test: Search for the usage of `__get_spr` and check the context. rg --type python -A 5 $'__get_spr'Length of output: 64
Script:
#!/bin/bash # Description: Verify the use of `datahub_transformed_sql`. # Test: Search for the usage of `__get_spr` and check the context. rg --type py -A 5 $'__get_spr' # Test: Search for the definition and usage of `datahub_transformed_sql`. rg --type py $'datahub_transformed_sql'Length of output: 3203
Script:
#!/bin/bash # Description: Verify the definition of `datahub_transformed_sql`. # Test: Search for the definition of `datahub_transformed_sql` method. rg --type py -A 10 $'def datahub_transformed_sql' metadata-ingestion/src/datahub/ingestion/source/looker/lookml_concept_context.pyLength of output: 858
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py (1)
204-204: Ensure the change in SQL handling logic is intentional.The call to
view_context.sql()without thetransformedargument might change the SQL logic being processed. Verify that this change is intentional and does not affect the expected behavior.metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (39)
1303-1320: New aspect added:subTypes.The
subTypesaspect has been added to the dataset. Ensure that the type names are correct and relevant.
1321-1338: New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
1339-1354: New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
1355-1593: New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
1594-1617: New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
1620-1635: New aspect added:subTypes.The
subTypesaspect has been added to the dataset. Ensure that the type names are correct and relevant.
1636-1653: New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
1654-1669: New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
1670-1705: New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
1706-1729: New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
Line range hint
305-320:
New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
Line range hint
321-336:
New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
Line range hint
337-370:
New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
Line range hint
371-394:
New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
Line range hint
395-410:
New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
Line range hint
411-426:
New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
Line range hint
427-460:
New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
Line range hint
461-484:
New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
Line range hint
485-500:
New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
Line range hint
501-516:
New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
Line range hint
517-550:
New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
Line range hint
551-574:
New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
Line range hint
575-590:
New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
Line range hint
591-606:
New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
Line range hint
607-640:
New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
Line range hint
641-664:
New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
1303-1320: New aspect added:subTypes.The
subTypesaspect has been added to the dataset. Ensure that the type names are correct and relevant.
1321-1338: New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
1339-1354: New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
1355-1593: New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
1594-1617: New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
1620-1635: New aspect added:subTypes.The
subTypesaspect has been added to the dataset. Ensure that the type names are correct and relevant.
1636-1653: New aspect added:viewProperties.The
viewPropertiesaspect includes detailed SQL logic for the dataset. Ensure that the SQL logic is correct and optimized for performance.
1654-1669: New aspect added:container.The
containeraspect specifies the container for the dataset. Ensure that the container URN is correct and relevant.
1670-1705: New aspect added:UpstreamLineage.The
UpstreamLineageaspect includes upstream datasets and fine-grained lineages. Ensure that the lineage information is accurate and complete.
1706-1729: New aspect added:browsePathsV2.The
browsePathsV2aspect includes browse paths for the dataset. Ensure that the browse paths are correct and relevant.
Line range hint
1729-1736:
New aspect added:tagKeyforDimension.The
tagKeyaspect has been added to the tag. Ensure that the tag name is correct and relevant.
Line range hint
1737-1744:
New aspect added:tagKeyforMeasure.The
tagKeyaspect has been added to the tag. Ensure that the tag name is correct and relevant.
Line range hint
1745-1752:
New aspect added:tagKeyforTemporal.The
tagKeyaspect has been added to the tag. Ensure that the tag name is correct and relevant.metadata-ingestion/tests/integration/lookml/expected_output.json (1)
1635-1635: Verify the correctness of the dynamic condition in the SQL query.The static condition
order.region = 'ap-south-1'has been replaced with a dynamic condition using LookML's templating language:{% condition order_region %} order.region {% endcondition %}. Ensure that this dynamic condition is correctly implemented and enhances the query's adaptability.metadata-ingestion/tests/integration/lookml/lookml_mces_api_hive2.json (1)
1635-1635: Confirm the correctness of the new dynamic filtering mechanism.The new templated approach
{% condition order_region %} order.region {% endcondition %}enhances the flexibility of the query by allowing the region to be specified at runtime. Ensure that the templating syntax is correctly supported and tested in the LookML environment.metadata-ingestion/tests/integration/lookml/lookml_mces_api_bigquery.json (1)
1635-1635: LGTM!The use of LookML templating syntax for the
order_regioncondition enhances the flexibility and maintainability of the query.metadata-ingestion/tests/integration/lookml/lookml_mces_badsql_parser.json (2)
1678-1714: LGTM!The
UpstreamLineagesegment is well-structured and includes detailed information about upstream datasets and their relationships. The fine-grained lineage information is comprehensive and correctly formatted.
1717-1766: LGTM!The
SchemaMetadatasegment is well-structured and includes comprehensive details about thecustomer_factsschema. The fields are correctly defined with appropriate attributes such as nullability, descriptions, and data types.metadata-ingestion/tests/integration/lookml/lookml_mces_offline.json (2)
1679-1714: Verify the correctness and completeness of theUpstreamLineageentry.Ensure that the
UpstreamLineageentry correctly represents the relationships between upstream and downstream datasets and fields. Verify that the audit stamp, upstream datasets, and fine-grained lineages are accurate and complete.
1717-1766: Verify the correctness and completeness of theSchemaMetadataentry.Ensure that the
SchemaMetadataentry correctly represents the schema namedcustomer_facts. Verify that the platform, version, timestamps, hash, fields, and primary keys are accurate and complete.metadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json (6)
1717-1765: Ensure correct and completeSchemaMetadatadefinitions.The
SchemaMetadataaspect is comprehensive, but ensure that all field paths, types, and descriptions are correctly defined and consistent across datasets.
1766-1768: Ensure correctDatasetPropertiesdefinitions.The
DatasetPropertiesaspect is well-defined, but ensure that all custom properties and dataset names are correctly defined and consistent across datasets.
Line range hint
1769-1771:
Ensure correctBrowsePathsV2definitions.The
BrowsePathsV2aspect is well-defined, but ensure that all browse paths are correctly defined and consistent across datasets.
1679-1713: Ensure consistency inUpstreamLineagedefinitions.The
UpstreamLineageaspect is well-defined, but ensure that all upstream and downstream fields are correctly referenced and consistent across datasets.Verification successful
Ensure consistency in
UpstreamLineagedefinitions.The
UpstreamLineageaspect is consistently defined across datasets with accurate references. No issues were found in the structure or field definitions.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistency in UpstreamLineage definitions across datasets. # Test: Search for UpstreamLineage aspect. Expect: Consistent references across datasets. rg --type json -A 10 '"com.linkedin.pegasus2avro.dataset.UpstreamLineage"'Length of output: 456783
Line range hint
1775-1777:
Ensure correctTagPropertiesdefinitions.The
TagPropertiesaspect is well-defined, but ensure that all tag properties are correctly defined and consistent across tags.Verification successful
TagProperties definitions are correct and consistent across tags.
The
TagPropertiesaspect is consistently defined in multiple files, and the definitions are correct.
- Examples of consistent definitions:
"name": "Dimension", "description": "A tag that is applied to all dimension fields.""name": "Temporal", "description": "A tag that is applied to all time-based (temporal) fields such as timestamps or durations.""name": "Measure", "description": "A tag that is applied to all measures (metrics). Measures are typically the columns that you aggregate on"Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify correctness of TagProperties definitions across tags. # Test: Search for TagProperties aspect. Expect: Correct definitions across tags. rg --type json -A 5 '"com.linkedin.pegasus2avro.tag.TagProperties"'Length of output: 48591
Line range hint
1772-1774:
Ensure correctStatusdefinitions.The
Statusaspect is well-defined, but ensure that all removal statuses are correctly defined and consistent across datasets and tags.Verification successful
Verification Successful: Correct
StatusdefinitionsThe
Statusaspect is consistently defined across datasets and tags, with all instances of theremovedfield set tofalse.
- Files Checked:
smoke-test/tests/cypress/cypress_dbt_data.jsonmetadata-ingestion/tests/unit/glue/glue_mces_golden_table_lineage.jsonmetadata-ingestion/tests/integration/trino/trino_hive_instance_mces_golden.jsonmetadata-ingestion/tests/integration/lookml/lookml_mces_offline_platform_instance.json- And many more as listed in the output.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify correctness of Status definitions across datasets and tags. # Test: Search for Status aspect. Expect: Correct definitions across datasets and tags. rg --type json -A 5 '"com.linkedin.pegasus2avro.common.Status"'Length of output: 436706
metadata-ingestion/tests/integration/lookml/refinements_ingestion_golden.json (1)
1659-1659: LGTM! The use of a templated condition enhances flexibility.The change from a hardcoded filter to a templated condition for
order.regionimproves the adaptability and maintainability of the SQL query.metadata-ingestion/tests/integration/lookml/lookml_mces_with_external_urls.json (5)
1686-1696: Ensure completeness ofUpstreamLineageattributes.The
UpstreamLineagestructure includesauditStamp,dataset, andtype. Verify that all necessary attributes are included and correctly populated.
1698-1721: CheckfineGrainedLineagesfor accuracy and completeness.The
fineGrainedLineagesattribute withinUpstreamLineageincludes detailed lineage mappings. Ensure that all mappings are accurate and complete.
1725-1736: Ensure completeness ofSchemaMetadataattributes.The
SchemaMetadatastructure includesschemaName,platform,version,created, andlastModified. Verify that all necessary attributes are included and correctly populated.
1743-1771: Checkfieldsattribute for accuracy and completeness.The
fieldsattribute withinSchemaMetadataincludes field definitions. Ensure that all fields are accurately defined and all necessary attributes are included.
1773-1774: VerifyprimaryKeysattribute.The
primaryKeysattribute withinSchemaMetadatashould list all primary keys. Ensure that it is correctly populated.
…/datahub-fork into cus2240-lookml-ingestion-fails
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py (2 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/finance_notes.view.lkml (1 hunks)
- metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/finance_notes.view.lkml
Additional comments not posted (18)
metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py (2)
30-30: LGTM!The code changes are approved.
28-30: Verify the impact of removing dynamic content generation and error handling.The method now writes a static string "dummy_value" to the output buffer, which simplifies the rendering process but alters the expected behavior when using the Looker condition tag. Ensure that this change does not negatively impact other parts of the codebase that rely on dynamic content generation and error handling.
Verification successful
Verify the impact of removing dynamic content generation and error handling.
The
ConditionNodeclass and itsrender_to_outputmethod are only defined and used withinmetadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.py. There are no other references to these entities in the codebase, indicating that the changes are isolated and do not negatively impact other parts of the codebase.
metadata-ingestion/src/datahub/ingestion/source/looker/looker_liquid_tag.pyScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing dynamic content generation and error handling. # Test: Search for the usage of the `ConditionNode` class and its `render_to_output` method. Expect: No negative impact on the codebase. rg --type python -A 5 $'ConditionNode'Length of output: 68
Script:
#!/bin/bash # Description: Verify the impact of removing dynamic content generation and error handling. # Test: Search for the usage of the `ConditionNode` class and its `render_to_output` method. Expect: No negative impact on the codebase. rg 'class ConditionNode' --glob '*.py' -A 10 rg 'def render_to_output' --glob '*.py' -A 10Length of output: 2597
Script:
#!/bin/bash # Description: Verify the impact of removing dynamic content generation and error handling. # Test: Search for the usage of the `ConditionNode` class and its `render_to_output` method throughout the entire codebase. rg 'ConditionNode' -A 5 rg 'render_to_output' -A 5Length of output: 2100
metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (16)
305-305: LGTM!The code changes are approved.
1644-1644: LGTM!The code changes are approved.
1303-1320: LGTM!The code changes are approved.
1321-1338: LGTM!The code changes are approved.
1339-1354: LGTM!The code changes are approved.
1594-1617: LGTM!The code changes are approved.
305-305: LGTM!The code changes are approved.
1762-1776: LGTM!The code changes are approved.
1303-1320: Verify the correctness of the new aspectsubTypes.The new aspect
subTypesenhances metadata management. Ensure that the aspect is correctly defined and behaves as expected.
1339-1354: Verify the correctness of the new aspectcontainer.The new aspect
containerenhances metadata management. Ensure that the aspect is correctly defined and behaves as expected.
1594-1617: Verify the correctness of the new aspectbrowsePathsV2.The new aspect
browsePathsV2enhances metadata management. Ensure that the aspect is correctly defined and behaves as expected.
1644-1644: Verify the correctness of the new SQL logic.The new SQL logic enhances data querying capabilities. Ensure that the SQL syntax is correct and that the logic behaves as expected.
305-305: Verify the correctness of the conditional SQL logic.The new logic introduces conditional SQL for dynamic data source selection. Ensure that the conditions and SQL syntax are correct and that the logic behaves as expected.
1762-1776: Verify the correctness of the new aspecttagKey.The new aspect
tagKeyenhances metadata management. Ensure that the aspect is correctly defined and behaves as expected.
305-305: Verify the correctness of the new SQL logic.The new SQL logic enhances data querying capabilities. Ensure that the SQL syntax is correct and that the logic behaves as expected.
1321-1338: Verify the correctness of the new view logic.The new view logic enhances data querying capabilities. Ensure that the SQL syntax is correct and that the logic behaves as expected.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (16 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/data.model.lkml (2 hunks)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/employee_salary_rating.view.lkml (1 hunks)
- metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/data.model.lkml
Additional comments not posted (36)
metadata-ingestion/tests/integration/lookml/vv-lineage-and-liquid-templates/employee_salary_rating.view.lkml (7)
1-2: Define view and derived table correctly.The view
employee_salary_ratingand its derived table are defined correctly.
3-20: Ensure SQL logic is correct and readable.The SQL logic uses conditional statements to select the appropriate data source based on filters. This approach enhances flexibility but ensure the conditions and SQL syntax are correct and readable.
23-28: Filter definition is correct.The filter
rating_windowis defined correctly with appropriate metadata.
30-33: Dimensioniddefinition is correct.The dimension
idis defined correctly with appropriate SQL logic.
35-38: Dimensionnamedefinition is correct.The dimension
nameis defined correctly with appropriate SQL logic.
40-43: Dimensionsourcedefinition is correct.The dimension
sourceis defined correctly with appropriate SQL logic.
45-48: Dimensionincomedefinition is correct.The dimension
incomeis defined correctly with appropriate SQL logic.metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py (12)
209-223: Includereporterparameter in constructor.The
reporterparameter is correctly included in the constructor to enhance error reporting.
250-253: Includereporterparameter in constructor.The
reporterparameter is correctly included in the constructor to enhance error reporting.
266-274: Use transformed SQL in__get_sprmethod.The method correctly uses
datahub_transformed_sqlto handle SQL transformations.
282-289: Report warning for table-level lineage errors.The method correctly reports warnings for table-level lineage errors using the
reporter.
311-319: Report warning for column-level lineage errors.The method correctly reports warnings for column-level lineage errors using the
reporter.
350-358: Report warning for column-level lineage errors.The method correctly reports warnings for column-level lineage errors using the
reporter.
407-411: Includereporterparameter in constructor.The
reporterparameter is correctly included in the constructor to enhance error reporting.
492-495: Includereporterparameter in constructor.The
reporterparameter is correctly included in the constructor to enhance error reporting.
504-507: Use transformed SQL table name in__get_upstream_dataset_urnmethod.The method correctly uses
datahub_transformed_sql_table_nameto handle SQL transformations.
548-551: Includereporterparameter in constructor.The
reporterparameter is correctly included in the constructor to enhance error reporting.
Line range hint
559-566: Use transformed SQL table name in__get_upstream_dataset_urnmethod.The method correctly uses
datahub_transformed_sql_table_nameto handle SQL transformations.
Line range hint
618-662: Includereporterparameter increate_view_upstreamfunction.The
reporterparameter is correctly included in the function calls to enhance error reporting.metadata-ingestion/tests/integration/lookml/vv_lineage_liquid_template_golden.json (17)
Line range hint
1-20: Container properties are defined correctly.The container properties are defined with appropriate metadata.
1303-1320: DefinesubTypesaspect foremployee_salary_rating.The
subTypesaspect is defined correctly for the dataset.
1323-1338: DefineviewPropertiesaspect foremployee_salary_rating.The
viewPropertiesaspect is defined correctly with appropriate SQL logic and metadata.
1341-1354: Definecontaineraspect foremployee_salary_rating.The
containeraspect is defined correctly for the dataset.
1560-1582: DefinebrowsePathsV2aspect foremployee_salary_rating.The
browsePathsV2aspect is defined correctly with appropriate metadata.
Line range hint
305-320: DefinesubTypesaspect foremployee_income_source.The
subTypesaspect is defined correctly for the dataset.
Line range hint
323-338: DefineviewPropertiesaspect foremployee_income_source.The
viewPropertiesaspect is defined correctly with appropriate SQL logic and metadata.
Line range hint
341-354: Definecontaineraspect foremployee_income_source.The
containeraspect is defined correctly for the dataset.
Line range hint
560-582: DefinebrowsePathsV2aspect foremployee_income_source.The
browsePathsV2aspect is defined correctly with appropriate metadata.
Line range hint
823-838: DefinesubTypesaspect foremployee_total_income.The
subTypesaspect is defined correctly for the dataset.
Line range hint
841-856: DefineviewPropertiesaspect foremployee_total_income.The
viewPropertiesaspect is defined correctly with appropriate SQL logic and metadata.
Line range hint
859-872: Definecontaineraspect foremployee_total_income.The
containeraspect is defined correctly for the dataset.
Line range hint
1078-1100: DefinebrowsePathsV2aspect foremployee_total_income.The
browsePathsV2aspect is defined correctly with appropriate metadata.
Line range hint
1281-1296: DefinesubTypesaspect foremployee_tax_report.The
subTypesaspect is defined correctly for the dataset.
Line range hint
1299-1314: DefineviewPropertiesaspect foremployee_tax_report.The
viewPropertiesaspect is defined correctly with appropriate SQL logic and metadata.
1317-1330: Definecontaineraspect foremployee_tax_report.The
containeraspect is defined correctly for the dataset.
1519-1541: DefinebrowsePathsV2aspect foremployee_tax_report.The
browsePathsV2aspect is defined correctly with appropriate metadata.
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py
Outdated
Show resolved
Hide resolved
…template_language.py Co-authored-by: Harshal Sheth <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (2)
98-114: Ensure correct function name in the docstring.The function name in the docstring should match the actual function name.
- def _complete_incomplete_sql(raw_view: dict, sql: str) -> str: + def _complete_incomplete_sql(raw_view: dict, sql: str) -> str:
Line range hint
115-139:
Fix the function call typo.The function
_complete_incomplete_sqlis called with a typo.- _complete_in_complete_sql( + _complete_incomplete_sql(Tools
Ruff
138-138: Undefined name
_complete_in_complete_sql(F821)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (3 hunks)
Additional context used
Ruff
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py
138-138: Undefined name
_complete_in_complete_sql(F821)
Additional comments not posted (1)
metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (1)
98-114: Ensure proper handling of SQL fragments.The function
_complete_incomplete_sqlcorrectly handles SQL fragments by adding missingSELECTandFROMclauses. The regex patternDERIVED_VIEW_PATTERNis used to clean up the SQL.
hsheth2
left a comment
hsheth2
left a comment
There was a problem hiding this comment.
Needs a minor tweak, to exception reporting
Once that's done, we can merge this
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/view_upstream.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py
* feat(forms) Handle deleting forms references when hard deleting forms (datahub-project#10820) * refactor(ui): Misc improvements to the setup ingestion flow (ingest uplift 1/2) (datahub-project#10764) Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> * fix(ingestion/airflow-plugin): pipeline tasks discoverable in search (datahub-project#10819) * feat(ingest/transformer): tags to terms transformer (datahub-project#10758) Co-authored-by: Aseem Bansal <[email protected]> * fix(ingestion/unity-catalog): fixed issue with profiling with GE turned on (datahub-project#10752) Co-authored-by: Aseem Bansal <[email protected]> * feat(forms) Add java SDK for form entity PATCH + CRUD examples (datahub-project#10822) * feat(SDK) Add java SDK for structuredProperty entity PATCH + CRUD examples (datahub-project#10823) * feat(SDK) Add StructuredPropertyPatchBuilder in python sdk and provide sample CRUD files (datahub-project#10824) * feat(forms) Add CRUD endpoints to GraphQL for Form entities (datahub-project#10825) * add flag for includeSoftDeleted in scroll entities API (datahub-project#10831) * feat(deprecation) Return actor entity with deprecation aspect (datahub-project#10832) * feat(structuredProperties) Add CRUD graphql APIs for structured property entities (datahub-project#10826) * add scroll parameters to openapi v3 spec (datahub-project#10833) * fix(ingest): correct profile_day_of_week implementation (datahub-project#10818) * feat(ingest/glue): allow ingestion of empty databases from Glue (datahub-project#10666) Co-authored-by: Harshal Sheth <[email protected]> * feat(cli): add more details to get cli (datahub-project#10815) * fix(ingestion/glue): ensure date formatting works on all platforms for aws glue (datahub-project#10836) * fix(ingestion): fix datajob patcher (datahub-project#10827) * fix(smoke-test): add suffix in temp file creation (datahub-project#10841) * feat(ingest/glue): add helper method to permit user or group ownership (datahub-project#10784) * feat(): Show data platform instances in policy modal if they are set on the policy (datahub-project#10645) Co-authored-by: Hendrik Richert <[email protected]> * docs(patch): add patch documentation for how implementation works (datahub-project#10010) Co-authored-by: John Joyce <[email protected]> * fix(jar): add missing custom-plugin-jar task (datahub-project#10847) * fix(): also check exceptions/stack trace when filtering log messages (datahub-project#10391) Co-authored-by: John Joyce <[email protected]> * docs(): Update posts.md (datahub-project#9893) Co-authored-by: Hyejin Yoon <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore(ingest): update acryl-datahub-classify version (datahub-project#10844) * refactor(ingest): Refactor structured logging to support infos, warnings, and failures structured reporting to UI (datahub-project#10828) Co-authored-by: John Joyce <[email protected]> Co-authored-by: Harshal Sheth <[email protected]> * fix(restli): log aspect-not-found as a warning rather than as an error (datahub-project#10834) * fix(ingest/nifi): remove duplicate upstream jobs (datahub-project#10849) * fix(smoke-test): test access to create/revoke personal access tokens (datahub-project#10848) * fix(smoke-test): missing test for move domain (datahub-project#10837) * ci: update usernames to not considered for community (datahub-project#10851) * env: change defaults for data contract visibility (datahub-project#10854) * fix(ingest/tableau): quote special characters in external URL (datahub-project#10842) * fix(smoke-test): fix flakiness of auto complete test * ci(ingest): pin dask dependency for feast (datahub-project#10865) * fix(ingestion/lookml): liquid template resolution and view-to-view cll (datahub-project#10542) * feat(ingest/audit): add client id and version in system metadata props (datahub-project#10829) * chore(ingest): Mypy 1.10.1 pin (datahub-project#10867) * docs: use acryl-datahub-actions as expected python package to install (datahub-project#10852) * docs: add new js snippet (datahub-project#10846) * refactor(ingestion): remove company domain for security reason (datahub-project#10839) * fix(ingestion/spark): Platform instance and column level lineage fix (datahub-project#10843) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingestion/tableau): optionally ingest multiple sites and create site containers (datahub-project#10498) Co-authored-by: Yanik Häni <[email protected]> * fix(ingestion/looker): Add sqlglot dependency and remove unused sqlparser (datahub-project#10874) * fix(manage-tokens): fix manage access token policy (datahub-project#10853) * Batch get entity endpoints (datahub-project#10880) * feat(system): support conditional write semantics (datahub-project#10868) * fix(build): upgrade vercel builds to Node 20.x (datahub-project#10890) * feat(ingest/lookml): shallow clone repos (datahub-project#10888) * fix(ingest/looker): add missing dependency (datahub-project#10876) * fix(ingest): only populate audit stamps where accurate (datahub-project#10604) * fix(ingest/dbt): always encode tag urns (datahub-project#10799) * fix(ingest/redshift): handle multiline alter table commands (datahub-project#10727) * fix(ingestion/looker): column name missing in explore (datahub-project#10892) * fix(lineage) Fix lineage source/dest filtering with explored per hop limit (datahub-project#10879) * feat(conditional-writes): misc updates and fixes (datahub-project#10901) * feat(ci): update outdated action (datahub-project#10899) * feat(rest-emitter): adding async flag to rest emitter (datahub-project#10902) Co-authored-by: Gabe Lyons <[email protected]> * feat(ingest): add snowflake-queries source (datahub-project#10835) * fix(ingest): improve `auto_materialize_referenced_tags_terms` error handling (datahub-project#10906) * docs: add new company to adoption list (datahub-project#10909) * refactor(redshift): Improve redshift error handling with new structured reporting system (datahub-project#10870) Co-authored-by: John Joyce <[email protected]> Co-authored-by: Harshal Sheth <[email protected]> * feat(ui) Finalize support for all entity types on forms (datahub-project#10915) * Index ExecutionRequestResults status field (datahub-project#10811) * feat(ingest): grafana connector (datahub-project#10891) Co-authored-by: Shirshanka Das <[email protected]> Co-authored-by: Harshal Sheth <[email protected]> * fix(gms) Add Form entity type to EntityTypeMapper (datahub-project#10916) * feat(dataset): add support for external url in Dataset (datahub-project#10877) * docs(saas-overview) added missing features to observe section (datahub-project#10913) Co-authored-by: John Joyce <[email protected]> * fix(ingest/spark): Fixing Micrometer warning (datahub-project#10882) * fix(structured properties): allow application of structured properties without schema file (datahub-project#10918) * fix(data-contracts-web) handle other schedule types (datahub-project#10919) * fix(ingestion/tableau): human-readable message for PERMISSIONS_MODE_SWITCHED error (datahub-project#10866) Co-authored-by: Harshal Sheth <[email protected]> * Add feature flag for view defintions (datahub-project#10914) Co-authored-by: Ethan Cartwright <[email protected]> * feat(ingest/BigQuery): refactor+parallelize dataset metadata extraction (datahub-project#10884) * fix(airflow): add error handling around render_template() (datahub-project#10907) * feat(ingestion/sqlglot): add optional `default_dialect` parameter to sqlglot lineage (datahub-project#10830) * feat(mcp-mutator): new mcp mutator plugin (datahub-project#10904) * fix(ingest/bigquery): changes helper function to decode unicode scape sequences (datahub-project#10845) * feat(ingest/postgres): fetch table sizes for profile (datahub-project#10864) * feat(ingest/abs): Adding azure blob storage ingestion source (datahub-project#10813) * fix(ingest/redshift): reduce severity of SQL parsing issues (datahub-project#10924) * fix(build): fix lint fix web react (datahub-project#10896) * fix(ingest/bigquery): handle quota exceeded for project.list requests (datahub-project#10912) * feat(ingest): report extractor failures more loudly (datahub-project#10908) * feat(ingest/snowflake): integrate snowflake-queries into main source (datahub-project#10905) * fix(ingest): fix docs build (datahub-project#10926) * fix(ingest/snowflake): fix test connection (datahub-project#10927) * fix(ingest/lookml): add view load failures to cache (datahub-project#10923) * docs(slack) overhauled setup instructions and screenshots (datahub-project#10922) Co-authored-by: John Joyce <[email protected]> * fix(airflow): Add comma parsing of owners to DataJobs (datahub-project#10903) * fix(entityservice): fix merging sideeffects (datahub-project#10937) * feat(ingest): Support System Ingestion Sources, Show and hide system ingestion sources with Command-S (datahub-project#10938) Co-authored-by: John Joyce <[email protected]> * chore() Set a default lineage filtering end time on backend when a start time is present (datahub-project#10925) Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> * Added relationships APIs to V3. Added these generic APIs to V3 swagger doc. (datahub-project#10939) * docs: add learning center to docs (datahub-project#10921) * doc: Update hubspot form id (datahub-project#10943) * chore(airflow): add python 3.11 w/ Airflow 2.9 to CI (datahub-project#10941) * fix(ingest/Glue): column upstream lineage between S3 and Glue (datahub-project#10895) * fix(ingest/abs): split abs utils into multiple files (datahub-project#10945) * doc(ingest/looker): fix doc for sql parsing documentation (datahub-project#10883) Co-authored-by: Harshal Sheth <[email protected]> * fix(ingest/bigquery): Adding missing BigQuery types (datahub-project#10950) * fix(ingest/setup): feast and abs source setup (datahub-project#10951) * fix(connections) Harden adding /gms to connections in backend (datahub-project#10942) * feat(siblings) Add flag to prevent combining siblings in the UI (datahub-project#10952) * fix(docs): make graphql doc gen more automated (datahub-project#10953) * feat(ingest/athena): Add option for Athena partitioned profiling (datahub-project#10723) * fix(spark-lineage): default timeout for future responses (datahub-project#10947) * feat(datajob/flow): add environment filter using info aspects (datahub-project#10814) * fix(ui/ingest): correct privilege used to show tab (datahub-project#10483) Co-authored-by: Kunal-kankriya <[email protected]> * feat(ingest/looker): include dashboard urns in browse v2 (datahub-project#10955) * add a structured type to batchGet in OpenAPI V3 spec (datahub-project#10956) * fix(ui): scroll on the domain sidebar to show all domains (datahub-project#10966) * fix(ingest/sagemaker): resolve incorrect variable assignment for SageMaker API call (datahub-project#10965) * fix(airflow/build): Pinning mypy (datahub-project#10972) * Fixed a bug where the OpenAPI V3 spec was incorrect. The bug was introduced in datahub-project#10939. (datahub-project#10974) * fix(ingest/test): Fix for mssql integration tests (datahub-project#10978) * fix(entity-service) exist check correctly extracts status (datahub-project#10973) * fix(structuredProps) casing bug in StructuredPropertiesValidator (datahub-project#10982) * bugfix: use anyOf instead of allOf when creating references in openapi v3 spec (datahub-project#10986) * fix(ui): Remove ant less imports (datahub-project#10988) * feat(ingest/graph): Add get_results_by_filter to DataHubGraph (datahub-project#10987) * feat(ingest/cli): init does not actually support environment variables (datahub-project#10989) * fix(ingest/graph): Update get_results_by_filter graphql query (datahub-project#10991) * feat(ingest/spark): Promote beta plugin (datahub-project#10881) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingest): support domains in meta -> "datahub" section (datahub-project#10967) * feat(ingest): add `check server-config` command (datahub-project#10990) * feat(cli): Make consistent use of DataHubGraphClientConfig (datahub-project#10466) Deprecates get_url_and_token() in favor of a more complete option: load_graph_config() that returns a full DatahubClientConfig. This change was then propagated across previous usages of get_url_and_token so that connections to DataHub server from the client respect the full breadth of configuration specified by DatahubClientConfig. I.e: You can now specify disable_ssl_verification: true in your ~/.datahubenv file so that all cli functions to the server work when ssl certification is disabled. Fixes datahub-project#9705 * fix(ingest/s3): Fixing container creation when there is no folder in path (datahub-project#10993) * fix(ingest/looker): support platform instance for dashboards & charts (datahub-project#10771) * feat(ingest/bigquery): improve handling of information schema in sql parser (datahub-project#10985) * feat(ingest): improve `ingest deploy` command (datahub-project#10944) * fix(backend): allow excluding soft-deleted entities in relationship-queries; exclude soft-deleted members of groups (datahub-project#10920) - allow excluding soft-deleted entities in relationship-queries - exclude soft-deleted members of groups * fix(ingest/looker): downgrade missing chart type log level (datahub-project#10996) * doc(acryl-cloud): release docs for 0.3.4.x (datahub-project#10984) Co-authored-by: John Joyce <[email protected]> Co-authored-by: RyanHolstien <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Pedro Silva <[email protected]> * fix(protobuf/build): Fix protobuf check jar script (datahub-project#11006) * fix(ui/ingest): Support invalid cron jobs (datahub-project#10998) * fix(ingest): fix graph config loading (datahub-project#11002) Co-authored-by: Pedro Silva <[email protected]> * feat(docs): Document __DATAHUB_TO_FILE_ directive (datahub-project#10968) Co-authored-by: Harshal Sheth <[email protected]> * fix(graphql/upsertIngestionSource): Validate cron schedule; parse error in CLI (datahub-project#11011) * feat(ece): support custom ownership type urns in ECE generation (datahub-project#10999) * feat(assertion-v2): changed Validation tab to Quality and created new Governance tab (datahub-project#10935) * fix(ingestion/glue): Add support for missing config options for profiling in Glue (datahub-project#10858) * feat(propagation): Add models for schema field docs, tags, terms (datahub-project#2959) (datahub-project#11016) Co-authored-by: Chris Collins <[email protected]> * docs: standardize terminology to DataHub Cloud (datahub-project#11003) * fix(ingestion/transformer): replace the externalUrl container (datahub-project#11013) * docs(slack) troubleshoot docs (datahub-project#11014) * feat(propagation): Add graphql API (datahub-project#11030) Co-authored-by: Chris Collins <[email protected]> * feat(propagation): Add models for Action feature settings (datahub-project#11029) * docs(custom properties): Remove duplicate from sidebar (datahub-project#11033) * feat(models): Introducing Dataset Partitions Aspect (datahub-project#10997) Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> * feat(propagation): Add Documentation Propagation Settings (datahub-project#11038) * fix(models): chart schema fields mapping, add dataHubAction entity, t… (datahub-project#11040) * fix(ci): smoke test lint failures (datahub-project#11044) * docs: fix learning center color scheme & typo (datahub-project#11043) * feat: add cloud main page (datahub-project#11017) Co-authored-by: Jay <[email protected]> * feat(restore-indices): add additional step to also clear system metadata service (datahub-project#10662) Co-authored-by: John Joyce <[email protected]> * docs: fix typo (datahub-project#11046) * fix(lint): apply spotless (datahub-project#11050) * docs(airflow): example query to get datajobs for a dataflow (datahub-project#11034) * feat(cli): Add run-id option to put sub-command (datahub-project#11023) Adds an option to assign run-id to a given put command execution. This is useful when transformers do not exist for a given ingestion payload, we can follow up with custom metadata and assign it to an ingestion pipeline. * fix(ingest): improve sql error reporting calls (datahub-project#11025) * fix(airflow): fix CI setup (datahub-project#11031) * feat(ingest/dbt): add experimental `prefer_sql_parser_lineage` flag (datahub-project#11039) * fix(ingestion/lookml): enable stack-trace in lookml logs (datahub-project#10971) * (chore): Linting fix (datahub-project#11015) * chore(ci): update deprecated github actions (datahub-project#10977) * Fix ALB configuration example (datahub-project#10981) * chore(ingestion-base): bump base image packages (datahub-project#11053) * feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size (datahub-project#11051) * fix(ingestion/lookml): emit dummy sql condition for lookml custom condition tag (datahub-project#11008) Co-authored-by: Harshal Sheth <[email protected]> * fix(ingestion/powerbi): fix issue with broken report lineage (datahub-project#10910) * feat(ingest/tableau): add retry on timeout (datahub-project#10995) * change generate kafka connect properties from env (datahub-project#10545) Co-authored-by: david-leifker <[email protected]> * fix(ingest): fix oracle cronjob ingestion (datahub-project#11001) Co-authored-by: david-leifker <[email protected]> * chore(ci): revert update deprecated github actions (datahub-project#10977) (datahub-project#11062) * feat(ingest/dbt-cloud): update metadata_endpoint inference (datahub-project#11041) * build: Reduce size of datahub-frontend-react image by 50-ish% (datahub-project#10878) Co-authored-by: david-leifker <[email protected]> * fix(ci): Fix lint issue in datahub_ingestion_run_summary_provider.py (datahub-project#11063) * docs(ingest): update developing-a-transformer.md (datahub-project#11019) * feat(search-test): update search tests from datahub-project#10408 (datahub-project#11056) * feat(cli): add aspects parameter to DataHubGraph.get_entity_semityped (datahub-project#11009) Co-authored-by: Harshal Sheth <[email protected]> * docs(airflow): update min version for plugin v2 (datahub-project#11065) * doc(ingestion/tableau): doc update for derived permission (datahub-project#11054) Co-authored-by: Pedro Silva <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Harshal Sheth <[email protected]> * fix(py): remove dep on types-pkg_resources (datahub-project#11076) * feat(ingest/mode): add option to exclude restricted (datahub-project#11081) * fix(ingest): set lastObserved in sdk when unset (datahub-project#11071) * doc(ingest): Update capabilities (datahub-project#11072) * chore(vulnerability): Log Injection (datahub-project#11090) * chore(vulnerability): Information exposure through a stack trace (datahub-project#11091) * chore(vulnerability): Comparison of narrow type with wide type in loop condition (datahub-project#11089) * chore(vulnerability): Insertion of sensitive information into log files (datahub-project#11088) * chore(vulnerability): Risky Cryptographic Algorithm (datahub-project#11059) * chore(vulnerability): Overly permissive regex range (datahub-project#11061) Co-authored-by: Harshal Sheth <[email protected]> * fix: update customer data (datahub-project#11075) * fix(models): fixing the datasetPartition models (datahub-project#11085) Co-authored-by: John Joyce <[email protected]> * fix(ui): Adding view, forms GraphQL query, remove showing a fallback error message on unhandled GraphQL error (datahub-project#11084) Co-authored-by: John Joyce <[email protected]> * feat(docs-site): hiding learn more from cloud page (datahub-project#11097) * fix(docs): Add correct usage of orFilters in search API docs (datahub-project#11082) Co-authored-by: Jay <[email protected]> * fix(ingest/mode): Regexp in mode name matcher didn't allow underscore (datahub-project#11098) * docs: Refactor customer stories section (datahub-project#10869) Co-authored-by: Jeff Merrick <[email protected]> * fix(release): fix full/slim suffix on tag (datahub-project#11087) * feat(config): support alternate hashing algorithm for doc id (datahub-project#10423) Co-authored-by: david-leifker <[email protected]> Co-authored-by: John Joyce <[email protected]> * fix(emitter): fix typo in get method of java kafka emitter (datahub-project#11007) * fix(ingest): use correct native data type in all SQLAlchemy sources by compiling data type using dialect (datahub-project#10898) Co-authored-by: Harshal Sheth <[email protected]> * chore: Update contributors list in PR labeler (datahub-project#11105) * feat(ingest): tweak stale entity removal messaging (datahub-project#11064) * fix(ingestion): enforce lastObserved timestamps in SystemMetadata (datahub-project#11104) * fix(ingest/powerbi): fix broken lineage between chart and dataset (datahub-project#11080) * feat(ingest/lookml): CLL support for sql set in sql_table_name attribute of lookml view (datahub-project#11069) * docs: update graphql docs on forms & structured properties (datahub-project#11100) * test(search): search openAPI v3 test (datahub-project#11049) * fix(ingest/tableau): prevent empty site content urls (datahub-project#11057) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(entity-client): implement client batch interface (datahub-project#11106) * fix(snowflake): avoid reporting warnings/info for sys tables (datahub-project#11114) * fix(ingest): downgrade column type mapping warning to info (datahub-project#11115) * feat(api): add AuditStamp to the V3 API entity/aspect response (datahub-project#11118) * fix(ingest/redshift): replace r'\n' with '\n' to avoid token error redshift serverless… (datahub-project#11111) * fix(entiy-client): handle null entityUrn case for restli (datahub-project#11122) * fix(sql-parser): prevent bad urns from alter table lineage (datahub-project#11092) * fix(ingest/bigquery): use small batch size if use_tables_list_query_v2 is set (datahub-project#11121) * fix(graphql): add missing entities to EntityTypeMapper and EntityTypeUrnMapper (datahub-project#10366) * feat(ui): Changes to allow editable dataset name (datahub-project#10608) Co-authored-by: Jay Kadambi <[email protected]> * fix: remove saxo (datahub-project#11127) * feat(mcl-processor): Update mcl processor hooks (datahub-project#11134) * fix(openapi): fix openapi v2 endpoints & v3 documentation update * Revert "fix(openapi): fix openapi v2 endpoints & v3 documentation update" This reverts commit 573c1cb. * docs(policies): updates to policies documentation (datahub-project#11073) * fix(openapi): fix openapi v2 and v3 docs update (datahub-project#11139) * feat(auth): grant type and acr values custom oidc parameters support (datahub-project#11116) * fix(mutator): mutator hook fixes (datahub-project#11140) * feat(search): support sorting on multiple fields (datahub-project#10775) * feat(ingest): various logging improvements (datahub-project#11126) * fix(ingestion/lookml): fix for sql parsing error (datahub-project#11079) Co-authored-by: Harshal Sheth <[email protected]> * feat(docs-site) cloud page spacing and content polishes (datahub-project#11141) * feat(ui) Enable editing structured props on fields (datahub-project#11042) * feat(tests): add md5 and last computed to testResult model (datahub-project#11117) * test(openapi): openapi regression smoke tests (datahub-project#11143) * fix(airflow): fix tox tests + update docs (datahub-project#11125) * docs: add chime to adoption stories (datahub-project#11142) * fix(ingest/databricks): Updating code to work with Databricks sdk 0.30 (datahub-project#11158) * fix(kafka-setup): add missing script to image (datahub-project#11190) * fix(config): fix hash algo config (datahub-project#11191) * test(smoke-test): updates to smoke-tests (datahub-project#11152) * fix(elasticsearch): refactor idHashAlgo setting (datahub-project#11193) * chore(kafka): kafka version bump (datahub-project#11211) * readd UsageStatsWorkUnit * fix merge problems * change logo --------- Co-authored-by: Chris Collins <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: dushayntAW <[email protected]> Co-authored-by: sagar-salvi-apptware <[email protected]> Co-authored-by: Aseem Bansal <[email protected]> Co-authored-by: Kevin Chun <[email protected]> Co-authored-by: jordanjeremy <[email protected]> Co-authored-by: skrydal <[email protected]> Co-authored-by: Harshal Sheth <[email protected]> Co-authored-by: david-leifker <[email protected]> Co-authored-by: sid-acryl <[email protected]> Co-authored-by: Julien Jehannet <[email protected]> Co-authored-by: Hendrik Richert <[email protected]> Co-authored-by: Hendrik Richert <[email protected]> Co-authored-by: RyanHolstien <[email protected]> Co-authored-by: Felix Lüdin <[email protected]> Co-authored-by: Pirry <[email protected]> Co-authored-by: Hyejin Yoon <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: cburroughs <[email protected]> Co-authored-by: ksrinath <[email protected]> Co-authored-by: Mayuri Nehate <[email protected]> Co-authored-by: Kunal-kankriya <[email protected]> Co-authored-by: Shirshanka Das <[email protected]> Co-authored-by: ipolding-cais <[email protected]> Co-authored-by: Tamas Nemeth <[email protected]> Co-authored-by: Shubham Jagtap <[email protected]> Co-authored-by: haeniya <[email protected]> Co-authored-by: Yanik Häni <[email protected]> Co-authored-by: Gabe Lyons <[email protected]> Co-authored-by: Gabe Lyons <[email protected]> Co-authored-by: 808OVADOZE <[email protected]> Co-authored-by: noggi <[email protected]> Co-authored-by: Nicholas Pena <[email protected]> Co-authored-by: Jay <[email protected]> Co-authored-by: ethan-cartwright <[email protected]> Co-authored-by: Ethan Cartwright <[email protected]> Co-authored-by: Nadav Gross <[email protected]> Co-authored-by: Patrick Franco Braz <[email protected]> Co-authored-by: pie1nthesky <[email protected]> Co-authored-by: Joel Pinto Mata (KPN-DSH-DEX team) <[email protected]> Co-authored-by: Ellie O'Neil <[email protected]> Co-authored-by: Ajoy Majumdar <[email protected]> Co-authored-by: deepgarg-visa <[email protected]> Co-authored-by: Tristan Heisler <[email protected]> Co-authored-by: Andrew Sikowitz <[email protected]> Co-authored-by: Davi Arnaut <[email protected]> Co-authored-by: Pedro Silva <[email protected]> Co-authored-by: amit-apptware <[email protected]> Co-authored-by: Sam Black <[email protected]> Co-authored-by: Raj Tekal <[email protected]> Co-authored-by: Steffen Grohsschmiedt <[email protected]> Co-authored-by: jaegwon.seo <[email protected]> Co-authored-by: Renan F. Lima <[email protected]> Co-authored-by: Matt Exchange <[email protected]> Co-authored-by: Jonny Dixon <[email protected]> Co-authored-by: Pedro Silva <[email protected]> Co-authored-by: Pinaki Bhattacharjee <[email protected]> Co-authored-by: Jeff Merrick <[email protected]> Co-authored-by: skrydal <[email protected]> Co-authored-by: AndreasHegerNuritas <[email protected]> Co-authored-by: jayasimhankv <[email protected]> Co-authored-by: Jay Kadambi <[email protected]> Co-authored-by: David Leifker <[email protected]>
2 participants
Summary by CodeRabbit
New Features
Improvements
Documentation
Style