Files that changed from the base of the PR and between 609847f and c7b4002.

• docs/advanced/mcp-mcl.md (4 hunks)
• docs/api/openapi/openapi-usage-guide.md (2 hunks)
• docs/how/updating-datahub.md (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java (1 hunks)
• entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java (1 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java (4 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java (2 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (1 hunks)
• metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/openlineage-converter/build.gradle (1 hunks)
• metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (8 hunks)
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java (7 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java (3 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java (6 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java (4 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java (3 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java (14 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl (1 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl (1 hunks)
• metadata-models/src/main/resources/entity-registry.yml (1 hunks)
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java (3 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (3 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (2 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java (1 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (4 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (2 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json (1 hunks)
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java (3 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java (2 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/utils/metrics/ExceptionUtils.java (1 hunks)

• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java (1)

5-6: Enhancement: Introduced Generic Type Parameter for Flexibility

The addition of the generic type parameter T to the GenericEntity interface and the updated return type of getAspects improve type safety and flexibility. This allows for more specific type handling in implementing classes.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java (1)

3-3: Enhancement: Added Type Parameters for Improved Type Specificity

The addition of type parameters A and T to the GenericEntityScrollResult interface enhances type specificity and safety. This change allows for more precise type handling in implementing classes.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1)

10-11: Enhancement: Implemented Generic Interface with Specific Types

The GenericEntityScrollResultV2 class now implements the GenericEntityScrollResult interface with specific types GenericAspectV2 and GenericEntityV2. This improves type safety and specificity in handling scroll results.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java (1)

10-11: Enhancement: Implemented Generic Interface with Specific Types

The GenericEntityScrollResultV3 class now implements the GenericEntityScrollResult interface with specific types GenericAspectV3 and GenericEntityV3. This improves type safety and specificity in handling scroll results.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java (2)

13-17: Annotations for immutability and serialization look good.

The annotations ensure the class is immutable and only non-null fields are included in JSON serialization.

---

18-21: Class definition and fields are correct.

The class implements GenericAspect and includes non-null value, nullable systemMetadata, and headers fields, which align with the PR objectives.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java (3)

9-9: Class definition and inheritance are correct.

The class extends LinkedHashMap and implements GenericAspect, which provides the necessary structure for aspect data.

---

11-13: Constructor looks good.

The constructor initializes the LinkedHashMap with the provided map.

---

15-19: getValue method is correct.

The method returns the LinkedHashMap instance itself as the value.

entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (2)

14-17: Annotations for immutability and equality look good.

The annotations ensure the class is immutable and provides proper equality checks.

---

18-26: Class definition and fields are correct.

The class implements SystemAspect and includes fields for urn, version, recordTemplate, systemMetadata, entitySpec, aspectSpec, createdOn, and createdBy, which align with the PR objectives.

entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java (2)

Line range hint 1-1:
Interface declaration is correct.

The interface SystemAspect extends ReadItem and includes methods for version, creation timestamp, and audit stamp.

---

28-38: New method getSystemMetadataVersion is correct.

The method correctly retrieves the version from the system metadata if it exists.

metadata-integration/java/openlineage-converter/build.gradle (1)

27-27: Approve the addition of the testng dependency.

The addition of the testng dependency is approved.

However, ensure that the use of testng is consistent with other test configurations in the project.

metadata-utils/src/main/java/com/linkedin/metadata/utils/metrics/ExceptionUtils.java (1)

11-42: Approve the collectMetrics method.

The collectMetrics method is well-structured and correctly uses MetricUtils to increment various counters based on exception details.

However, ensure that MetricUtils is correctly configured and used in the project.

entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java (1)

1-62: Approve the EnvelopedSystemAspect class.

The EnvelopedSystemAspect class is well-structured and provides correct implementations for all required methods.

entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java (1)

1-70: Approve the AspectValidationException class.

The AspectValidationException class is well-structured and provides correct implementations for creating exceptions with different subtypes and messages.

entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java (2)

35-41: LGTM!

The method getLatestSystemAspect correctly retrieves the latest system aspect for a given URN and aspect name.

---

49-50: LGTM!

The method getLatestSystemAspects correctly retrieves the latest system aspects for a set of URNs and aspect names.

entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java (1)

23-23: LGTM!

The method addException uses computeIfAbsent to efficiently add exceptions to the collection.

entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java (3)

25-31: LGTM!

The method getHeaders correctly retrieves headers from the metadata change proposal, handling null values appropriately.

---

33-35: LGTM!

The method hasHeader correctly checks for the presence of a specific header.

---

37-42: LGTM!

The method getHeader correctly retrieves the value of a specific header.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java (2)

27-34: LGTM! The class correctly implements the interface.

The class GenericEntityV2 now implements GenericEntity<GenericAspectV2>, which aligns with the intended functionality.

---

Line range hint 40-62:
LGTM! The build method correctly processes the aspects.

The build method in GenericEntityV2Builder now correctly processes GenericAspectV2 and handles potential exceptions.

metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java (2)

4-4: LGTM! The new import is necessary and used correctly.

The import entityResponseToSystemAspectMap is necessary for the new method getLatestSystemAspects.

---

56-80: LGTM! The method correctly retrieves the latest system aspects.

The method getLatestSystemAspects correctly retrieves the latest system aspects for given URNs and aspect names and handles potential exceptions.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java (2)

28-39: LGTM! The class correctly implements the interface.

The class GenericEntityV3 now implements GenericEntity<GenericAspectV3>, which aligns with the intended functionality.

---

48-70: LGTM! The build method correctly processes the aspects.

The build method in GenericEntityV3Builder now correctly processes GenericAspectV3 and handles potential exceptions.

metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java (2)

34-38: LGTM! The method correctly handles the new version field.

The createSystemMetadata method now correctly handles the new version field.

---

47-55: LGTM! The method correctly handles the new version field.

The createSystemMetadata method now correctly handles the new version field.

metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2)

29-29: Validation ensures at least one rule is required.

The change correctly enforces that DataQualityRules must contain at least one rule, which is essential for validation.

---

58-59: Validation ensures field type consistency.

The change correctly validates that the field type remains consistent between the old and new DataQualityRules, which is essential for data integrity.

entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java (3)

9-13: New imports for SystemAspect and SystemMetadata.

The new imports are necessary for the added functionality related to SystemAspect and SystemMetadata.

---

48-61: Initialization of systemData with SystemAspect.

The change ensures that systemData is properly initialized with SystemAspect objects, which is necessary for the new functionality.

---

84-92: New method getLatestSystemAspects.

The method correctly retrieves the latest system aspects based on the provided urnAspectNames. This is necessary for the new functionality.

metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java (2)

52-52: Validation ensures at least one rule is required.

The change correctly enforces that DataQualityRules must contain at least one rule, which is essential for validation.

---

81-82: Validation ensures field type consistency.

The change correctly validates that the field type remains consistent between the old and new DataQualityRules, which is essential for data integrity.

metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java (1)

94-115: New method entityResponseToSystemAspectMap.

The method correctly converts EntityResponse objects to maps of SystemAspect objects based on the provided EntityRegistry. This is necessary for the new functionality.

entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java (3)

23-24: Add import statements for Map and Optional.

The import statements for Map and Optional are necessary for the newly added headers functionality.

---

125-125: Addition of headers field.

The headers field has been added to the TestMCP class to store HTTP-like headers.

---

133-142: Implementation of getHeaders method.

The getHeaders method retrieves headers from the metadataChangeProposal if available; otherwise, it returns the default headers.

metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (3)

170-174: Addition of version field to SystemMetadata.

The version field has been added to store the aspect version. This change allows for more precise version tracking of aspects.

---

177-178: Documentation update for SystemMetadata.

The documentation for SystemMetadata has been updated to reflect the addition of the version field.

---

180-185: Addition of headers field to MetadataChangeProposal.

The headers field has been added to support HTTP-like headers for metadata change proposals. This change enhances the flexibility of metadata proposals.

metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc (3)

170-174: Addition of version field to SystemMetadata.

The version field has been added to store the aspect version. This change allows for more precise version tracking of aspects.

---

177-178: Documentation update for SystemMetadata.

The documentation for SystemMetadata has been updated to reflect the addition of the version field.

---

180-185: Addition of headers field to MetadataChangeProposal.

The headers field has been added to support HTTP-like headers for metadata change proposals. This change enhances the flexibility of metadata proposals.

metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json (1)

149-153: Addition of version field to SystemMetadata.

The version field has been added to store the aspect version. This change allows for more precise version tracking of aspects.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (2)

189-194: Ensure proper handling of null headers.

The code correctly converts the headers to a map, but ensure that it handles cases where headers are not present.

---

202-206: LGTM! Ensure the retriever context is correctly passed.

The addition of headers in the ChangeItemImpl builder looks good.

However, ensure that the retriever context is correctly passed to the build method.

docs/advanced/mcp-mcl.md (1)

192-192: Remove loose punctuation mark.

There is a loose punctuation mark before A writer can specify.

- `If-Unmodified-Since`:
+ `If-Unmodified-Since`

Likely invalid or redundant comment.

Tools

LanguageTool

[uncategorized] ~192-~192: Loose punctuation mark.
Context: ...SO-8601 standard. If-Unmodified-Since: A writer can specify that the aspect mu...

(UNLIKELY_OPENING_PUNCTUATION)

entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java (6)

96-103: Ensure proper handling of version precondition validation.

The code correctly validates the version precondition, but ensure that all edge cases are handled.

---

106-119: Ensure proper handling of time precondition validation.

The code correctly validates the time precondition, but ensure that all edge cases are handled.

---

150-158: LGTM! Ensure accurate version comparison.

The version comparison logic looks good.

However, ensure that the comparison handles all potential version formats accurately.

---

181-204: LGTM! Ensure accurate time comparison.

The time comparison logic looks good.

However, ensure that the comparison handles all potential time formats accurately.

---

50-53: Simplify the method by using a single return statement.

The method hasTimePrecondition can be simplified by using a single return statement.

- return item.getHeader(HttpHeaders.IF_MODIFIED_SINCE).isPresent()
-        || item.getHeader(HttpHeaders.IF_UNMODIFIED_SINCE).isPresent();
+ return item.getHeader(HttpHeaders.IF_MODIFIED_SINCE).isPresent() || 
+        item.getHeader(HttpHeaders.IF_UNMODIFIED_SINCE).isPresent();

Likely invalid or redundant comment.

---

56-57: Simplify the method by using a single return statement.

The method hasVersionPrecondition can be simplified by using a single return statement.

- return item.getHeader(HTTP_HEADER_IF_VERSION_MATCH).isPresent();
+ return item.getHeader(HTTP_HEADER_IF_VERSION_MATCH).isPresent();

Likely invalid or redundant comment.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (3)

37-37: Import new models for type-safe handling.

The new imports for GenericAspectV2, GenericEntityV2, and GenericEntityScrollResultV2 align with the updated type-safe handling for aspects and entities.

---

72-72: Type-safe handling for aspects and entities.

The class EntityController now uses type parameters for GenericAspectV2, GenericEntityV2, and GenericEntityScrollResultV2, enhancing type safety and extensibility.

---

75-82: Build scroll result with type-safe aspects and entities.

The method buildScrollResult now returns a GenericEntityScrollResultV2 object, ensuring type-safe handling of aspects and entities.

metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (8)

16-17: Add imports for testing framework.

The new imports for Assert and Test from org.testng are necessary for the test cases.

---

45-45: Set environment for path specifications.

The env field is set using Optional.of("PROD"), ensuring the environment is correctly specified for path specifications.

---

92-92: Set environment for path specifications.

The env field is set using Optional.of("PROD"), ensuring the environment is correctly specified for path specifications.

---

124-124: Set environment for path specifications.

The env field is set using Optional.of("PROD"), ensuring the environment is correctly specified for path specifications.

---

157-157: Set environment and platform instance for path specifications.

The env and platformInstance fields are set using Optional.of("PROD") and Optional.of("s3Instance"), respectively, ensuring the environment and platform instance are correctly specified for path specifications.

---

190-190: Set environment for path specifications.

The env field is set using Optional.of("PROD"), ensuring the environment is correctly specified for path specifications.

---

222-222: Set environment for path specifications.

The env field is set using Optional.of("PROD"), ensuring the environment is correctly specified for path specifications.

---

252-252: Set environment for path specifications.

The env field is set using Optional.of("PROD"), ensuring the environment is correctly specified for path specifications.

metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java (10)

7-7: Import StringMap for headers.

The new import for StringMap is necessary for handling headers in ChangeItemImpl.

---

27-29: Add imports for handling optional and stream operations.

The new imports for Optional and Collectors are necessary for handling optional values and stream operations in ChangeItemImpl.

---

76-76: Add system metadata field.

The new field systemMetadata is necessary for handling system metadata in ChangeItemImpl.

---

88-89: Add headers field.

The new field headers is necessary for handling headers in ChangeItemImpl.

---

90-99: Update next aspect version and system metadata.

The method setNextAspectVersion updates the next aspect version and the system metadata accordingly.

---

103-124: Generate system aspect with updated system metadata.

The method getSystemAspect generates a SystemAspect object with the updated system metadata.

---

144-146: Include headers in MetadataChangeProposal.

The method getMetadataChangeProposal includes headers in the MetadataChangeProposal if they are present.

---

151-160: Get headers from MetadataChangeProposal or default headers.

The method getHeaders returns the headers from the MetadataChangeProposal if they are present, otherwise it returns the default headers.

---

179-183: Initialize headers if null.

The builder method initializes the headers to an empty map if they are null.

---

207-208: Include headers in ChangeItemImpl builder.

The builder includes the headers field in the ChangeItemImpl object.

metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java (1)

273-279: Add method to retrieve latest system aspects.

The method getLatestSystemAspects retrieves the latest system aspects for the given URNs and aspect names.

metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java (4)

37-37: Imports look good.

The addition of Set and Stream imports is necessary for the new methods.

Also applies to: 39-39

---

164-167: Parameter renaming in toSystemAspect.

The parameter aspectRetriever has been renamed to retrieverContext. This improves clarity since retrieverContext is more descriptive.

---

293-335: New method calculateNextVersions added.

This method calculates the next versions of aspects using both precalculated and database values. The logic is sound and efficiently merges the two sources. Ensure that the aspectDao.getNextVersions method handles missing aspect versions correctly.

---

343-351: New method convertSystemAspectToNextVersionMap added.

This method extracts the next version from a map of system aspects. The logic is straightforward and efficient, using streams and filtering. Ensure that aspects with version 0 and system metadata version are correctly processed.

metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java (1)

353-360: Handling of SystemMetadata in getProposalFromAspectForDefault.

The added block ensures that the SystemMetadata is copied and its version is removed before setting it in the proposal. This is a good practice to avoid unintended versioning issues.

metadata-models/src/main/resources/entity-registry.yml (1)

622-633: Addition of ConditionalWriteValidator.

The ConditionalWriteValidator class is added with support for multiple operations. This is a significant addition for handling conditional writes. Ensure that the validator is correctly implemented and integrated.

metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java (1)

607-615: New method getLatestSystemAspect added.

This method retrieves the latest system aspects for a set of URNs and aspect names. The logic is sound, and the method provides a useful utility for fetching system aspects. Ensure that the entityResponseToSystemAspectMap handles the conversion correctly.

metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java (2)

392-392: LGTM! Assertion addition improves test coverage.

The added assertion correctly checks the aspect group key and the exception message, which enhances the test coverage for immutable property validation.

---

487-487: LGTM! Assertion addition improves test coverage.

The added assertion correctly checks the aspect group key and the exception message, which enhances the test coverage for immutable property deletion validation.

docs/api/openapi/openapi-usage-guide.md (1)

586-591: LGTM! Documentation for OpenAPI v3 features is clear.

The added section clearly explains the support for conditional writes in OpenAPI v3.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (2)

82-84: LGTM! Enhanced type safety and extensibility.

The added generic type parameters improve type safety and extensibility of the GenericEntitiesController class.

---

288-288: LGTM! Consistent update to method signature.

The updated method signature with generic type parameters ensures consistency with the class changes.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java (1)

511-534: LGTM! Verify consistency with overall system design.

The changes to include systemMetadata and headers properties in the buildAspectRefRequestSchema method look good. Ensure that these changes are consistent with the overall system design and usage.

entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java (14)

70-130: LGTM!

The testNextVersionSuccess method comprehensively tests the ConditionalWriteValidator for various ChangeType values, ensuring no exceptions are thrown when the expected and actual versions match.

---

132-174: LGTM!

The testNoSystemMetadataNextVersionNextVersionSuccess method effectively tests the ConditionalWriteValidator when there is no previous system metadata, ensuring fallback to the version field.

---

176-237: LGTM!

The testNoPreviousVersionsLookupSchemaMetadataNextVersionSuccess method is well-structured and effectively tests the ConditionalWriteValidator with a mock lookup based on version.

---

239-299: LGTM!

The testNoPreviousVersionsLookupVersionNextVersionSuccess method effectively tests the ConditionalWriteValidator with a mock lookup based on version, ensuring no exceptions are thrown when the expected and actual versions match.

---

301-379: LGTM!

The testNextVersionFail method comprehensively tests the ConditionalWriteValidator for various ChangeType values, ensuring exceptions are thrown when the expected and actual versions do not match.

---

381-440: LGTM!

The testNoSystemMetadataNextVersionNextVersionFail method effectively tests the ConditionalWriteValidator when there is no previous system metadata, ensuring exceptions are thrown when the expected and actual versions do not match.

---

442-523: LGTM!

The testNoPreviousVersionsLookupSchemaMetadataNextVersionFail method is well-structured and effectively tests the ConditionalWriteValidator with a mock lookup based on version, ensuring exceptions are thrown when the expected and actual versions do not match.

---

525-599: LGTM!

The testNoPreviousVersionsLookupVersionNextVersionFail method effectively tests the ConditionalWriteValidator with a mock lookup based on version, ensuring exceptions are thrown when the expected and actual versions do not match.

---

601-674: LGTM!

The testModifiedSinceSuccess method comprehensively tests the ConditionalWriteValidator for various ChangeType values, ensuring no exceptions are thrown when the modified timestamp falls within the specified range.

---

676-749: LGTM!

The testNoPreviousLookupAuditStampModifiedSinceSuccess method is well-structured and effectively tests the ConditionalWriteValidator with a mock lookup based on audit stamp, ensuring no exceptions are thrown when the modified timestamp falls within the specified range.

---

751-836: LGTM!

The testModifiedSinceBeforeRangeFail method comprehensively tests the ConditionalWriteValidator for various ChangeType values, ensuring exceptions are thrown when the modified timestamp is before the specified range.

---

839-923: LGTM!

The testModifiedSinceAfterRangeFail method comprehensively tests the ConditionalWriteValidator for various ChangeType values, ensuring exceptions are thrown when the modified timestamp is after the specified range.

---

925-1010: LGTM!

The testNoPreviousLookupAuditStampModifiedSinceBeforeRangeFail method is well-structured and effectively tests the ConditionalWriteValidator with a mock lookup based on audit stamp, ensuring exceptions are thrown when the modified timestamp is before the specified range.

---

1012-1097: LGTM!

The testNoPreviousLookupAuditStampModifiedSinceAfterRangeFail method is well-structured and effectively tests the ConditionalWriteValidator with a mock lookup based on audit stamp, ensuring exceptions are thrown when the modified timestamp is after the specified range.

metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java (8)

Line range hint 211-213: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instances now include additional parameters. Verify that the createSystemMetadata method correctly handles these parameters and that the test assertions cover these new fields.

---

523-523: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instance now includes a version parameter. Verify that the createSystemMetadata method correctly handles this parameter and that the test assertions cover this new field.

---

606-606: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instance now includes a version parameter. Verify that the createSystemMetadata method correctly handles this parameter and that the test assertions cover this new field.

---

620-620: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instance now includes a version parameter. Verify that the createSystemMetadata method correctly handles this parameter and that the test assertions cover this new field.

---

668-668: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instance now includes a version parameter. Verify that the createSystemMetadata method correctly handles this parameter and that the test assertions cover this new field.

---

697-697: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instance now includes a version parameter. Verify that the createSystemMetadata method correctly handles this parameter and that the test assertions cover this new field.

---

1187-1190: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instances now include additional parameters. Verify that the createSystemMetadata method correctly handles these parameters and that the test assertions cover these new fields.

---

1299-1302: Ensure correct handling of additional parameters in SystemMetadata.

The SystemMetadata instances now include additional parameters. Verify that the createSystemMetadata method correctly handles these parameters and that the test assertions cover these new fields.

metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java (3)

13-13: Approved: Import statement for collectMetrics.

The import statement for collectMetrics is necessary for the new exception handling logic.

---

783-785: Approved: Refactored version calculation logic.

The change to use EntityUtils.calculateNextVersions instead of aspectDao.getNextVersions makes the code more modular and maintainable.

---

802-806: Approved: Enhanced logic for merging aspects and calculating next versions.

The additional logic for merging aspects and calculating next versions ensures the correctness and robustness of the ingestion process.

metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (3)

104-108: Addition of version field in SystemMetadata.

The version field has been added to the SystemMetadata record. Ensure that this field is used consistently across the codebase and that it is properly documented in the relevant sections.

---

4060-4062: Addition of systemMetadata field in MetadataChangeProposal.

The systemMetadata field is already present and correctly documented.

---

4063-4068: Addition of headers field in MetadataChangeProposal.

The headers field has been added to the MetadataChangeProposal record. Ensure that this field is used consistently across the codebase and that it is properly documented in the relevant sections.

metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (1)

6472-6476: Addition of the version field in SystemMetadata looks good.

The new version field is correctly defined as a string and marked as optional, with a clear documentation string. Ensure that its usage is consistent throughout the codebase.

Files that changed from the base of the PR and between c7b4002 and a73f076.

• docs/advanced/mcp-mcl.md (4 hunks)
• docs/api/openapi/openapi-usage-guide.md (2 hunks)
• docs/how/updating-datahub.md (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java (1 hunks)
• entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java (1 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java (4 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java (2 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (1 hunks)
• metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/openlineage-converter/build.gradle (1 hunks)
• metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (8 hunks)
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java (7 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java (3 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java (8 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java (4 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java (3 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java (14 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl (1 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl (1 hunks)
• metadata-models/src/main/resources/entity-registry.yml (1 hunks)
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/client/OpenApiClient.java (4 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnRequestV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnResponseV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java (3 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (8 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (4 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java (8 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (5 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (2 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json (1 hunks)
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java (3 hunks)
• metadata-service/services/src/main/java/com/linkedin/metadata/entity/EntityService.java (1 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java (2 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/utils/metrics/ExceptionUtils.java (1 hunks)

• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc
• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl

• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java
• entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java
• metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc
• metadata-integration/java/openlineage-converter/build.gradle
• metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java
• metadata-utils/src/main/java/com/linkedin/metadata/utils/metrics/ExceptionUtils.java

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1)

10-13: LGTM! The class and its fields look good.

The usage of Lombok annotations reduces boilerplate code, making the class definition clean and concise.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnResponseV2.java (1)

17-19: LGTM! The class and its field look good.

The usage of Jackson and OpenAPI annotations ensures proper serialization and API documentation.

entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (1)

14-26: LGTM! The class and its fields look good.

The usage of Lombok annotations reduces boilerplate code, making the class definition clean and concise.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnRequestV2.java (1)

16-18: LGTM! The class and its fields look good.

The usage of Jackson and OpenAPI annotations ensures proper serialization and API documentation.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java (4)

5-5: Import statement approved.

The import statement com.fasterxml.jackson.core.type.TypeReference is necessary for JSON deserialization.

---

28-29: Class declaration approved.

The class GenericEntityV3 extends LinkedHashMap and implements GenericEntity<GenericAspectV3>, which is appropriate for its intended functionality.

---

36-39: Method implementation approved.

The getAspects method filters out the "urn" key and collects the remaining entries into a map of GenericAspectV3.

---

48-71: Builder method implementation approved.

The builder method correctly handles JSON deserialization, constructs GenericAspectV3 objects, and builds a GenericEntityV3.

metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java (3)

Line range hint 9-18:
Import statements approved.

The import statements for SetMode and Nullable annotations are necessary for handling null values and optional parameters.

---

34-38: Method overloads approved.

The new overloads for createSystemMetadata provide flexibility for creating SystemMetadata with different sets of parameters.

---

47-55: Method implementation approved.

The method createSystemMetadata correctly sets the version parameter using SetMode.IGNORE_NULL to ensure it is only set if not null.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/client/OpenApiClient.java (4)

5-6: Import statements approved.

The import statements for BatchGetUrnRequestV2 and BatchGetUrnResponseV2 are necessary for handling V2 batch get requests and responses.

---

43-46: Method implementation approved.

The method getBatchUrnsSystemAuth correctly handles batch get requests with system authentication using V2 request and response models.

---

Line range hint 51-66:
Method implementation approved.

The method getBatchUrns correctly handles batch get requests with specified authentication credentials using V2 request and response models.

---

Line range hint 69-84:
Method implementation approved.

The method mapResponse correctly deserializes the response to BatchGetUrnResponseV2 and handles potential IOExceptions.

docs/advanced/mcp-mcl.md (6)

63-66: Field addition approved.

The headers field added to MetadataChangeProposal is intended to mimic HTTP headers for conditional write logic.

---

172-176: Section addition approved.

The new section correctly explains the use of the headers field for conditional write logic.

Tools

LanguageTool

[grammar] ~174-~174: There seems to be a noun/verb agreement error. Did you mean “writes” or “wrote”?
Context: ...es ### Conditional Writes Conditional write semantics use extra information contain...

(SINGULAR_NOUN_VERB_AGREEMENT)

---

177-185: Section addition approved.

The new section correctly explains version-based conditional writes using the version field in SystemMetadata.

Tools

LanguageTool

[uncategorized] ~179-~179: Possible missing comma found.
Context: ...f-Version-Match Each time an aspect is updated a version is incremented to represent...

(AI_HYDRA_LEO_MISSING_COMMA)

---

[grammar] ~183-~183: The verb ‘write’ does not usually follow articles like ‘the’. Check that ‘write’ is spelled correctly; using ‘write’ as a noun may be non-standard.
Context: ...ctual version stored in the database, the write will fail. This prevents overwriting an...

(A_INFINITIVE)

---

186-191: Section addition approved.

The new section correctly explains time-based conditional writes using HTTP header semantics.

Tools

LanguageTool

[uncategorized] ~188-~188: This expression is usually spelled with a hyphen.
Context: ...using http header semantics. Similar to version based conditional writes this method can be u...

(BASED_HYPHEN)

---

[grammar] ~189-~189: The verb ‘write’ does not usually follow articles like ‘the’. Check that ‘write’ is spelled correctly; using ‘write’ as a noun may be non-standard.
Context: ...ites this method can be used to prevent the write if the target aspect was modified after...

(A_INFINITIVE)

---

192-194: Paragraph addition approved.

The new paragraph correctly explains the use of If-Unmodified-Since header for conditional writes.

Tools

LanguageTool

[uncategorized] ~192-~192: Loose punctuation mark.
Context: ...SO-8601 standard. If-Unmodified-Since: A writer can specify that the aspect mu...

(UNLIKELY_OPENING_PUNCTUATION)

---

195-196: Paragraph addition approved.

The new paragraph correctly explains the use of If-Modified-Since header for conditional writes.

metadata-models/src/main/resources/entity-registry.yml (1)

622-633: LGTM! ConditionalWriteValidator added correctly.

The ConditionalWriteValidator has been properly added to the aspect payload validators.

metadata-service/services/src/main/java/com/linkedin/metadata/entity/EntityService.java (1)

259-273: LGTM! New method getEnvelopedVersionedAspects is well-defined.

The new method getEnvelopedVersionedAspects is added correctly and follows the method conventions in the file.

metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java (2)

392-392: LGTM! New assertion in testValidateImmutableMutation is correct.

The new assertion correctly checks the aspect group key and the exception message.

---

487-487: LGTM! New assertion in testValidateImmutableDelete is correct.

The new assertion correctly checks the aspect group key and the exception message.

docs/api/openapi/openapi-usage-guide.md (1)

586-591: LGTM! New sections for OpenAPI v3 features and conditional writes are clear and informative.

The new sections provide accurate information about OpenAPI v3 features and conditional writes.

docs/how/updating-datahub.md (3)

25-26: Clarify Breaking Change

The description of the breaking change is clear and concise. Ensure that the users are aware of the impact and provide guidance on how to adapt to the new format.

Tools

LanguageTool

[style] ~25-~25: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...value` key and the API is now symmetric with respect to input and outputs. Example Global Tags...

(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)

---

27-39: Ensure Example Accuracy

The example of the previous format for Global Tags Aspect is clear and accurate. Ensure that this format is consistent with the previous implementation.

---

41-55: Ensure Example Accuracy

The example of the new format for Global Tags Aspect with optional fields systemMetadata and headers is clear and accurate. Ensure that this format is consistent with the new implementation.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java (8)

112-113: Ensure Schema Consistency

Ensure that the new schema for "BatchGet" entity requests is consistent with the rest of the schema definitions.

---

135-135: Ensure Endpoint Consistency

Ensure that the new batchGet endpoint is consistent with the other endpoints in terms of structure and functionality.

---

381-388: Ensure Schema Accuracy

Ensure that the schema definition for the batchGet request is accurate and conforms to the expected structure.

---

390-421: Ensure Response Accuracy

Ensure that the response schema for the batchGet request accurately represents the expected response structure.

---

574-597: New Schema for Aspect Request

The addition of systemMetadata and headers to the aspect request schema is correct. Ensure that these new fields are optional and nullable as intended.

---

645-675: New Schema for Entity BatchGet Request

The addition of systemMetadata and headers to the entity batchGet request schema is correct. Ensure that these fields are accurately represented in the schema.

---

738-743: Add Version Parameter

The addition of the version parameter for fetching a specific aspect version is correct. Ensure that this parameter is optional and has a default value of 0.

---

762-762: Add Parameters for Get Operation

The new parameters for the get operation, including systemMetadata and version, are correct. Ensure that these parameters are accurately represented in the OpenAPI specification.

Files that changed from the base of the PR and between a73f076 and e6b9d5e.

• docs/advanced/mcp-mcl.md (4 hunks)
• docs/api/openapi/openapi-usage-guide.md (2 hunks)
• docs/how/updating-datahub.md (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java (1 hunks)
• entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java (1 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java (4 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java (2 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (1 hunks)
• metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/openlineage-converter/build.gradle (1 hunks)
• metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (8 hunks)
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java (7 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java (3 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java (8 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java (4 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java (3 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java (14 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl (1 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl (1 hunks)
• metadata-models/src/main/resources/entity-registry.yml (1 hunks)
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java (2 hunks)
• metadata-service/openapi-entity-servlet/src/main/java/io/datahubproject/openapi/v2/delegates/EntityApiDelegateImpl.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/client/OpenApiClient.java (4 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnRequestV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnResponseV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java (3 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (8 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (4 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java (8 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (5 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (2 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json (1 hunks)
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java (3 hunks)
• metadata-service/services/src/main/java/com/linkedin/metadata/entity/EntityService.java (1 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java (2 hunks)

• metadata-utils/src/main/java/com/linkedin/metadata/utils/metrics/ExceptionUtils.java

• metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java

• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java
• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc
• metadata-integration/java/openlineage-converter/build.gradle
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java
• metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnRequestV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnResponseV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java
• metadata-service/services/src/main/java/com/linkedin/metadata/entity/EntityService.java
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1)

10-11: Ensure proper implementation of interface methods.

The class GenericEntityScrollResultV2 implements GenericEntityScrollResult<GenericAspectV2, GenericEntityV2>. Ensure that all methods required by the interface are correctly implemented.

Verification successful

---

Interface methods correctly implemented

The GenericEntityScrollResult interface does not declare any methods. Therefore, the GenericEntityScrollResultV2 class correctly implements this interface as it stands.

• No methods are required to be implemented by the GenericEntityScrollResultV2 class.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all methods required by the interface are correctly implemented.

# Test: Search for the implemented methods in the class.
rg --type java 'public class GenericEntityScrollResultV2' -A 10

Length of output: 868

---

Script:

#!/bin/bash
# Description: Verify that all methods required by the interface are correctly implemented.

# Search for method declarations in the GenericEntityScrollResult interface
rg --type java 'interface GenericEntityScrollResult' -A 20

# Search for method implementations in the GenericEntityScrollResultV2 class
rg --type java 'public class GenericEntityScrollResultV2' -A 50

Length of output: 1146

entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java (1)

25-32: Ensure proper usage of exception handling.

The new methods forPrecondition handle precondition validation exceptions. Ensure that the exception handling logic is correct and consistent with the rest of the codebase.

Verification successful

---

Verified: Proper usage of forPrecondition methods is consistent with exception handling logic in the codebase.

The new methods forPrecondition in AspectValidationException are correctly and consistently used in the ConditionalWriteValidator.java file to handle precondition failures by creating and returning AspectValidationException.

• Locations:
  • entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the new methods are correctly used in the codebase.

# Test: Search for the usage of the new methods.
rg --type java 'AspectValidationException.forPrecondition'

Length of output: 939

---

Script:

#!/bin/bash
# Description: Inspect the context around the usage of `forPrecondition` in `ConditionalWriteValidator.java`.

# Display lines of code around the usage of `forPrecondition` in `ConditionalWriteValidator.java`.
rg --type java -A 10 -B 10 'AspectValidationException.forPrecondition' entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java

Length of output: 1922

metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2)

29-29: LGTM!

The validation logic ensures that at least one rule exists in DataQualityRules.

---

58-59: LGTM!

The validation logic ensures that the field types of DataQualityRules remain consistent.

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/client/OpenApiClient.java (3)

43-44: LGTM!

The method signature has been correctly updated to use BatchGetUrnRequestV2 and BatchGetUrnResponseV2.

---

51-52: LGTM!

The method signature has been correctly updated to use BatchGetUrnRequestV2 and BatchGetUrnResponseV2.

---

69-70: LGTM!

The method has been correctly updated to deserialize the response to BatchGetUrnResponseV2.

metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java (2)

52-52: LGTM!

The validation logic ensures that at least one rule exists in DataQualityRules.

---

81-82: LGTM!

The validation logic ensures that the field types of DataQualityRules remain consistent.

metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (2)

171-174: LGTM!

The addition of the version field in SystemMetadata aligns with the PR objective of supporting conditional write semantics.

---

180-185: LGTM!

The addition of the headers field aligns with the PR objective of supporting conditional write semantics.

docs/advanced/mcp-mcl.md (2)

179-179: Add a comma after 'updated'.

There is a missing comma after 'updated' in the explanation of If-Version-Match.

- Each time an aspect is updated a `version` is incremented to represent the change to the aspect.
+ Each time an aspect is updated, a `version` is incremented to represent the change to the aspect.

Likely invalid or redundant comment.

---

174-174: Correct noun/verb agreement error.

There seems to be a noun/verb agreement error. The correct sentence should use "writes" instead of "write".

- Conditional write semantics use extra information contained in the MCP `headers` field to possibly avoid writing new aspects
+ Conditional writes semantics use extra information contained in the MCP `headers` field to possibly avoid writing new aspects

Likely invalid or redundant comment.

Tools

LanguageTool

[grammar] ~174-~174: There seems to be a noun/verb agreement error. Did you mean “writes” or “wrote”?
Context: ...es ### Conditional Writes Conditional write semantics use extra information contain...

(SINGULAR_NOUN_VERB_AGREEMENT)

metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (1)

252-252: Correct platform name in config.

The platform field should be set to "gcs" instead of "s3".

- platform("s3")
+ platform("gcs")

Likely invalid or redundant comment.

metadata-models/src/main/resources/entity-registry.yml (1)

622-633: Ensure correct configuration of ConditionalWriteValidator.

The ConditionalWriteValidator is correctly added and configured for various operations.

docs/api/openapi/openapi-usage-guide.md (1)

585-591: Document new OpenAPI v3 features.

The added section documents the new OpenAPI v3 features, particularly the support for conditional writes. This is a necessary addition for clarity.

docs/how/updating-datahub.md (1)

27-56: Document breaking changes and new format for Global Tags Aspect.

The added section documents the breaking changes and the new format for Global Tags Aspect, including optional fields systemMetadata and headers. This is a necessary addition for clarity.

metadata-service/openapi-entity-servlet/src/main/java/io/datahubproject/openapi/v2/delegates/EntityApiDelegateImpl.java (3)

73-74: Approved: Addition of Lombok annotations.

The added Lombok annotations Getter, Setter, and Accessors simplify the code by removing boilerplate getter and setter methods.

Also applies to: 82-82

---

75-75: Approved: Addition of Slf4j annotation.

The Slf4j annotation generates a logger field, which is a standard practice for logging.

---

93-93: Approved: Addition of HttpServletRequest field with Lombok annotations.

The HttpServletRequest field with Lombok's Getter and Setter annotations simplifies access and mutation of the request object.

entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java (19)

1-1: Imports look good.

The necessary classes for testing are correctly imported.

---

2-2: Ensure proper package declaration.

The package declaration is correct and follows the naming conventions.

---

3-7: Static imports and Mockito setup are correct.

The static imports and Mockito setup are correctly used for the test cases.

---

9-35: Class imports and TestNG setup are correct.

The necessary classes for testing, including TestNG annotations, are correctly imported.

---

37-68: Initialization of mock objects and constants.

The mock objects and constants for supported change types and validator configuration are correctly initialized.

---

132-174: Test case testNoSystemMetadataNextVersionNextVersionSuccess looks good.

The test case covers all supported change types and validates that no exceptions are thrown when the previous system metadata is missing.

---

176-237: Test case testNoPreviousVersionsLookupSchemaMetadataNextVersionSuccess looks good.

The test case covers all supported change types and validates that no exceptions are thrown when the previous versions lookup based on schema metadata is successful.

---

239-299: Test case testNoPreviousVersionsLookupVersionNextVersionSuccess looks good.

The test case covers all supported change types and validates that no exceptions are thrown when the previous versions lookup based on version is successful.

---

301-379: Test case testNextVersionFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the expected version does not match the actual version.

---

381-440: Test case testNoSystemMetadataNextVersionNextVersionFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the previous system metadata is missing and the expected version does not match the actual version.

---

442-520: Test case testNoPreviousVersionsLookupSchemaMetadataNextVersionFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the previous versions lookup based on schema metadata fails.

---

522-599: Test case testNoPreviousVersionsLookupVersionNextVersionFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the previous versions lookup based on version fails.

---

601-674: Test case testModifiedSinceSuccess looks good.

The test case covers all supported change types and validates that no exceptions are thrown when the If-Modified-Since and If-Unmodified-Since headers are correctly handled.

---

676-749: Test case testNoPreviousLookupAuditStampModifiedSinceSuccess looks good.

The test case covers all supported change types and validates that no exceptions are thrown when the previous lookup based on audit stamp is successful.

---

751-836: Test case testModifiedSinceBeforeRangeFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the If-Modified-Since header is before the modification range.

---

838-923: Test case testModifiedSinceAfterRangeFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the If-Modified-Since header is after the modification range.

---

925-1010: Test case testNoPreviousLookupAuditStampModifiedSinceBeforeRangeFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the previous lookup based on audit stamp is before the modification range.

---

1012-1097: Test case testNoPreviousLookupAuditStampModifiedSinceAfterRangeFail looks good.

The test case covers all supported change types and validates that exceptions are thrown when the previous lookup based on audit stamp is after the modification range.

---

70-130: Test case testNextVersionSuccess looks good.

The test case covers all supported change types and validates that no exceptions are thrown when the expected version matches the actual version.

However, ensure that the ConditionalWriteValidator handles all edge cases correctly.

Files that changed from the base of the PR and between e6b9d5e and 5d9a518.

• docs/advanced/mcp-mcl.md (4 hunks)
• docs/api/openapi/openapi-usage-guide.md (2 hunks)
• docs/how/updating-datahub.md (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java (2 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java (1 hunks)
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java (1 hunks)
• entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java (1 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java (4 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java (2 hunks)
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (1 hunks)
• metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc (1 hunks)
• metadata-integration/java/openlineage-converter/build.gradle (1 hunks)
• metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (8 hunks)
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java (7 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java (3 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java (2 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java (8 hunks)
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java (4 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java (3 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java (14 hunks)
• metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl (1 hunks)
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl (1 hunks)
• metadata-models/src/main/resources/entity-registry.yml (1 hunks)
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java (2 hunks)
• metadata-service/openapi-entity-servlet/src/main/java/io/datahubproject/openapi/v2/delegates/EntityApiDelegateImpl.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/client/OpenApiClient.java (4 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnRequestV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnResponseV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java (2 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java (1 hunks)
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java (3 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (8 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (4 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java (8 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (5 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (2 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json (1 hunks)
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json (1 hunks)
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java (3 hunks)
• metadata-service/services/src/main/java/com/linkedin/metadata/entity/EntityService.java (1 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java (2 hunks)

• metadata-utils/src/main/java/com/linkedin/metadata/utils/metrics/ExceptionUtils.java

• metadata-io/src/test/java/com/linkedin/metadata/structuredproperties/validators/StructuredPropertiesValidatorTest.java
• metadata-models/src/main/resources/entity-registry.yml

• entity-registry/src/main/java/com/linkedin/metadata/aspect/AspectRetriever.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/EnvelopedSystemAspect.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/SystemAspect.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/batch/MCPItem.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/AspectValidationException.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/validation/ValidationExceptionCollection.java
• entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/ConditionalWriteValidator.java
• entity-registry/src/test/java/com/linkedin/metadata/aspect/validators/ConditionalWriteValidatorTest.java
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/MockAspectRetriever.java
• entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestMCP.java
• metadata-integration/java/datahub-event/src/main/resources/MetadataChangeProposal.avsc
• metadata-integration/java/openlineage-converter/build.gradle
• metadata-io/metadata-io-api/src/main/java/com/linkedin/metadata/entity/ebean/batch/ChangeItemImpl.java
• metadata-io/src/main/java/com/linkedin/metadata/aspect/utils/DefaultAspectsUtil.java
• metadata-io/src/main/java/com/linkedin/metadata/client/EntityClientAspectRetriever.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceAspectRetriever.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityServiceImpl.java
• metadata-io/src/main/java/com/linkedin/metadata/entity/EntityUtils.java
• metadata-io/src/test/java/com/linkedin/metadata/AspectGenerationUtils.java
• metadata-io/src/test/java/com/linkedin/metadata/entity/EntityServiceTest.java
• metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/spring/validation/CustomDataQualityRulesValidator.java
• metadata-models/src/main/pegasus/com/linkedin/mxe/MetadataChangeProposal.pdl
• metadata-models/src/main/pegasus/com/linkedin/mxe/SystemMetadata.pdl
• metadata-operation-context/src/main/java/io/datahubproject/test/metadata/context/TestOperationContexts.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/client/OpenApiClient.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericAspect.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntity.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/models/GenericEntityScrollResult.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnRequestV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericAspectV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityScrollResultV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/GenericEntityV2.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericAspectV3.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollResultV3.java
• metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityV3.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json
• metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json
• metadata-service/restli-client-api/src/main/java/com/linkedin/entity/client/EntityClient.java
• metadata-service/services/src/main/java/com/linkedin/metadata/entity/EntityService.java
• metadata-utils/src/main/java/com/linkedin/metadata/utils/GenericRecordUtils.java

metadata-service/openapi-servlet/models/src/main/java/io/datahubproject/openapi/v2/models/BatchGetUrnResponseV2.java (1)

Line range hint 1-19:
LGTM! The class structure and annotations are well-defined.

The BatchGetUrnResponseV2 class uses generics and appropriate annotations for JSON serialization and API documentation.

entity-registry/src/testFixtures/java/com/linkedin/test/metadata/aspect/batch/TestSystemAspect.java (1)

1-26: LGTM! The class structure and Lombok annotations are well-defined.

The TestSystemAspect class correctly implements SystemAspect and uses Lombok annotations to reduce boilerplate code.

metadata-models-custom/src/main/java/com/linkedin/metadata/aspect/plugins/validation/CustomDataQualityRulesValidator.java (2)

28-29: LGTM! The validation logic ensures at least one rule is present.

The validateProposedAspects method is well-structured and correctly enforces at least one rule in DataQualityRules.

---

58-59: LGTM! The validation logic ensures field type consistency.

The validatePreCommitAspects method is well-structured and correctly enforces field type consistency in DataQualityRules.

metadata-integration/java/datahub-client/src/main/resources/MetadataChangeProposal.avsc (2)

170-174: LGTM! The addition of the version field is well-structured.

The version field in SystemMetadata is correctly added with a detailed description and default value.

---

180-185: LGTM! The addition of the headers field is well-structured.

The headers field in MetadataChangeProposal is correctly added with a detailed description and default value.

docs/advanced/mcp-mcl.md (3)

63-66: Addition of headers field is correct.

The addition of the headers field in the MetadataChangeProposal PDL model aligns with the PR objectives and is well-documented.

---

70-70: Inclusion of headers field in proposal components is correct.

The headers field has been correctly added to the list of proposal components.

---

118-121: Explanation of headers field is clear and correct.

The explanation for the headers field in the documentation is clear and aligns with the PR objectives for supporting conditional write semantics.

metadata-integration/java/openlineage-converter/src/test/java/io/datahubproject/openlineage/HdfsPathDatasetTest.java (4)

16-17: Addition of TestNG imports is correct.

The imports for Assert and Test from TestNG have been correctly added.

---

45-45: Addition of env field is correct.

The env field has been correctly added to the PathSpec builder in the testPathSpecList test case.

---

92-92: Addition of env field is correct.

The env field has been correctly added to the PathSpec builder in the testNoMatchPathSpecList test case.

---

124-124: Addition of env field is correct.

The env field has been correctly added to the PathSpec builder in the testPathSpecListPlatformInstance test case.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (4)

3-5: Addition of imports is correct.

The imports for ConditionalWriteValidator and ApiOperation.READ have been correctly added.

---

33-36: Addition of imports is correct.

The imports for OperationContext, RequestContext, and InvalidUrnException have been correctly added.

---

71-109: Addition of getEntityBatch method is correct.

The getEntityBatch method has been correctly added to support batch retrieval of entities. The method includes necessary checks and logic for handling batch requests.

---

201-255: Addition of toEntityVersionRequest method is correct.

The toEntityVersionRequest method has been correctly added to parse entity version requests. The method includes necessary logic for parsing and validating entity version requests.

docs/api/openapi/openapi-usage-guide.md (1)

585-591: Addition of OpenAPI v3 Features section is correct.

The new section provides a comprehensive explanation of the OpenAPI v3 features and their usage, aligning with the PR objectives.

docs/how/updating-datahub.md (1)

26-56: LGTM!

The example clearly illustrates the changes in the Global Tags Aspect format.

metadata-service/openapi-entity-servlet/src/main/java/io/datahubproject/openapi/v2/delegates/EntityApiDelegateImpl.java (3)

73-75: LGTM!

The Lombok annotations @Getter, @Setter, and @Accessors(chain = true) improve code readability and maintainability.

---

Line range hint 82-93:
LGTM!

The class EntityApiDelegateImpl is well-structured, and the constructor initializes the fields appropriately.

---

93-93: LGTM!

The @Setter and @Getter annotations on the request field are consistent with the rest of the class.