Page MenuHomePhabricator
Create Task
Maniphest T89060

VisualEditor is not the editor linked from the diff page
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

At the top of a diff, it gives the date followed by actions: (edit) (undo) (thank)

It is not possible to use VisualEditor from this section. "(edit)" leads to the wikitext editor. Should the option be added (extra clutter, less surprising behavior)? Should the "(edit)" label be changed to "(edit source)"?

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT120966 On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly
 ResolvedKrenairT120965 On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option
 ResolvedKrenairT120969 On single edit tab wikis, if the user has a 'wt always' preference, action=edit gives a blank page
 ResolvedKrenairT120970 On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces
 ResolvedKrenairT120978 On single edit tab wikis, if the user navigates straight to 'veaction=edit' without clicking and they don't have a editor preference cookie, nothing happens (they just get a read page)
 ResolvedKrenairT121122 On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option
 ResolvedKrenairT121126 On single edit tab wikis, 'undo' links in history when editor will be VE don't work
 ResolvedKrenairT120987 Switching to edit source giving blank page when I have option "Show me both editors"
 ResolvedKrenairT121189 On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting
 ResolvedKrenairT121257 On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it
 ResolvedKrenairT121298 On single edit tab wikis, if your browser is not supported but your settings (or default) says VE you get a blank edit page and no way to fix it
 ResolvedKrenairT121343 SingleEditTab: Exception thrown switching from VE to WE while logged out
 ResolvedKrenairT121342 With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading
 ResolvedKrenairT121460 On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set
 ResolvedKrenairT121599 On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE"
 ResolvedKrenairT123457 On single edit tab wikis, if your browser runs JS but is only grade C supported (no MW JS) you probably get a blank edit page and no way to fix it
 ResolvedKrenairT124316 On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again
 ResolvedPRODUCTION ERRORKrenairT124264 Notice: Undefined index: 1 in /srv/mediawiki/php-1.27.0-wmf.11/extensions/VisualEditor/VisualEditor.hooks.php on line 83
 ResolvedKrenairT124650 On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit
 ResolvedKrenairT124743 On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE
 ResolvedKrenairT124652 Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"
 Declined• Whatamidoing-WMFT122389 Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only)
 ResolvedKrenairT124708 Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page
 ResolvedKrenairT125670 VisualEditor SET doesn't set the <title> element
 InvalidKrinkleT125864 Fix the broken JS getCookie() call, which sets a cookie not recognised by the server
 ResolvedKrenairT125998 In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen
 ResolvedKrenairT126145 When CustomEditor is used, the EditPage robot policy isn't loaded
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page

Event Timeline

• Whatamidoing-WMF created this task.Feb 9 2015, 11:31 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added a project: VisualEditor.
• Whatamidoing-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2015, 11:31 PM
Jdforrester-WMF renamed this task from VisualEditor is not available from the diff page to VisualEditor is not the editor linked from the diff page.Feb 11 2015, 5:51 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
Jdforrester-WMF subscribed.

Related to T55441: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Feb 11 2015, 5:52 PM
• Elitre subscribed.Feb 25 2015, 5:06 PM
Krenair subscribed.Jul 14 2015, 12:25 AM

Surely we'd have more of these 'edit link not to VE' tasks laying around? Let's make T55441 more generic and merge this in?

Krenair added a comment.Jul 14 2015, 12:27 AM

And also T78550: The undo link in the page history leads to the source editor and not VisualEditor

Jdforrester-WMF added a subtask: T114531: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation.Oct 2 2015, 8:58 PM
Jdforrester-WMF closed this task as Resolved.Feb 16 2016, 4:57 PM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF removed a subtask: T114531: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation.
Jdforrester-WMF added a parent task: T114531: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation.
Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Feb 16 2016, 5:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits