Page MenuHomePhabricator
Create Task
Maniphest T120966

On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When you section edit into WT, the editor's switch button just brings you back to the editor the first time (but then works the second time).

Details

SubjectRepoBranchLines +/-
Remember switching into VE from WT when discarding changesmediawiki/extensions/VisualEditormaster+8 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT265163 Create a system to encode best practices into editing experiences
 OpenTrizek-WMFT331946 [RELEASE TICKET] Make Edit Check (references) available to all newcomers at all Wikipedias
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT120966 On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly

Event Timeline

Jdforrester-WMF created this task.Dec 9 2015, 5:02 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor.
Jdforrester-WMF added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.
Jdforrester-WMF added subscribers: Aklapper, Jdforrester-WMF.
Jdforrester-WMF mentioned this in T121189: On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting.Dec 11 2015, 3:28 AM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Krenair claimed this task.Dec 11 2015, 1:34 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 11 2015, 7:34 PM
Krenair added a comment.Dec 11 2015, 10:42 PM

Is this consistently reproducible? By 'back to the editor' you mean back into VE?

Krenair added a comment.Dec 11 2015, 10:53 PM

I think I misunderstood a bit, but it still works for me...

Krenair added a comment.Dec 11 2015, 11:21 PM

I said that, and then when I was testing something else I reproduced the exact issue.

Krenair added a comment.Dec 11 2015, 11:34 PM

looks like it is happening when when you try to switch from WT to VE and have the single edit tab preference of remember-last and one of the following is true:

  • You made no changes and were not on action=submit
  • You made changes but opted to discard them (likely if you were section editing)
Jdforrester-WMF added a comment.Dec 11 2015, 11:36 PM
In T120966#1874673, @Krenair wrote:

looks like it is happening when when you try to switch from WT to VE and have the single edit tab preference of remember-last and one of the following is true:

  • You made no changes and were not on action=submit
  • You made changes but opted to discard them (likely if you were section editing)

That sounds likely to be my failure issues, yes.

gerritbot subscribed.Dec 11 2015, 11:39 PM

Change 258643 had a related patch set uploaded (by Alex Monk):
Remember switching into VE from WT when discarding changes

https://gerrit.wikimedia.org/r/258643

gerritbot added a project: Patch-For-Review.Dec 11 2015, 11:39 PM
Jdforrester-WMF closed this task as Resolved.Dec 12 2015, 12:26 AM

Provisionally assuming fixed.

gerritbot added a comment.Dec 12 2015, 12:28 AM

Change 258643 merged by jenkins-bot:
Remember switching into VE from WT when discarding changes

https://gerrit.wikimedia.org/r/258643

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 12 2015, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits