Page MenuHomePhabricator
Create Task
Maniphest T121122

On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

AFAICT it sometimes, but not always, successfully sets this on switching from VE to WT. It seems to always work from WT to VE.

Details

SubjectRepoBranchLines +/-
Single Edit Tab: Set switch editor preference via sessionStorage/promisemediawiki/extensions/VisualEditormaster+67 -23
Try to actually resolve visualeditor-editor preference setting when switching editorsmediawiki/extensions/VisualEditormaster+18 -11
DesktopArticleTarget: Don't abort in SET mode if veswitched is setmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT265163 Create a system to encode best practices into editing experiences
 OpenTrizek-WMFT331946 [RELEASE TICKET] Make Edit Check (references) available to all newcomers at all Wikipedias
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT121122 On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option

Event Timeline

Jdforrester-WMF created this task.Dec 10 2015, 5:49 PM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki, Browser-Support-Apple-Safari.
Jdforrester-WMF added a subscriber: Aklapper.
Jdforrester-WMF renamed this task from On single edit tab wikis, the edit tab always loads VE even if the 'VEE' cookie is 'wikitext' to On single edit tab wikis, switching editors is not always setting the visualeditor-editor option to 'wikitext' in Safari, Firefox.Dec 10 2015, 5:59 PM
Jdforrester-WMF added a project: Browser-Support-Firefox.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 11 2015, 1:55 AM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF renamed this task from On single edit tab wikis, switching editors is not always setting the visualeditor-editor option to 'wikitext' in Safari, Firefox to On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option.Dec 11 2015, 3:27 AM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF removed projects: Browser-Support-Firefox, Browser-Support-Apple-Safari.
Krenair added a comment.Dec 11 2015, 10:56 PM

I noticed you removed the FF/Safari tags... Does this mean you reproduced it in a browser like Chrome?
I wonder if the request to store the preference does not always make it through in time in this case? Can you reproduce this with the cookie instead of the visualeditor-editor preference?

Jdforrester-WMF subscribed.Dec 11 2015, 10:59 PM
In T121122#1874556, @Krenair wrote:

I noticed you removed the FF/Safari tags... Does this mean you reproduced it in a browser like Chrome?
I wonder if the request to store the preference does not always make it through in time in this case? Can you reproduce this with the cookie instead of the visualeditor-editor preference?

Yup, reproduced when logged in in Chrome as well; it works fine when logged out, so I imagine user preferences aren't being set reliably in time?

gerritbot subscribed.Dec 12 2015, 2:15 AM

Change 258660 had a related patch set uploaded (by Jforrester):
DesktopArticleTarget: Don't abort in SET mode if veswitched is set

https://gerrit.wikimedia.org/r/258660

gerritbot added a project: Patch-For-Review.Dec 12 2015, 2:15 AM
Krenair reassigned this task from Krenair to Jdforrester-WMF.Dec 14 2015, 4:41 PM
Krenair subscribed.
gerritbot added a comment.Dec 14 2015, 4:46 PM

Change 258660 merged by jenkins-bot:
DesktopArticleTarget: Don't abort in SET mode if veswitched is set

https://gerrit.wikimedia.org/r/258660

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 14 2015, 5:00 PM
Krenair added a comment.Dec 14 2015, 5:40 PM

I think this can be closed, please check

Krenair claimed this task.Dec 14 2015, 6:37 PM

Still seems broken in beta

gerritbot added a comment.Dec 14 2015, 11:21 PM

Change 259165 had a related patch set uploaded (by Jforrester):
Single Edit Tab: Set switch editor preference via sessionStorage/promise

https://gerrit.wikimedia.org/r/259165

gerritbot added a comment.Dec 15 2015, 5:32 PM

Change 259286 had a related patch set uploaded (by Alex Monk):
Try to actually resolve visualeditor-editor preference setting when switching editors

https://gerrit.wikimedia.org/r/259286

gerritbot added a comment.Dec 15 2015, 6:35 PM

Change 259286 merged by jenkins-bot:
Try to actually resolve visualeditor-editor preference setting when switching editors

https://gerrit.wikimedia.org/r/259286

Jdforrester-WMF closed this task as Resolved.Dec 15 2015, 7:47 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 17 2015, 1:00 PM

Change 259165 abandoned by Alex Monk:
Single Edit Tab: Set switch editor preference via sessionStorage/promise

Reason:
issue was fixed by a different commit

https://gerrit.wikimedia.org/r/259165

DLynch mentioned this in T133758: Loading of editor should not be blocked on the editor preference getting saved.Aug 25 2016, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits