Skip to content

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Dec 12, 2025

[ghstack-poisoned]
@seemethere seemethere requested a review from a team as a code owner December 12, 2025 01:47
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170272

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2af0f14 with merge base 8ebbfb1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
[ghstack-poisoned]
@seemethere seemethere changed the title ci: Use uv pip install to install pip ci: Use uv tool install to install pip Dec 12, 2025
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #170267

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #170267

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #170270

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #170267

pytorchmergebot pushed a commit that referenced this pull request Dec 12, 2025
Add a composite action that detects whether the current runner has a TPU
connected. Uses tpu-info library to query local TPU chips via PCI device
scanning. Outputs `has_tpu` as true/false for use in workflow conditionals.

Requires setup-linux to have been run first (for uv availability).

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: #170269
Approved by: https://github.com/oulgen
ghstack dependencies: #170272
pytorchmergebot pushed a commit that referenced this pull request Dec 12, 2025
These are needed in order to ensure that TPUs can work correctly in our
DinD setup.

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: #170270
Approved by: https://github.com/oulgen
ghstack dependencies: #170272, #170269
pytorchmergebot pushed a commit that referenced this pull request Dec 12, 2025
has_profile check wasn't working which explains the ROCm issues with
oidc.

Also removes the cross-account login. I did a sweep and I don't think we
maintain an ECR on the lf account so this isn't actually needed

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: #170267
Approved by: https://github.com/huydhn, https://github.com/zxiiro
ghstack dependencies: #170272, #170269, #170270
vishalgoyal316 pushed a commit to vishalgoyal316/pytorch that referenced this pull request Dec 17, 2025
`uv run` actually attempts to build all of pytorch so we shouldn't do
that just to install pip

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: pytorch#170272
Approved by: https://github.com/oulgen
vishalgoyal316 pushed a commit to vishalgoyal316/pytorch that referenced this pull request Dec 17, 2025
Add a composite action that detects whether the current runner has a TPU
connected. Uses tpu-info library to query local TPU chips via PCI device
scanning. Outputs `has_tpu` as true/false for use in workflow conditionals.

Requires setup-linux to have been run first (for uv availability).

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: pytorch#170269
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#170272
vishalgoyal316 pushed a commit to vishalgoyal316/pytorch that referenced this pull request Dec 17, 2025
These are needed in order to ensure that TPUs can work correctly in our
DinD setup.

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: pytorch#170270
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#170272, pytorch#170269
vishalgoyal316 pushed a commit to vishalgoyal316/pytorch that referenced this pull request Dec 17, 2025
has_profile check wasn't working which explains the ROCm issues with
oidc.

Also removes the cross-account login. I did a sweep and I don't think we
maintain an ECR on the lf account so this isn't actually needed

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: pytorch#170267
Approved by: https://github.com/huydhn, https://github.com/zxiiro
ghstack dependencies: pytorch#170272, pytorch#170269, pytorch#170270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants