ci: Ensure we pass through TPU env variables (REDO) #170270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170270
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 85645e9 with merge base 8ebbfb1 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
seemethere
added a commit
that referenced
this pull request
Dec 12, 2025
These are needed in order to ensure that TPUs can work correctly in our DinD setup. Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 3734e4e Pull-Request: #170270
oulgen
approved these changes
Dec 12, 2025
Collaborator
|
Starting merge as part of PR stack under #170267 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #170267 |
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx942.1) Details for Dev Infra teamRaised by workflow job |
Collaborator
|
Starting merge as part of PR stack under #170267 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 12, 2025
has_profile check wasn't working which explains the ROCm issues with oidc. Also removes the cross-account login. I did a sweep and I don't think we maintain an ECR on the lf account so this isn't actually needed Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: #170267 Approved by: https://github.com/huydhn, https://github.com/zxiiro ghstack dependencies: #170272, #170269, #170270
vishalgoyal316
pushed a commit
to vishalgoyal316/pytorch
that referenced
this pull request
Dec 17, 2025
These are needed in order to ensure that TPUs can work correctly in our DinD setup. Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: pytorch#170270 Approved by: https://github.com/oulgen ghstack dependencies: pytorch#170272, pytorch#170269
vishalgoyal316
pushed a commit
to vishalgoyal316/pytorch
that referenced
this pull request
Dec 17, 2025
has_profile check wasn't working which explains the ROCm issues with oidc. Also removes the cross-account login. I did a sweep and I don't think we maintain an ECR on the lf account so this isn't actually needed Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: pytorch#170267 Approved by: https://github.com/huydhn, https://github.com/zxiiro ghstack dependencies: pytorch#170272, pytorch#170269, pytorch#170270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These are needed in order to ensure that TPUs can work correctly in our
DinD setup.
Signed-off-by: Eli Uriegas [email protected]