Skip to content

ci: Fix has_profile check, remove cross-account #170267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seemethere wants to merge 5 commits into from
Closed

ci: Fix has_profile check, remove cross-account #170267

seemethere wants to merge 5 commits into from

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Dec 12, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

has_profile check wasn't working which explains the ROCm issues with
oidc.

Also removes the cross-account login. I did a sweep and I don't think we
maintain an ECR on the lf account so this isn't actually needed

Signed-off-by: Eli Uriegas [email protected]

@seemethere
Update
e5d9747 
[ghstack-poisoned]
@seemethere seemethere requested a review from a team as a code owner December 12, 2025 01:04
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170267

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 6 Pending

As of commit 9557363 with merge base 8ebbfb1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 12, 2025
seemethere added a commit that referenced this pull request Dec 12, 2025
@seemethere
ci: Fix has_profile check, remove cross-account
5e58e06 
has_profile check wasn't working which explains the ROCm issues with
oidc.

Also removes the cross-account login. I did a sweep and I don't think we
maintain an ECR on the lf account so this isn't actually needed

Signed-off-by: Eli Uriegas <[email protected]>
ghstack-source-id: dbed6c3
Pull-Request: #170267
@seemethere
Update
8b72393 
[ghstack-poisoned]
This was referenced Dec 12, 2025
Closed
Closed
Closed
Draft
@seemethere
Update
e56d009 
[ghstack-poisoned]
@seemethere
Update
03b5843 
[ghstack-poisoned]
@seemethere seemethere added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 12, 2025
@seemethere
Copy link
Member Author

seemethere commented Dec 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@seemethere
Update
9557363 
[ghstack-poisoned]
@seemethere
Copy link
Member Author

seemethere commented Dec 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2025

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 5, 6, linux.rocm.gpu.gfx942.1)

Details for Dev Infra team Raised by workflow job

@seemethere
Copy link
Member Author

seemethere commented Dec 12, 2025

@pytorchbot merge -f 'verified with AMD team that rocm failures were not relevant here'

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

vishalgoyal316 pushed a commit to vishalgoyal316/pytorch that referenced this pull request Dec 17, 2025
@seemethere @vishalgoyal316
ci: Fix has_profile check, remove cross-account (pytorch#170267)
d92e5d5 
has_profile check wasn't working which explains the ROCm issues with
oidc.

Also removes the cross-account login. I did a sweep and I don't think we
maintain an ECR on the lf account so this isn't actually needed

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: pytorch#170267
Approved by: https://github.com/huydhn, https://github.com/zxiiro
ghstack dependencies: pytorch#170272, pytorch#170269, pytorch#170270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zxiiro zxiiro zxiiro approved these changes

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seemethere @pytorchmergebot @zxiiro @huydhn