Skip to content

Implement hovertemplate for candlestick and ohlc traces #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 10 commits into from
Nov 13, 2025
+827 −641
Merged

Implement hovertemplate for candlestick and ohlc traces #7619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06ece4b
run formatter
emilykl Nov 12, 2025
237925d
implement hovertemplate for ohlc and candlestick traces
emilykl Nov 12, 2025
bb13493
add jasmine test for hovertemplate for ohlc and candlestick traces
emilykl Nov 12, 2025
417a035
update schema
emilykl Nov 12, 2025
68bd668
update hoverlabel.split docstring
emilykl Nov 12, 2025
5dddc9b
formatting
emilykl Nov 12, 2025
a1c0e8b
Apply suggestions from code review
emilykl Nov 12, 2025
ec46856
add test for candlestick/ohlc hovertemplate and split mode
emilykl Nov 12, 2025
6800433
fix split mode hover (remove outdated logic)
emilykl Nov 12, 2025
fb6e114
add draftlog
emilykl Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Cameron DeCoster <[email protected]>
  • Loading branch information
@emilykl @camdecoster
emilykl and camdecoster authored Nov 12, 2025
commit a1c0e8bb5f8635cf421d5d8af08813789488fb87
2 changes: 1 addition & 1 deletion src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,7 +1665,7 @@ function getHoverLabelText(d, showCommonLabel, hovermode, fullLayout, t0, g) {
// Ignore hovertemplate if hoverlabel.split is set
// This ensures correct behavior of hoverlabel.split for candlestick and OHLC traces
// Not very elegant but it works
if (d.trace?.hoverlabel?.split) d.hovertemplate = false;
if (d.trace?.hoverlabel?.split) d.hovertemplate = '';

const { hovertemplate = false } = d;
if (hovertemplate) {
Expand Down
2 changes: 0 additions & 2 deletions src/traces/candlestick/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

var extendFlat = require('../../lib').extendFlat;
var axisHoverFormat = require('../../plots/cartesian/axis_format_attributes').axisHoverFormat;
var hovertemplateAttrs = require('../../plots/template_attributes').hovertemplateAttrs;
var templatefallbackAttrs = require('../../plots/template_attributes').templatefallbackAttrs;
var OHLCattrs = require('../ohlc/attributes');
var boxAttrs = require('../box/attributes');

Expand Down
4 changes: 1 addition & 3 deletions src/traces/ohlc/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@

var extendFlat = require('../../lib').extendFlat;
var scatterAttrs = require('../scatter/attributes');
var baseAttrs = require('../../plots/attributes');
var axisHoverFormat = require('../../plots/cartesian/axis_format_attributes').axisHoverFormat;
var hovertemplateAttrs = require('../../plots/template_attributes').hovertemplateAttrs;
var templatefallbackAttrs = require('../../plots/template_attributes').templatefallbackAttrs;
const { hovertemplateAttrs, templatefallbackAttrs } = require('../../plots/template_attributes');
var dash = require('../../components/drawing/attributes').dash;
var fxAttrs = require('../../components/fx/attributes');
var delta = require('../../constants/delta.js');
Expand Down