Skip to content

Implement hovertemplate for candlestick and ohlc traces #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 10 commits into from
Nov 13, 2025
+827 −641
Merged

Implement hovertemplate for candlestick and ohlc traces #7619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06ece4b
run formatter
emilykl Nov 12, 2025
237925d
implement hovertemplate for ohlc and candlestick traces
emilykl Nov 12, 2025
bb13493
add jasmine test for hovertemplate for ohlc and candlestick traces
emilykl Nov 12, 2025
417a035
update schema
emilykl Nov 12, 2025
68bd668
update hoverlabel.split docstring
emilykl Nov 12, 2025
5dddc9b
formatting
emilykl Nov 12, 2025
a1c0e8b
Apply suggestions from code review
emilykl Nov 12, 2025
ec46856
add test for candlestick/ohlc hovertemplate and split mode
emilykl Nov 12, 2025
6800433
fix split mode hover (remove outdated logic)
emilykl Nov 12, 2025
fb6e114
add draftlog
emilykl Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
run formatter
  • Loading branch information
@emilykl
emilykl committed Nov 12, 2025
commit 06ece4b4b8360ccddd80be87ad7828f6a4700513
2 changes: 1 addition & 1 deletion src/traces/candlestick/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var boxAttrs = require('../box/attributes');
function directionAttrs(lineColorDefault) {
return {
line: {
color: extendFlat({}, boxAttrs.line.color, {dflt: lineColorDefault}),
color: extendFlat({}, boxAttrs.line.color, { dflt: lineColorDefault }),
width: boxAttrs.line.width,
editType: 'style'
},
Expand Down
4 changes: 2 additions & 2 deletions src/traces/candlestick/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
}

var len = handleOHLC(traceIn, traceOut, coerce, layout);
if(!len) {
if (!len) {
traceOut.visible = false;
return;
}

handlePeriodDefaults(traceIn, traceOut, layout, coerce, {x: true});
handlePeriodDefaults(traceIn, traceOut, layout, coerce, { x: true });
coerce('xhoverformat');
coerce('yhoverformat');

Expand Down
20 changes: 5 additions & 15 deletions src/traces/ohlc/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var lineAttrs = scatterAttrs.line;
function directionAttrs(lineColorDefault) {
return {
line: {
color: extendFlat({}, lineAttrs.color, {dflt: lineColorDefault}),
color: extendFlat({}, lineAttrs.color, { dflt: lineColorDefault }),
width: lineAttrs.width,
dash: dash,
editType: 'style'
Expand All @@ -25,7 +25,6 @@ function directionAttrs(lineColorDefault) {
}

module.exports = {

xperiod: scatterAttrs.xperiod,
xperiod0: scatterAttrs.xperiod0,
xperiodalignment: scatterAttrs.xperiodalignment,
Expand All @@ -35,10 +34,7 @@ module.exports = {
x: {
valType: 'data_array',
editType: 'calc+clearAxisTypes',
description: [
'Sets the x coordinates.',
'If absent, linear coordinate will be generated.'
].join(' ')
description: ['Sets the x coordinates.', 'If absent, linear coordinate will be generated.'].join(' ')
},

open: {
Expand Down Expand Up @@ -99,7 +95,7 @@ module.exports = {
'If a single string, the same string appears over',
'all the data points.',
'If an array of string, the items are mapped in order to',
'this trace\'s sample points.'
"this trace's sample points."
].join(' ')
},
hovertext: {
Expand All @@ -116,21 +112,15 @@ module.exports = {
max: 0.5,
dflt: 0.3,
editType: 'calc',
description: [
'Sets the width of the open/close tick marks',
'relative to the *x* minimal interval.'
].join(' ')
description: ['Sets the width of the open/close tick marks', 'relative to the *x* minimal interval.'].join(' ')
},

hoverlabel: extendFlat({}, fxAttrs.hoverlabel, {
split: {
valType: 'boolean',
dflt: false,
editType: 'style',
description: [
'Show hover information (open, close, high, low) in',
'separate labels.'
].join(' ')
description: ['Show hover information (open, close, high, low) in', 'separate labels.'].join(' ')
}
}),

Expand Down
4 changes: 2 additions & 2 deletions src/traces/ohlc/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
}

var len = handleOHLC(traceIn, traceOut, coerce, layout);
if(!len) {
if (!len) {
traceOut.visible = false;
return;
}

handlePeriodDefaults(traceIn, traceOut, layout, coerce, {x: true});
handlePeriodDefaults(traceIn, traceOut, layout, coerce, { x: true });
coerce('xhoverformat');
coerce('yhoverformat');

Expand Down
Loading