Skip to content

Implement hovertemplate for candlestick and ohlc traces #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 10 commits into from
Nov 13, 2025
+827 −641
Merged

Implement hovertemplate for candlestick and ohlc traces #7619

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06ece4b
run formatter
emilykl Nov 12, 2025
237925d
implement hovertemplate for ohlc and candlestick traces
emilykl Nov 12, 2025
bb13493
add jasmine test for hovertemplate for ohlc and candlestick traces
emilykl Nov 12, 2025
417a035
update schema
emilykl Nov 12, 2025
68bd668
update hoverlabel.split docstring
emilykl Nov 12, 2025
5dddc9b
formatting
emilykl Nov 12, 2025
a1c0e8b
Apply suggestions from code review
emilykl Nov 12, 2025
ec46856
add test for candlestick/ohlc hovertemplate and split mode
emilykl Nov 12, 2025
6800433
fix split mode hover (remove outdated logic)
emilykl Nov 12, 2025
fb6e114
add draftlog
emilykl Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix split mode hover (remove outdated logic)
  • Loading branch information
@emilykl
emilykl committed Nov 13, 2025
commit 680043343e910fe14fbe94353be4c18609def7df
13 changes: 4 additions & 9 deletions src/traces/ohlc/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,11 @@ function hoverSplit(pointData, xval, yval, hovermode) {
// skip the rest (for this trace) if we didn't find a close point
if(!closestPoint) return [];

var cdIndex = closestPoint.index;
var di = cd[cdIndex];
var hoverinfo = di.hi || trace.hoverinfo;
var hoverParts = hoverinfo.split('+');
var isAll = hoverinfo === 'all';
var hasY = isAll || hoverParts.indexOf('y') !== -1;
var di = cd[closestPoint.index];
var hoverinfo = di.hi || trace.hoverinfo || '';

// similar to hoverOnPoints, we return nothing
// if all or y is not present.
if(!hasY) return [];
// If hoverinfo is 'none' or 'skip', we don't show any hover labels
if (hoverinfo === 'none' || hoverinfo === 'skip') return [];

var attrs = ['high', 'open', 'close', 'low'];

Expand Down