Github Actions revamp: tickets/DM-42231C #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to make artifacts at ghcr.io useful, someone with admin privileges on the GitHub Datopian Org will need to allow these packages to be public: cf. https://github.com/orgs/community/discussions/26014 |
This was referenced Jan 15, 2024
|
#130 is merged ... PS: sorry for slow responses this week - again offline quite a bit. feel free to ping @anuveyatsu to ask him to merge! |
athornton
force-pushed
the
tickets/DM-42231C
branch
from
c733b7d to
6c813fd
Compare
|
Rebased and ready for review by @anuveyatsu . |
demenech
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
LGTM. Merging this and will check with admins about how we can make the artifacts public.
CC: @anuveyatsu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be rebased once #130 is merged. Replacement for #134 that doesn't cross forks, to see if that gets the ghcr.io push working.
To get PyPi uploads working, Datopian will need to set up a PyPi Trusted Publisher as described in https://docs.pypi.org/trusted-publishers/ ; the environment name should be
pypi.