mock Google Cloud Storage: tickets/DM-42231D #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
force-pushed
the
tickets/DM-42231D
branch
from
9c424f0 to
4ae3caf
Compare
|
Addresses more of #126 |
athornton
force-pushed
the
tickets/DM-42231D
branch
from
4ae3caf to
812c519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple mock for the Google Cloud Storage tests. Should be rebased once #135 is merged.
It's not a very good one: better would be mocking the actual http responses from the client, but that's a much trickier proposition.