Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isort/flake8/black with ruff: tickets/DM-42231B #130

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Replace isort/flake8/black with ruff: tickets/DM-42231B #130

merged 4 commits into from
Jan 16, 2024

Conversation

athornton
Copy link
Collaborator

@athornton athornton commented Jan 9, 2024

It's another huge but fairly basic changeset: ruff has a LOT of opinions, and the great majority of the commit "Ruff for all test files" is mechanical application of what ruff wants. In some cases I've reworded comments to make the line length happier or to clean up grammar. I've done ruff's recommendations of replacing all the os file operations with Path operations. I've changed all the type stuff for Optional and Union to using pipe-separated typing declarations. It still passes its unit tests (although I have not rolled up my sleeves to attempt replacing pytest-vcr with something more maintainable).

@rufuspollock
Copy link
Member

#129 is merged now ...

@athornton
Copy link
Collaborator Author

cf #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants