-
-
Notifications
You must be signed in to change notification settings - Fork 173
Add publint to the build process #2909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: VividLemon <[email protected]>
|
@copilot There is also the nuxt package that also needs to be checked |
Co-authored-by: VividLemon <[email protected]>
|
@copilot in the ci yaml file, make the publint a new job that depends on the output of build. Build will make an artifact and upload it for use in the publint job |
commit: |
Co-authored-by: VividLemon <[email protected]>
Refactored the CI workflow to create a separate |
|
@copilot on second thought, revert the changes that uploads the build file and put the publint command back into the build job |
Co-authored-by: VividLemon <[email protected]>
* upstream/main: (28 commits) fix(BToggle)! Remove redundant attribute cleanup & update docs for accessibility attributes on show/hide components (bootstrap-vue-next#2918) chore: release main (bootstrap-vue-next#2912) fix: allow custom component props in orchestrator create methods with type safety (bootstrap-vue-next#2922) fix(BModal): prevent focus trap error when no tabbable elements exist (bootstrap-vue-next#2864) Update package description for clarity (bootstrap-vue-next#2917) Update project description for clarity and detail test: add event emission tests for BTable and BTableLite (bootstrap-vue-next#2915) fix(BTableLite): Use primary key to persist row-details state when items change (bootstrap-vue-next#2871) chore: release main (bootstrap-vue-next#2896) feat(BTable): add configurable debouncing ci: Add publint to the build process (bootstrap-vue-next#2909) docs(Offcanvas): Parity pass (bootstrap-vue-next#2900) fix(directives): Robustness fixes for directives (bootstrap-vue-next#2906) docs(BFormInput): document @wheel.prevent for disabling mousewheel events (bootstrap-vue-next#2903) fix(typings): Fix paths to `*.d.mts` files (bootstrap-vue-next#2907) feat: add name and form props to BFormRating for form submission (bootstrap-vue-next#2895) docs: refactor docs to avoid duplication and boilerplate code (bootstrap-vue-next#2891) docs(BToast): Parity (bootstrap-vue-next#2887) docs(BModal): fix attribute to hide footer (bootstrap-vue-next#2888) docs(BPlaceholder): Parity pass (bootstrap-vue-next#2886) ...
Describe the PR
This PR adds publint to validate the package exports and ensure both the main library and Nuxt module work correctly for consumers.
Small replication
Publint runs inline in the build job and validates:
Changes Made:
publint: ^0.3.15as a dev dependency to bothbootstrap-vue-nextand@bootstrap-vue-next/nuxtpackagespublintscript to both package.json filesCI Workflow Structure:
The CI workflow runs publint inline in the build job:
This approach keeps build validation in a single job for simplicity.
Testing:
Fixes #2908
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be deniedOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.