Skip to content

fix(typings): Fix paths to *.d.mts files #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VividLemon merged 1 commit into from
Nov 14, 2025
Merged

fix(typings): Fix paths to *.d.mts files #2907

VividLemon merged 1 commit into from
Nov 14, 2025

Conversation

@turansky
Copy link
Contributor

@turansky turansky commented Nov 13, 2025 •
edited by coderabbitai bot
Loading

Describe the PR

Fix paths to *.d.mts files in package.json

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

Summary by CodeRabbit

  • Bug Fixes
    • Corrected type declaration entry points to ensure proper TypeScript type resolution across components, directives, plugins, composables, resolvers, and utilities.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 13, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025 •
edited
Loading

Walkthrough

The PR updates package.json type export paths to reference .d.mts type declaration files instead of .mts files across multiple sub-paths (components, directives, plugins, composables, resolvers, utils). This change affects TypeScript type resolution for consumers without modifying runtime behavior.

Changes

Cohort / File(s) Change Summary
Type export path corrections
packages/bootstrap-vue-next/package.json		 Updated types entry points across 9 export paths to reference .d.mts type declaration files instead of .mts files, including ./components, ./components/*, ./directives, ./directives/*, ./plugins, ./plugins/*, ./composables, ./composables/*, ./resolvers, and ./utils

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes are confined to a single file with a repetitive, consistent pattern
  • No logic or runtime behavior affected
  • Straightforward path updates for type declaration resolution

Suggested reviewers

  • VividLemon

Poem

🐰 A rabbit's ode to type clarity!

From .mts to .d.mts we go,
Type paths glow brighter now, don't you know?
Declarations precise, exported with care,
TypeScript consumers—your answers are there! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing paths to type declaration files (.d.mts) in the package.json exports configuration.
Description check ✅ Passed The description provides a clear summary of the PR's purpose and includes the completed PR checklist indicating it's a bugfix, meeting core requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f14f049 and 10c0530.

📒 Files selected for processing (1)
  • packages/bootstrap-vue-next/package.json (10 hunks)
🧰 Additional context used
🧠 Learnings (10)
📚 Learning: 2025-09-12T14:46:49.416Z 
Learnt from: CR
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-12T14:46:49.416Z
Learning: Applies to packages/bootstrap-vue-next/src/components/index.ts : When adding a new component, update packages/bootstrap-vue-next/src/components/index.ts to export it

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-09-12T14:46:49.416Z 
Learnt from: CR
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-12T14:46:49.416Z
Learning: Applies to packages/bootstrap-vue-next/src/components/** : Create and modify Vue components only under packages/bootstrap-vue-next/src/components/

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-09-12T14:46:49.416Z 
Learnt from: CR
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-12T14:46:49.416Z
Learning: Applies to packages/bootstrap-vue-next/src/App.vue : Use packages/bootstrap-vue-next/src/App.vue as a local test area for component changes

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-08-19T14:23:46.775Z 
Learnt from: xvaara
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 2732
File: packages/bootstrap-vue-next/CHANGELOG.md:35-41
Timestamp: 2025-08-19T14:23:46.775Z
Learning: In the bootstrap-vue-next repository, CHANGELOG.md files (e.g., packages/bootstrap-vue-next/CHANGELOG.md) are autogenerated and should be ignored in reviews; do not propose edits for them.

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-09-12T14:46:49.416Z 
Learnt from: CR
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-12T14:46:49.416Z
Learning: Applies to packages/bootstrap-vue-next/src/components/**/*.vue : Keep component-specific styles within their respective .vue single-file components

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-09-30T23:57:21.526Z 
Learnt from: dwgray
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 2866
File: apps/docs/src/docs/components/demo/ModalModel.vue:11-15
Timestamp: 2025-09-30T23:57:21.526Z
Learning: The bootstrap-vue-next documentation project uses unplugin-vue-components to automatically resolve and import Vue components like BModal, BButton, etc. Explicit imports for these components in script sections are not required.

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-09-12T14:46:49.416Z 
Learnt from: CR
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-12T14:46:49.416Z
Learning: Applies to packages/bootstrap-vue-next/src/styles/styles.scss : Use packages/bootstrap-vue-next/src/styles/styles.scss as the main styles entry point

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-10-21T19:31:54.113Z 
Learnt from: dwgray
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 2882
File: apps/docs/src/docs/components/demo/PlaceholderWidth.vue:1-22
Timestamp: 2025-10-21T19:31:54.113Z
Learning: The bootstrap-vue-next project uses unplugin to automatically import components, so explicit imports in demo/documentation components are not needed.

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-08-19T23:25:20.688Z 
Learnt from: dwgray
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 2762
File: apps/docs/src/docs/components/popover.md:141-143
Timestamp: 2025-08-19T23:25:20.688Z
Learning: In VitePress projects, .data.ts files use build-time data loading where the file exports a `load()` function, and VitePress makes the loaded data available as a named export `{data}`. The correct import syntax is `import {data} from './file.data'`, not a default import.

Applied to files:

  • packages/bootstrap-vue-next/package.json
📚 Learning: 2025-08-19T23:30:52.911Z 
Learnt from: dwgray
Repo: bootstrap-vue-next/bootstrap-vue-next PR: 2762
File: apps/docs/src/docs/components/tooltip.md:0-0
Timestamp: 2025-08-19T23:30:52.911Z
Learning: VitePress .data.ts files use build-time data loading where the file exports a default object with a load() function, and VitePress processes this at build time to make the loaded data available as a named export {data}. The correct import syntax is `import {data} from './file.data'`, not a default import, even though the .data.ts file itself uses export default.

Applied to files:

  • packages/bootstrap-vue-next/package.json
🔇 Additional comments (1)
packages/bootstrap-vue-next/package.json (1)

24-24: Type declaration paths correctly updated from .mts to .d.mts.

The build configuration properly supports these changes. The vite-plugin-dts afterBuild hook (in vite.config.mts lines 155-161) generates .d.mts files by copying each .d.ts file during build, ensuring all referenced paths in package.json will resolve correctly. The changes maintain proper TypeScript module conventions with ESM imports using .d.mts types and CommonJS requires using .d.ts types.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VividLemon VividLemon merged commit 4b0d55a into bootstrap-vue-next:main Nov 14, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2025
Merged
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Nov 30, 2025
@xvaara
Merge remote-tracking branch 'upstream/main'
c67bed4 
* upstream/main: (28 commits)
  fix(BToggle)! Remove redundant attribute cleanup & update docs for accessibility attributes on show/hide components (bootstrap-vue-next#2918)
  chore: release main (bootstrap-vue-next#2912)
  fix: allow custom component props in orchestrator create methods with type safety (bootstrap-vue-next#2922)
  fix(BModal): prevent focus trap error when no tabbable elements exist (bootstrap-vue-next#2864)
  Update package description for clarity (bootstrap-vue-next#2917)
  Update project description for clarity and detail
  test: add event emission tests for BTable and BTableLite (bootstrap-vue-next#2915)
  fix(BTableLite): Use primary key to persist row-details state when items change (bootstrap-vue-next#2871)
  chore: release main (bootstrap-vue-next#2896)
  feat(BTable): add configurable debouncing
  ci: Add publint to the build process (bootstrap-vue-next#2909)
  docs(Offcanvas): Parity pass (bootstrap-vue-next#2900)
  fix(directives): Robustness fixes for directives (bootstrap-vue-next#2906)
  docs(BFormInput): document @wheel.prevent for disabling mousewheel events (bootstrap-vue-next#2903)
  fix(typings): Fix paths to `*.d.mts` files (bootstrap-vue-next#2907)
  feat: add name and form props to BFormRating for form submission (bootstrap-vue-next#2895)
  docs: refactor docs to avoid duplication and boilerplate code (bootstrap-vue-next#2891)
  docs(BToast): Parity (bootstrap-vue-next#2887)
  docs(BModal): fix attribute to hide footer (bootstrap-vue-next#2888)
  docs(BPlaceholder): Parity pass (bootstrap-vue-next#2886)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VividLemon VividLemon VividLemon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turansky @VividLemon