Skip to content

docs(BModal): fix attribute to hide footer #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dwgray merged 1 commit into from
Oct 24, 2025
Merged

docs(BModal): fix attribute to hide footer #2888

dwgray merged 1 commit into from
Oct 24, 2025

Conversation

@limenet
Copy link
Contributor

@limenet limenet commented Oct 24, 2025 •
edited by coderabbitai bot
Loading

Describe the PR

The example used the old bootstrap-vue attribute hide-footer instead of the new no-footer attribute.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Summary by CodeRabbit

  • Documentation
    • Updated modal component demonstration in the documentation to reflect current control options for footer visibility.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 24, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025 •
edited
Loading

Walkthrough

This PR updates a Vue component demo file, replacing the BModal prop hide-footer with no-footer to adjust modal footer visibility control behavior.

Changes

Cohort / File(s) Summary
Modal Footer Property Update
apps/docs/src/docs/components/demo/ModalExposed.vue		 Changed BModal prop from hide-footer to no-footer for updated footer visibility control

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • xvaara
  • VividLemon

Poem

A modal without a footer shows,
Where once we hid what stays exposed,
The footer now obeys no-footer's call—
No hiding tricks, just truth for all! 🐰✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "docs(BModal): fix attribute to hide footer" is fully related to the main change in the changeset. The title follows the Conventional Commits format with the docs(BModal): prefix and clearly summarizes the primary change: updating the documentation example to use the correct no-footer attribute instead of the deprecated hide-footer attribute. The title is concise, specific, and accurately reflects the modification made to the ModalExposed.vue file.
Description Check ✅ Passed The pull request description follows the required template structure with all essential sections present. The "Describe the PR" section provides a clear and concise explanation of the change, identifying the replacement of the old hide-footer attribute with the new no-footer attribute. The PR checklist is properly filled out with "Documentation update" correctly selected, and the PR title follows the Conventional Commits convention as specified in the requirements. The optional "Small replication" section is omitted, which is acceptable per the template instructions.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 667ea2b and f9b9d77.

📒 Files selected for processing (1)
  • apps/docs/src/docs/components/demo/ModalExposed.vue (1 hunks)
🔇 Additional comments (1)
apps/docs/src/docs/components/demo/ModalExposed.vue (1)

17-17: Change verified—no-footer is the canonical prop for bootstrap-vue-next and documentation is consistent.

The prop change from hide-footer to no-footer is correct. Search results confirm:

  • no-footer is already used in PlaceholderWrapper.vue:6 (consistent codebase)
  • No other active instances of hide-footer remain in documentation examples
  • ShowHideProps.vue:52 documents the migration metadata, not a usage issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

bsvn-vite-ts

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2888

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2888

commit: f9b9d77

dwgray
dwgray approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@dwgray dwgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for fixing this @limenet

@dwgray dwgray merged commit d1eaa4b into bootstrap-vue-next:main Oct 24, 2025
5 checks passed
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Nov 30, 2025
@xvaara
Merge remote-tracking branch 'upstream/main'
c67bed4 
* upstream/main: (28 commits)
  fix(BToggle)! Remove redundant attribute cleanup & update docs for accessibility attributes on show/hide components (bootstrap-vue-next#2918)
  chore: release main (bootstrap-vue-next#2912)
  fix: allow custom component props in orchestrator create methods with type safety (bootstrap-vue-next#2922)
  fix(BModal): prevent focus trap error when no tabbable elements exist (bootstrap-vue-next#2864)
  Update package description for clarity (bootstrap-vue-next#2917)
  Update project description for clarity and detail
  test: add event emission tests for BTable and BTableLite (bootstrap-vue-next#2915)
  fix(BTableLite): Use primary key to persist row-details state when items change (bootstrap-vue-next#2871)
  chore: release main (bootstrap-vue-next#2896)
  feat(BTable): add configurable debouncing
  ci: Add publint to the build process (bootstrap-vue-next#2909)
  docs(Offcanvas): Parity pass (bootstrap-vue-next#2900)
  fix(directives): Robustness fixes for directives (bootstrap-vue-next#2906)
  docs(BFormInput): document @wheel.prevent for disabling mousewheel events (bootstrap-vue-next#2903)
  fix(typings): Fix paths to `*.d.mts` files (bootstrap-vue-next#2907)
  feat: add name and form props to BFormRating for form submission (bootstrap-vue-next#2895)
  docs: refactor docs to avoid duplication and boilerplate code (bootstrap-vue-next#2891)
  docs(BToast): Parity (bootstrap-vue-next#2887)
  docs(BModal): fix attribute to hide footer (bootstrap-vue-next#2888)
  docs(BPlaceholder): Parity pass (bootstrap-vue-next#2886)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwgray dwgray dwgray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@limenet @dwgray