Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store columns while saving view and restore columns on selecting view without select columns #5647

Merged
merged 4 commits into from
Oct 4, 2024
Merged

feat: store columns while saving view and restore columns on selecting view without select columns #5647

merged 4 commits into from
Oct 4, 2024

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Aug 6, 2024 •
edited
Loading

Summary

  • store the selected columns in list view of traces while saving a view
  • if user selects a view that doesn't have any selectColumns associated with it, restore the most recent select columns

Related Issues / PR's

close #4801
close #5882

Screenshots

Updated Loom Video
https://www.loom.com/share/b25e5b5ddd7440ff97980edcc453fbc4

E2E tests

https://github.com/SigNoz/signoz-e2e/pull/8

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ahmadshaheer ahmadshaheer changed the title feat: store columns while saving view and restore columns on selectin… feat: store columns while saving view and restore columns on selecting view without select columns Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SigNoz SigNoz deleted a comment from github-actions bot Aug 6, 2024
@SigNoz SigNoz deleted a comment from github-actions bot Aug 6, 2024
@SigNoz SigNoz deleted a comment from github-actions bot Aug 6, 2024
@ahmadshaheer ahmadshaheer force-pushed the feat/store-columns-while-saving-view branch from 0cc0c18 to 60bc5ea Compare August 28, 2024 05:25
@ahmadshaheer ahmadshaheer force-pushed the feat/store-columns-while-saving-view branch from 60bc5ea to cfeb4d8 Compare September 10, 2024 08:44
@vikrantgupta25 vikrantgupta25 self-assigned this Sep 10, 2024
SagarRajput-7
SagarRajput-7 previously approved these changes Sep 26, 2024
View reviewed changes
vikrantgupta25
vikrantgupta25 previously approved these changes Sep 26, 2024
View reviewed changes
@YounixM YounixM self-requested a review September 27, 2024 08:01
@YounixM YounixM merged commit 2eb3f6c into develop Oct 4, 2024
12 of 13 checks passed
@YounixM YounixM deleted the feat/store-columns-while-saving-view branch October 4, 2024 06:07
@wSedlacek wSedlacek mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

@YounixM YounixM YounixM approved these changes

@rahulkeswani101 rahulkeswani101 rahulkeswani101 left review comments

@vikrantgupta25 vikrantgupta25 vikrantgupta25 left review comments

Assignees

@vikrantgupta25 vikrantgupta25

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to save columns also with views in logs Save columns in list view as part of saved view
5 participants
@ahmadshaheer @YounixM @vikrantgupta25 @SagarRajput-7 @rahulkeswani101