fix: add null check to prevent storing empty selectItems

SigNoz · Aug 6, 2024 · 0cc0c18 · 0cc0c18
1 parent 0ecb1d2
commit 0cc0c18
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/frontend/src/container/ExplorerOptions/ExplorerOptions.tsx b/frontend/src/container/ExplorerOptions/ExplorerOptions.tsx
@@ -247,7 +247,7 @@ function ExplorerOptions({
 
 		const extraData = JSON.parse(currentViewDetails?.extraData ?? '{}');
 
-		if (extraData?.selectColumns) {
+		if (!!extraData && extraData?.selectColumns) {
 			localStorage.setItem(
 				LOCALSTORAGE.OLD_SELECT_COLUMNS,
 				JSON.stringify(options.selectColumns),
@@ -261,7 +261,10 @@ function ExplorerOptions({
 			const oldSelectColumns = JSON.parse(
 				localStorage.getItem(LOCALSTORAGE.OLD_SELECT_COLUMNS) ?? '{}',
 			);
-			if (!isEqual(oldSelectColumns, options.selectColumns)) {
+			if (
+				Object.keys(oldSelectColumns).length &&
+				!isEqual(oldSelectColumns, options.selectColumns)
+			) {
 				handleOptionsChange({
 					...options,
 					selectColumns: oldSelectColumns,