Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting view in explorer-options does not switch to view #6187

Closed
wSedlacek opened this issue Oct 14, 2024 · 2 comments · Fixed by #6200
Closed

Selecting view in explorer-options does not switch to view #6187

wSedlacek opened this issue Oct 14, 2024 · 2 comments · Fixed by #6200
Assignees
@ahmadshaheer
Labels
bug Something isn't working logs-explorer

Comments

@wSedlacek
Copy link

Bug description

When using the view drop down in the explorer it does not switch between views.
Tested with logs but might affect other environments too.
Clearing the view does work, and reloading post selecting does bring up the right view, but click the view does not select it.
If a view is already selected then clicking a different view doesn't switch the drop down either.

Screen.Recording.2024-10-14.at.09.33.17.mov

Expected behavior

The view picker should work as it did in 0.55.0 where clicking a view switches to it.

How to reproduce

  1. Create at least 2 views in logs
  2. Try to switch between those views

Version information

  • Signoz version: 0.56.0
  • Browser version: Chrome 129.0.6668.101
  • Your OS and version: macOS 14.6.1
  • Your CPU Architecture(ARM/Intel): ARM

Additional context

This bug was introduced with 0.56.0, in 0.55.0 the explorer did not exhibit this issue.

Thank you for your bug report – we love squashing them!
@welcome Welcome
Copy link

welcome bot commented Oct 14, 2024

Thanks for opening this issue. A team member should give feedback soon. In the meantime, feel free to check out the contributing guidelines.

@wSedlacek
Copy link
Author

wSedlacek commented Oct 14, 2024 •
edited
Loading

After looking at the changes to the ExplorerOptions.tsx I believe a change in this pr is most likely to have caused the regression.

#5647

When doing some debugging I found that if handleOptionsChange() is not called by the newly added updateOrRestoreSelectColumns() then the issue does not occur.

It is called because extraData.selectColumns?.length is 1.
Screenshot 2024-10-14 at 09 55 56

Perhaps there is intended to be a isEqual() check here like there is with the else case?
Perhaps either updatePreservedViewInLocalStorage() OR updateOrRestoreSelectColumns() should be called but not both?
Perhaps updateOrRestoreSelectColumns()should use some output of updatePreservedViewInLocalStorage()?

(Just throwing some ideas out, I am looking at this code for the first time so I really don't know the answer to these questions)

@srikanthccv srikanthccv added bug Something isn't working logs-explorer labels Oct 14, 2024
@ahmadshaheer ahmadshaheer linked a pull request Oct 16, 2024 that will close this issue
fix: issue while switching between views #6200
Merged
@ahmadshaheer ahmadshaheer mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmadshaheer ahmadshaheer

Labels
bug Something isn't working logs-explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: issue while switching between views SigNoz/signoz
4 participants
@wSedlacek @srikanthccv @ahmadshaheer @vikrantgupta25