Fetch live resolver urls in background #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
force-pushed
the
background-fetch
branch
from
4467582 to
28f2ee3
Compare
stefanbuck
commented
Dec 16, 2018
| @@ -11,11 +11,18 @@ const LINK_SELECTOR = '.octolinker-link'; | |||
| const $body = $('body'); | |||
| let matches; | |||
|
|
|||
| function openUrl(url, newWindow = false, newWindowActive = true) { | |||
| function openUrl(event, url) { | |||
There was a problem hiding this comment.
Disclaimer: We will get rid of this file soon anyway, so need to aim for a perfect solution 😉
stefanbuck
force-pushed
the
background-fetch
branch
from
28f2ee3 to
c044217
Compare
|
Gangsta merge 😉 |
|
So, as expected, the server quickly reached a critical memory usage. This is caused by our current caching strategy. We use mem which worked well in the past, but maybe it isn't suitable with our new requirement. I'll investigate.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one (of a few) changes which are needed to implement #277.
On app startup it prefetch all live resolver urls at once in the background by calling a bulk endpoint. For details check out OctoLinker/api#59. If a user clicks on a link, the click handler will check an internal cache first. If the requested resource isn't available it will fallback to the old behaviour.
With this Pull Request I want to verify that our live resolver server is able to handle such traffic increase. The timing for this is perfect. It's one week before Christmas which I assume is already a less busy week than any other week. Also in case something goes really bad, it won't affect that many people.