Remove first-class support for bower #536
Conversation
|
Is the goal here to reduce the number of lookups needed, in order to make it faster to lookup every link ahead of time? |
|
I got interrupted while writing the PR description so I just raised the PR half way through. Somehow yes, it's about speeding up things. Since a few weeks we prefetch some url in the background see #529. This results in a massive load increase on our live resolver service. The second most requested registry type after
|
stefanbuck
force-pushed
the
bower
branch
2 times, most recently
from
a2d9a95 to
40bf7af
Compare
| @@ -70,7 +70,7 @@ describe('End to End tests', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('expanded blob', () => { | |||
| describe.skip('expanded blob', () => { | |||
There was a problem hiding this comment.
The following selector isn't working anymore [data-line-number="45"] + td .octolinker-link, because our link isn't a child of [data-line-number="45"] anymore.
<tr class="blob-expanded">
<td class="blob-num js-linkable-line-number" data-line-number="45"></td>
<td class="blob-code blob-code-inner blob-code-marker" data-code-marker=" ">
<a class="octolinker-link octolinker-line-indicator">
<span>eslint-plugin-import</span>
</a>
</td>
</tr>Will try to come up with a solution later
There was a problem hiding this comment.
Oh, did it just move to a different number or something?
There was a problem hiding this comment.
No, the line number is still the same. The data attr for the line number moved to a sibling node and therefore the link element isn't accessable with a CSS selector.
|
@josephfrazier are you happy with me merging this? |
| @@ -70,7 +70,7 @@ describe('End to End tests', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('expanded blob', () => { | |||
| describe.skip('expanded blob', () => { | |||
There was a problem hiding this comment.
Oh, did it just move to a different number or something?
Over the past few years, bower lost popularity in favour of npm. Even they recommend using npm or yarn for front-end projects nowadays. OctoLinker still supports
bower.jsonfiles, but remove the first-class support for ES6 modules and CommonJS and resolve to npm only form now on.