Add a script to synchronise translations from the English file to the … #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…local files Signed-off-by: Tobia De Koninck <[email protected]>
|
E.g. the output on #71: |
RobinJadoul
requested changes
Sep 4, 2017
sync_translation.py
Outdated
|
|
||
| if __name__ == "__main__": | ||
|
|
||
| with open(os.path.join('_locales', 'en', 'messages.json')) as file: |
There was a problem hiding this comment.
maybe use __file__ to make sure the current working directory doesn't interfere
sync_translation.py
Outdated
| if f != "en": | ||
| stats = synctranslation(enTranslation, os.path.join("_locales", f, "messages.json")) | ||
|
|
||
| if len(stats["added"]) > 0: |
There was a problem hiding this comment.
This check isn't needed, since the for wouldn't loop otherwise.
Merged
Signed-off-by: Tobia De Koninck <[email protected]>
|
@RobinJadoul done 😄 |
RobinJadoul
changed the title
RobinJadoul
reviewed
Sep 5, 2017
sync_translation.py
Outdated
|
|
||
| if target[id]["message"] == base[id]["message"]: | ||
| nottranslated.append(id) | ||
| print(join(base_path, target_file_name)) |
There was a problem hiding this comment.
Too much output this way?
sync_translation.py
Outdated
| # You should have received a copy of the GNU General Public License | ||
| # along with Keywi. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
|
|
||
| # This script synchronises a translated language file with the English one |
There was a problem hiding this comment.
This could actually be a docstring, but I guess a comment is fine as well
Signed-off-by: Tobia De Koninck <[email protected]>
RobinJadoul
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…local files
@RobinJadoul what do you think?
If found useful I can add a CI job.