Remove css validator (#1085)

* remove css validator * remove css validator in compound.js check * Update lib/l10n-en_GB.js Co-authored-by: Denis Ah-Kang <[email protected]> * Keep css correction in documentation, #1085 (review) Co-authored-by: Denis Ah-Kang <[email protected]>
w3c · Jan 5, 2021 · 05b2462 · 05b2462
1 parent c8d0ec4
commit 05b2462
Show file tree

Hide file tree

Showing 9 changed files with 47 additions and 259 deletions.
diff --git a/.cspell.json b/.cspell.json
@@ -20,7 +20,6 @@
         "Cmembership",
         "constexpr",
         "Cprocess",
-        "cssvalidation",
         "ctor",
         "customised",
         "DAHUT",
@@ -164,4 +163,4 @@
         "node_modules/**"
     ],
     "allowCompoundWords": true
-}
+}
diff --git a/lib/exceptions.json b/lib/exceptions.json
@@ -1,29 +1,5 @@
 {
   ".*": [
-    {
-      "rule": "validation.css",
-      "type": "at-rule"
-    },
-    {
-      "rule": "validation.css",
-      "type": "noexistence-at-all",
-      "message": "Property justify-self doesn't exist : "
-    },
-    {
-      "rule": "validation.css",
-      "type": "noexistence-at-all",
-      "message": "Property user-select doesn't exist : "
-    },
-    {
-      "rule": "validation.css",
-      "type": "generator.unrecognize",
-      "message": "Parse Error"
-    },
-    {
-      "rule": "validation.css",
-      "type": "noexistence-at-all",
-      "message": "Property “pointer-events” doesn't exist : "
-    },
     {
       "rule": "validation.html",
       "type": "noexistence-at-all",
@@ -34,11 +10,6 @@
       "message": "Bad value “publication” for attribute “rel” on element “link”: The string “publication” is not a registered keyword."
     }
   ],
-  "^css.*$": [
-    {
-      "rule": "validation.css"
-    }
-  ],
   "^webrtc$": [
     {
       "rule": "headers.copyright"

diff --git a/lib/l10n-en_GB.js b/lib/l10n-en_GB.js
@@ -90,11 +90,10 @@ exports.messages = {
 ,   "links.linkchecker.display":      "Please verify using <a href=\"https://validator.w3.org/checklink?uri=${link}&recursive=on\">Link Checker</a>."
     // links/compound
 ,   "links.compound.skipped":           "HTML and CSS validations for compound documents were skipped. "
-,   "links.compound.no-validation":     "Validation of <a href=\"${link}\">${file}</a> <a href=\"https://validator.w3.org/nu/doc=${link}\">HTML</a> <a href=\"https://jigsaw.w3.org/css-validator/validator?profile=css3svg&uri=${link}\">CSS</a>"
-,   "links.compound.link":              "Validation of <a href=\"${link}\">${file}</a> <a href=\"https://validator.w3.org/nu/doc=${link}\">HTML ${markup}</a> <a href=\"https://jigsaw.w3.org/css-validator/validator?profile=css3svg&uri=${link}\">CSS ${css}</a>"
-,   "links.compound.error":             "Validation of <a href=\"${link}\">${file}</a> <a href=\"https://validator.w3.org/nu/doc=${link}\">HTML</a> <a href=\"https://jigsaw.w3.org/css-validator/validator?profile=css3svg&uri=${link}\">CSS</a>: ${errMsg}"
+,   "links.compound.no-validation":     "Validation of <a href=\"${link}\">${file}</a> <a href=\"https://validator.w3.org/nu/doc=${link}\">HTML</a>."
+,   "links.compound.link":              "Validation of <a href=\"${link}\">${file}</a> <a href=\"https://validator.w3.org/nu/doc=${link}\">HTML ${markup}</a>."
+,   "links.compound.error":             "Validation of <a href=\"${link}\">${file}</a> <a href=\"https://validator.w3.org/nu/doc=${link}\">HTML</a>: ${errMsg}."
 ,   "links.compound.html-timeout":      "The HTML validator timed out."
-,   "links.compound.css-timeout":       "The CSS validator timed out."
 ,   "links.reliability.unreliable-link": "Link for <em>\"${text}\"</em> is pointing to unreliable domain <em>\"${link}\"</em>."
     // sotd/supersedable
 ,   "sotd.supersedable.no-sotd-intro":  "No <em>&ldquo;status of this document&rdquo;</em> introduction (eg absent, not using HTTPS, wrong copy)."
@@ -217,14 +216,6 @@ exports.messages = {
     // style/body-toc-sidebar
 ,   "style.body-toc-sidebar.class-found": 'The class <code>toc-sidebar</code> should be added by <code>fixup.js</code>.'
 ,   "style.body-toc-sidebar.selector-fail": 'Selector <code>body</code> failed.'
-    // validation/css
-,   "validation.css.skipped":       "CSS validation was skipped."
-,   "validation.css.no-source":     "No CSS source to validate."
-,   "validation.css.failure":       "Failure code from CSS validator: ${status}."
-,   "validation.css.no-response":   "No response from CSS validator."
-,   "validation.css.warning":       "[${level}:${type}] ${message} (${source}, line ${line})<br><a href=\"${link}\">CSS validator</a>"
-,   "validation.css.error":         "[${type}] ${message} (${source}, line ${line} in “${context}”)<br><a href=\"${link}\">CSS validator</a>"
-,   "validation.css.timeout":       "The CSS validator timed out."
     // validation/html
 ,   "validation.html.skipped":              "HTML validation was skipped."
 ,   "validation.html.no-source":            "No HTML source to validate."

diff --git a/lib/profiles/base.js b/lib/profiles/base.js
@@ -71,7 +71,6 @@ exports.rules = [
 ,   require("../rules/links/reliability")
 
 ,   require("../rules/validation/html")
-,   require("../rules/validation/css")
 ,   require('../rules/validation/wcag')
 ,   require('../rules/heuristic/date-format')
 ];
diff --git a/lib/rules/links/compound.js b/lib/rules/links/compound.js
@@ -32,67 +32,50 @@ exports.check = function (sr, done) {
     links = links.sort().filter(function (item, pos) {return (!pos || item != links[pos - 1]);});
 
     var markupService = "https://validator.w3.org/nu/"
-    ,   cssService = "http://jigsaw.w3.org/css-validator/validator"
     ,   count = 0;
     if (links.length > 0) {
-      links.forEach(function (l) {
-          if (sr.config.validation === "recursive") {
-              var req
-              ,   reqCSS
-              ,   ua = "W3C-Pubrules/" + sr.version
-              ,   isMarkupValid = false
-              ,   isCSSValid = false;
-              req = sua.get(markupService)
-                       .set("User-Agent", ua)
-                       .query({ doc: l, out: "json" })
-                       .on('error', function(err) {
-                           sr.error(self, 'error', { file : l.split('/').pop(), link : l, errMsg: err});
-                           count++;
-                           return;
-                       });
-              req.timeout(TIMEOUT);
-              req.end(function (err1, res) {
-                  if (err1 && err1.timeout === TIMEOUT) sr.warning(self, "html-timeout");
-                  var json = res ? res.body : null;
-                  if (!json) return sr.throw("No JSON input.");
-                  if (json.messages) {
-                      var errors = json.messages.filter(function(msg) {
-                          return msg.type === "error";
-                      });
-                      if (errors.length === 0) isMarkupValid = true;
-                  }
-                  reqCSS = sua.get(cssService)
-                          .set("User-Agent", ua)
-                          .query({ uri: l, profile: "css3svg", output: "json", type: "html" })
-                          .on('error', function(err) {
-                              sr.error(self, 'error', { file : l.split('/').pop(), link : l, errMsg: err});
-                              count++;
-                              return;
-                          });
-                  reqCSS.timeout(TIMEOUT);
-                  reqCSS.end(function (err2, res) {
-                      if (err2 && err2.timeout === TIMEOUT) sr.warning(self, "css-timeout");
-                      if (res && res.header && res.header['x-w3c-validator-status'] === 'Valid') isCSSValid = true;
-                      if (isMarkupValid && isCSSValid) {
-                          sr.info(self, "link", { file : l.split('/').pop(), link : l , markup : "\u2714", css : "\u2714" });
-                      }
-                      else {
-                          const details = {
-                              file: l.split('/').pop(),
-                              link: l,
-                              markup: (isMarkupValid ? "\u2714" : "\u2718"),
-                              css: (isCSSValid ? "\u2714" : "\u2718")
-                          };
-                          sr.error(self, "link", details);
-                      }
-                      count++;
-                      if (count === links.length) return done();
-                  });
-              });
-          }
-          else {
-              sr.info(self, "no-validation", { file : l.split('/').pop(), link : l });
-          }
-      });
+        links.forEach(function (l) {
+            if (sr.config.validation === "recursive") {
+                var req
+                ,   ua = "W3C-Pubrules/" + sr.version
+                ,   isMarkupValid = false;
+                req = sua.get(markupService)
+                        .set("User-Agent", ua)
+                        .query({ doc: l, out: "json" })
+                        .on('error', function(err) {
+                            sr.error(self, 'error', { file : l.split('/').pop(), link : l, errMsg: err});
+                            count++;
+                            return;
+                        });
+                req.timeout(TIMEOUT);
+                req.end(function (err1, res) {
+                    if (err1 && err1.timeout === TIMEOUT) sr.warning(self, "html-timeout");
+                    var json = res ? res.body : null;
+                    if (!json) return sr.throw("No JSON input.");
+                    if (json.messages) {
+                        var errors = json.messages.filter(function(msg) {
+                            return msg.type === "error";
+                        });
+                        if (errors.length === 0) isMarkupValid = true;
+                    }
+                    if (isMarkupValid) {
+                        sr.info(self, "link", { file : l.split('/').pop(), link : l , markup : "\u2714"});
+                    }
+                    else {
+                        const details = {
+                            file: l.split('/').pop(),
+                            link: l,
+                            markup: (isMarkupValid ? "\u2714" : "\u2718")
+                        };
+                        sr.error(self, "link", details);
+                    }
+                    count++;
+                    if (count === links.length) return done();
+                });
+            }
+            else {
+                sr.info(self, "no-validation", { file : l.split('/').pop(), link : l });
+            }
+        });
     } else return done();
 };
diff --git a/lib/rules/validation/css.js b/lib/rules/validation/css.js
diff --git a/test/docs/validation/bad-css.html b/test/docs/validation/bad-css.html
diff --git a/test/docs/validation/css.html b/test/docs/validation/css.html
diff --git a/test/validation.js b/test/validation.js
@@ -10,11 +10,6 @@
  */
 
 if (!process || !process.env || (process.env.TRAVIS !== 'true' && !process.env.SKIP_NETWORK)) {
-    exports.css = [
-        {doc: 'validation/simple.html', ignoreWarnings: true}
-    ,   {doc: 'validation/css.html', ignoreWarnings: true}
-    ,   {doc: 'validation/bad-css.html', errors: ['validation.css.error', 'validation.css.error'], ignoreWarnings: true}
-    ];
     exports.html = [
         {doc: 'validation/simple.html'}
     ,   {doc: 'validation/invalid.html', errors: ['validation.html.error']}