Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove css validator #1085

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Remove css validator #1085

merged 5 commits into from
Jan 5, 2021

Conversation

jennyliang220
Copy link
Contributor

Resolve #866

@jennyliang220 jennyliang220 requested a review from deniak December 29, 2020 17:27
deniak
deniak requested changes Jan 4, 2021
View reviewed changes
Copy link
Member

@deniak deniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, leave the documentation in rules.json as the NU validator will also check the CSS.

lib/l10n-en_GB.js Outdated Show resolved Hide resolved
@jennyliang220 @deniak
Update lib/l10n-en_GB.js
75f7e84 
Co-authored-by: Denis Ah-Kang <[email protected]>
@jennyliang220 jennyliang220 requested a review from deniak January 5, 2021 06:47
@deniak deniak merged commit 05b2462 into main Jan 5, 2021
@deniak deniak deleted the 855_remove_css_validator branch January 5, 2021 12:27
@jennyliang220 jennyliang220 mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniak deniak deniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we get rid of the CSS validator rule?
2 participants
@jennyliang220 @deniak