fix: experimental filters helper text and empty input bugs (#522)

saleor · Jul 26, 2023 · a754015 · a754015 · vercel · Jul 26, 2023
1 parent 7173eda
commit a754015
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -31,6 +31,7 @@ module.exports = {
   },
   plugins: ["react", "@typescript-eslint", "react-hooks", "import"],
   rules: {
+    "no-console": "error",
     "react/react-in-jsx-scope": "off",
     "react-hooks/rules-of-hooks": "error",
     "react-hooks/exhaustive-deps": "warn",

diff --git a/src/components/ExperimentalFilters/ExperimentalFilters.stories.tsx b/src/components/ExperimentalFilters/ExperimentalFilters.stories.tsx
@@ -93,12 +93,12 @@ const defaultValue = [
   {
     value: { value: "discount", label: "Release date", type: "4" },
     condition: {
-      options: [{ value: "input-1", label: "between", type: "date.range" }],
+      options: [{ value: "input-1", label: "between", type: "number.range" }],
       selected: {
         conditionValue: {
           value: "input-1",
           label: "between",
-          type: "date.range",
+          type: "number.range",
         },
         value: ["0", "1"],
       },
@@ -302,9 +302,8 @@ export const Error = () => {
         value={defaultValue}
         error={[
           {
-            row: 0,
+            row: 8,
             rightText: "Some error here",
-            leftText: "Some error here",
           },
           {
             row: 2,

diff --git a/src/components/ExperimentalFilters/RightOperator.tsx b/src/components/ExperimentalFilters/RightOperator.tsx
@@ -155,7 +155,7 @@ export const RightOperator = ({
           }}
           type="number"
           error={!!error}
-          helperText={error}
+          helperText={helperText}
           disabled={disabled}
           width="100%"
         />
@@ -203,7 +203,7 @@ export const RightOperator = ({
           }}
           type="date"
           error={!!error}
-          helperText={error}
+          helperText={helperText}
           disabled={disabled}
           width="100%"
         />
@@ -221,13 +221,13 @@ export const RightOperator = ({
           }}
           type="datetime-local"
           error={!!error}
-          helperText={error}
+          helperText={helperText}
           disabled={disabled}
           width="100%"
         />
       </RangeInputWrapper>
     );
   }
 
-  return <Input disabled />;
+  return <Input disabled value={selected.value} />;
 };