Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: experimental filters helper text and empty input bugs #522

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: experimental filters helper text and empty input bugs #522

merged 2 commits into from
Jul 26, 2023

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Jul 26, 2023 •
edited
Loading

I want to merge this change because this PR fixes a couple of bugs:

  • helperText was not properly passed to ranges
  • fixed error in the dashboard when default disabled input was changing from uncontrolled to controlled input

This PR closes #...

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • Storybook story is created and documentation properly generated.

@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 0:32am
macaw-ui-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 0:32am

@vercel vercel bot temporarily deployed to Preview – macaw-ui-next July 26, 2023 11:08 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review July 26, 2023 11:10
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky and poulch July 26, 2023 11:10
andrzejewsky
andrzejewsky previously approved these changes Jul 26, 2023
View reviewed changes
@vercel vercel bot temporarily deployed to Preview – macaw-ui July 26, 2023 11:12 Inactive
@krzysztofzuraw krzysztofzuraw changed the title fix: experminetal filters bugs fix: experimental filters bugs Jul 26, 2023
poulch
poulch previously approved these changes Jul 26, 2023
View reviewed changes
src/components/ExperimentalFilters/RightOperator.tsx Outdated Show resolved Hide resolved
@krzysztofzuraw krzysztofzuraw changed the title fix: experimental filters bugs fix: experimental filters helper text and empty input bugs Jul 26, 2023
@krzysztofzuraw krzysztofzuraw dismissed stale reviews from poulch and andrzejewsky via cf76d71 July 26, 2023 12:11
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next July 26, 2023 12:31 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui July 26, 2023 12:32 Inactive
@krzysztofzuraw krzysztofzuraw merged commit a754015 into canary Jul 26, 2023
@krzysztofzuraw krzysztofzuraw deleted the fix/filters-bugs branch July 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulch poulch poulch approved these changes

@andrzejewsky andrzejewsky andrzejewsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krzysztofzuraw @andrzejewsky @poulch