Refactoring the MovieSystem so that it may be moved into a gem #18541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Sempé <[email protected]>
Signed-off-by: Luis Sempé <[email protected]>
Signed-off-by: Luis Sempé <[email protected]>
Signed-off-by: Luis Sempé <[email protected]>
lsemp3d
added
the
feature/trackview
Code/Legacy/CrySystem/System.cpp
Outdated
| @@ -241,6 +241,9 @@ CSystem::CSystem() | |||
| #endif | |||
|
|
|||
| m_ConfigPlatform = CONFIG_INVALID_PLATFORM; | |||
|
|
|||
| m_movieSystem = nullptr; | |||
| Maestro::MovieSystemRequestBus::BroadcastResult(m_movieSystem, &Maestro::MovieSystemRequestBus::Events::GetMovieSystem); | |||
There was a problem hiding this comment.
I expect CrySystem/System to be init super early, we're sure that we won't end up in a case where m_movieSystem is always nullptr because Maestro hasn't been init ?
There was a problem hiding this comment.
It gets set during OnCrySystemInitialized which is also where gEnv->pMovieSystem was being populated before, the behavior/timing did not change
guillaume-haerinck
approved these changes
Dec 8, 2024
Signed-off-by: Luis Sempé <[email protected]>
spham-amzn
reviewed
Dec 9, 2024
spham-amzn
reviewed
Dec 9, 2024
spham-amzn
reviewed
Dec 9, 2024
| Maestro::MovieSystemRequestBus::BroadcastResult(movieSystem, &Maestro::MovieSystemRequestBus::Events::GetMovieSystem); | ||
|
|
||
| float elapsedTime = movieSystem ? movieSystem->GetPlayingTime(pCurSeq) - rng.start : 0.f; | ||
| int percentage = int(100.0f * (m_renderContext.spentTime + elapsedTime) / m_renderContext.expectedTotalTime); |
There was a problem hiding this comment.
Can we protect against a divide by zero here?
spham-amzn
reviewed
Dec 9, 2024
spham-amzn
reviewed
Dec 9, 2024
Signed-off-by: Luis Sempé <[email protected]>
Signed-off-by: Luis Sempé <[email protected]>
Signed-off-by: Luis Sempé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The MovieSystem is still using the legacy paradigm of keeping global pointers in gEnv, this creates a tight coupling that is undesirable given O3DE's modular design. This is the first part of a refactor that aims to move the MovieSystem entirely proviedd by a gem and all the legacy code moved out of Legacy/CryCommon
Removed the global pointer to IMovieSystem and replaced it with an EBus call, this decouples the MovieSystem from the Editor itself and allows it to be provided by a gem, in this case the Maestro gem which creates the MovieSystem in its system component.
While this does not entirely decouple the movie system from the editor, it's a step in that direction. Next step will be for the MovieSystem to receive update events rather than having them called directly from the editor.
How was this PR tested?
Used TrackView to make a simple sequence that moved and rotated an entity.