Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving one-time billing template to TS #114

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Moving one-time billing template to TS #114

wants to merge 8 commits into from

Conversation

DevAOC
Copy link
Collaborator

@DevAOC DevAOC commented Nov 4, 2024

This one was pretty straight forward

@DevAOC DevAOC requested a review from rdraward November 4, 2024 21:31
Copy link
Collaborator

@rdraward rdraward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only ever see a spinner after installing
CleanShot 2024-11-06 at 10 34 33@2x

It seems like one of fetchingShop and loading are always true in the ShopProvider
CleanShot 2024-11-06 at 10 35 11@2x

@@ -63,7 +64,7 @@ export default () => {
setDisabled(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

res type error, might be an autocomponent issue?
CleanShot 2024-11-06 at 10 48 36@2x

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that it's an autocomponent issue

@DevAOC
Copy link
Collaborator Author

DevAOC commented Nov 11, 2024

I only ever see a spinner after installing CleanShot 2024-11-06 at 10 34 33@2x

It seems like one of fetchingShop and loading are always true in the ShopProvider CleanShot 2024-11-06 at 10 35 11@2x

Not able to reproduce this issue. I just uninstalled and deleted the record then reinstalled

@DevAOC DevAOC requested a review from rdraward November 11, 2024 20:32
@DevAOC
Copy link
Collaborator Author

DevAOC commented Nov 11, 2024

Do you mind showing me the load issue live?

Copy link
Collaborator

@rdraward rdraward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 ✅
This one looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants