-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of CAM postprocessor for the Masso controller #18845
Open
ShamanTcler
wants to merge
12
commits into
FreeCAD:main
Choose a base branch
from
ShamanTcler:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+559
−2
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
12d8ec2
Mods to accommodate tool order in Gcode. Some controllers want T# M6 …
ShamanTcler 6580761
Added tests and additional comments
ShamanTcler 56253f3
Working on the testing framework
ShamanTcler efbaecc
Tried to make refactored linux and masso as compatable line by line t…
ShamanTcler 0b96be3
A space in the file name caused all sorts of grief ... Thanks Larry
ShamanTcler a32eceb
Merge branch 'FreeCAD:main' into main
ShamanTcler 18282f7
added files to , swapped tool order in testrefactored_masso
ShamanTcler a4ec52a
Added note regarding how files are "clones" of one another
ShamanTcler ba8124e
Added space in comment line for consistent formatting.
ShamanTcler 66f92c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 57687f0
Updated formatting and comments
ShamanTcler 2d644a2
Merge branch 'main' of https://github.com/ShamanTcler/FreeCAD_Masso i…
ShamanTcler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added tests and additional comments
- Loading branch information
commit 6580761e081c4b9fa3a6c73b57f752dfd4d4425a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,287 @@ | ||
# -*- coding: utf-8 -*- | ||
# *************************************************************************** | ||
# * Copyright (c) 2022 sliptonic <[email protected]> * | ||
# * Copyright (c) 2022 Larry Woestman <[email protected]> * | ||
# * Copyright (c) 2024 Carl Slater <[email protected]> * | ||
# * * | ||
# * This program is free software; you can redistribute it and/or modify * | ||
# * it under the terms of the GNU Lesser General Public License (LGPL) * | ||
# * as published by the Free Software Foundation; either version 2 of * | ||
# * the License, or (at your option) any later version. * | ||
# * for detail see the LICENCE text file. * | ||
# * * | ||
# * This program is distributed in the hope that it will be useful, * | ||
# * but WITHOUT ANY WARRANTY; without even the implied warranty of * | ||
# * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * | ||
# * GNU Library General Public License for more details. * | ||
# * * | ||
# * You should have received a copy of the GNU Library General Public * | ||
# * License along with this program; if not, write to the Free Software * | ||
# * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 * | ||
# * USA * | ||
# * * | ||
# *************************************************************************** | ||
|
||
from importlib import reload | ||
|
||
import FreeCAD | ||
|
||
import Path | ||
import CAMTests.PathTestUtils as PathTestUtils | ||
from Path.Post.scripts import refactored_masso_g3_post as postprocessor | ||
|
||
|
||
Path.Log.setLevel(Path.Log.Level.DEBUG, Path.Log.thisModule()) | ||
Path.Log.trackModule(Path.Log.thisModule()) | ||
|
||
|
||
class TestRefactoredmasso_g3Post(PathTestUtils.PathTestBase): | ||
@classmethod | ||
def setUpClass(cls): | ||
"""setUpClass()... | ||
This method is called upon instantiation of this test class. Add code | ||
and objects here that are needed for the duration of the test() methods | ||
in this class. In other words, set up the 'global' test environment | ||
here; use the `setUp()` method to set up a 'local' test environment. | ||
This method does not have access to the class `self` reference, but it | ||
is able to call static methods within this same class. | ||
""" | ||
|
||
# Open existing FreeCAD document with test geometry | ||
FreeCAD.newDocument("Unnamed") | ||
|
||
@classmethod | ||
def tearDownClass(cls): | ||
"""tearDownClass()... | ||
This method is called prior to destruction of this test class. Add | ||
code and objects here that cleanup the test environment after the | ||
test() methods in this class have been executed. This method does not | ||
have access to the class `self` reference. This method | ||
is able to call static methods within this same class. | ||
""" | ||
# Close geometry document without saving | ||
FreeCAD.closeDocument(FreeCAD.ActiveDocument.Name) | ||
|
||
# Setup and tear down methods called before and after each unit test | ||
def setUp(self): | ||
"""setUp()... | ||
This method is called prior to each `test()` method. Add code and | ||
objects here that are needed for multiple `test()` methods. | ||
""" | ||
self.doc = FreeCAD.ActiveDocument | ||
self.con = FreeCAD.Console | ||
self.docobj = FreeCAD.ActiveDocument.addObject("Path::Feature", "testpath") | ||
reload( | ||
postprocessor | ||
) # technical debt. This shouldn't be necessary but here to bypass a bug | ||
|
||
def tearDown(self): | ||
"""tearDown()... | ||
This method is called after each test() method. Add cleanup instructions here. | ||
Such cleanup instructions will likely undo those in the setUp() method. | ||
""" | ||
FreeCAD.ActiveDocument.removeObject("testpath") | ||
|
||
def test000(self): | ||
"""Test Output Generation. | ||
Empty path. Produces only the preamble and postable. | ||
""" | ||
|
||
self.docobj.Path = Path.Path([]) | ||
postables = [self.docobj] | ||
|
||
# Test generating with header | ||
# Header contains a time stamp that messes up unit testing. | ||
# Only test length of result. | ||
args = "--no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
self.assertTrue(len(gcode.splitlines()) == 14) | ||
|
||
# Test without header | ||
expected = """(Begin preamble) | ||
G17 G54 G40 G49 G80 G90 | ||
G21 | ||
(Begin operation: testpath) | ||
(Machine units: mm/min) | ||
(Finish operation: testpath) | ||
(Begin postamble) | ||
M05 | ||
G17 G54 G90 G80 G40 | ||
M2 | ||
""" | ||
|
||
self.docobj.Path = Path.Path([]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --no-show-editor" | ||
# args = ("--no-header --no-comments --no-show-editor --precision=2") | ||
gcode = postprocessor.export(postables, "-", args) | ||
self.assertEqual(gcode, expected) | ||
|
||
# test without comments | ||
expected = """G17 G54 G40 G49 G80 G90 | ||
G21 | ||
M05 | ||
G17 G54 G90 G80 G40 | ||
M2 | ||
""" | ||
|
||
args = "--no-header --no-comments --no-show-editor" | ||
# args = ("--no-header --no-comments --no-show-editor --precision=2") | ||
gcode = postprocessor.export(postables, "-", args) | ||
self.assertEqual(gcode, expected) | ||
|
||
def test010(self): | ||
"""Test command Generation. | ||
Test Precision | ||
""" | ||
c = Path.Command("G0 X10 Y20 Z30") | ||
|
||
self.docobj.Path = Path.Path([c]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[5] | ||
expected = "G0 X10.000 Y20.000 Z30.000" | ||
self.assertEqual(result, expected) | ||
|
||
args = "--no-header --precision=2 --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[5] | ||
expected = "G0 X10.00 Y20.00 Z30.00" | ||
self.assertEqual(result, expected) | ||
|
||
def test020(self): | ||
""" | ||
Test Line Numbers | ||
""" | ||
c = Path.Command("G0 X10 Y20 Z30") | ||
|
||
self.docobj.Path = Path.Path([c]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --line-numbers --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[5] | ||
expected = "N150 G0 X10.000 Y20.000 Z30.000" | ||
self.assertEqual(result, expected) | ||
|
||
def test030(self): | ||
""" | ||
Test Pre-amble | ||
""" | ||
|
||
self.docobj.Path = Path.Path([]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --no-comments --preamble='G18 G55' --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[0] | ||
self.assertEqual(result, "G18 G55") | ||
|
||
def test040(self): | ||
""" | ||
Test Post-amble | ||
""" | ||
self.docobj.Path = Path.Path([]) | ||
postables = [self.docobj] | ||
args = "--no-header --no-comments --postamble='G0 Z50\nM2' --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[-2] | ||
self.assertEqual(result, "G0 Z50") | ||
self.assertEqual(gcode.splitlines()[-1], "M2") | ||
|
||
def test050(self): | ||
""" | ||
Test inches | ||
""" | ||
|
||
c = Path.Command("G0 X10 Y20 Z30") | ||
self.docobj.Path = Path.Path([c]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --inches --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
self.assertEqual(gcode.splitlines()[2], "G20") | ||
|
||
result = gcode.splitlines()[5] | ||
expected = "G0 X0.3937 Y0.7874 Z1.1811" | ||
self.assertEqual(result, expected) | ||
|
||
args = "--no-header --inches --precision=2 --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[5] | ||
expected = "G0 X0.39 Y0.79 Z1.18" | ||
self.assertEqual(result, expected) | ||
|
||
def test060(self): | ||
""" | ||
Test test modal | ||
Suppress the command name if the same as previous | ||
""" | ||
c = Path.Command("G0 X10 Y20 Z30") | ||
c1 = Path.Command("G0 X10 Y30 Z30") | ||
|
||
self.docobj.Path = Path.Path([c, c1]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --modal --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[6] | ||
expected = "X10.000 Y30.000 Z30.000" | ||
self.assertEqual(result, expected) | ||
|
||
def test070(self): | ||
""" | ||
Test axis modal | ||
Suppress the axis coordinate if the same as previous | ||
""" | ||
c = Path.Command("G0 X10 Y20 Z30") | ||
c1 = Path.Command("G0 X10 Y30 Z30") | ||
|
||
self.docobj.Path = Path.Path([c, c1]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --axis-modal --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[6] | ||
expected = "G0 Y30.000" | ||
self.assertEqual(result, expected) | ||
|
||
def test080(self): | ||
""" | ||
Test tool change | ||
""" | ||
c = Path.Command("M6 T2") | ||
c2 = Path.Command("M3 S3000") | ||
self.docobj.Path = Path.Path([c, c2]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
self.assertEqual(gcode.splitlines()[6], "M5") | ||
self.assertEqual(gcode.splitlines()[7], "M6 T2") | ||
self.assertEqual(gcode.splitlines()[8], "G43 H2") | ||
self.assertEqual(gcode.splitlines()[9], "M3 S3000") | ||
|
||
# suppress TLO | ||
args = "--no-header --no-tlo --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
self.assertEqual(gcode.splitlines()[8], "M3 S3000") | ||
|
||
def test090(self): | ||
""" | ||
Test comment | ||
""" | ||
|
||
c = Path.Command("(comment)") | ||
|
||
self.docobj.Path = Path.Path([c]) | ||
postables = [self.docobj] | ||
|
||
args = "--no-header --no-show-editor" | ||
gcode = postprocessor.export(postables, "-", args) | ||
result = gcode.splitlines()[5] | ||
expected = "(comment)" | ||
self.assertEqual(result, expected) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint: fix end of line asterisk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 3-4 places where the asterisk is not uniform do you mind fixing these ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, of course I will make the changes. However, when I look at the code in my editor it looks fine. I am assuming I have a tab vs space substitution.
Is see "lint" is the tool you used to find the issues. Would you mind giving me the command line arguments, so I can generate the issues myself?
In my defense, I did search the web for "FreeCAD Pull Request procedure" and came up pretty empty. I did look at the Developers Handbook. I did see the mention of "Black" as a Python formatter ... I am a C++ kinda guy, so it is a new tool to me. Running Visual Studio Code, I see there is an extension for "Black" ... is this what is used? I ask because I know how out of date the wiki can be.
Thank you for your time and patience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raw file: https://raw.githubusercontent.com/FreeCAD/FreeCAD/66f92c3bad29093f27f92bc27a421079563c3c3d/src/Mod/CAM/CAMTests/TestRefactoredMassoG3Post.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok updated 4 files with corrected comment alignment, and check it all back in again.
Did a clean build and re-ran the test framework. Only error from the Framework was for an area I never touched.
FAIL: test01 (CAMTests.TestPathToolController.TestPathToolController.test01)
Verify ToolController template roundtrip.
I am afraid that is an issue for Sliptonic.