Addition of CAM postprocessor for the Masso controller #18845
Conversation
…others want M6 T#. Masso wants T# M6. Added file refactored_masso_g3_post.py (based on refactored_linuxcnc_post.py) and modified UtilsParse.py
…o support fil diffing
for more information, see https://pre-commit.ci
| @@ -22,6 +23,11 @@ | |||
| # * * | |||
| # *************************************************************************** | |||
|
|
|||
| # *************************************************************************** | |||
| # * Note: refactored_masso_g3_Post.py is a modified clone of this file * | |||
There was a problem hiding this comment.
lint: fix end of line asterisk
There was a problem hiding this comment.
There are 3-4 places where the asterisk is not uniform do you mind fixing these ?
There was a problem hiding this comment.
First, of course I will make the changes. However, when I look at the code in my editor it looks fine. I am assuming I have a tab vs space substitution.
Is see "lint" is the tool you used to find the issues. Would you mind giving me the command line arguments, so I can generate the issues myself?
In my defense, I did search the web for "FreeCAD Pull Request procedure" and came up pretty empty. I did look at the Developers Handbook. I did see the mention of "Black" as a Python formatter ... I am a C++ kinda guy, so it is a new tool to me. Running Visual Studio Code, I see there is an extension for "Black" ... is this what is used? I ask because I know how out of date the wiki can be.
Thank you for your time and patience.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok updated 4 files with corrected comment alignment, and check it all back in again.
Did a clean build and re-ran the test framework. Only error from the Framework was for an area I never touched.
FAIL: test01 (CAMTests.TestPathToolController.TestPathToolController.test01)
Verify ToolController template roundtrip.
I am afraid that is an issue for Sliptonic.
|
We usually "squash" multiple commits in a PR down to one commit to make managing the PR easier. I forgot to check for that during my review. |
The Masso G3 want the order of a tool change to be tool number then tool change command. FreeCAD by default wants tool change command then tool number. For example Masso wants "T5 M6" whereas the linuccnc controller is just fine with "M6 T5".
The new addition is called refactored_masso_g3_post.py. It is a copy and modification of the refactored_linuxcnc_post.py. (Both codes have reference to each other in the comments now). The "refactored" line of post processors is the newest approach to post processors and was written by Larry Woestman. Larrry has been consulted throughout this process.
This modification introduces the TOOL_BEFORE_CHANGE configuration option. Setting TOOL_BEFORE_CHANGE to True triggers the command swap. This swap happens in File:UtilsParse.py Routine:parse_a_path lines 729-736. This seemed to be the least intrusive way to swap the command in the current GCode buffer.
A test module called TestRefactoredMassoG3Post.py was added to TestCAMApp.py. Therefor running "freecadcmd -t TestCAMApp >TestCAMApp.txt 2>&1" runs the testing module.
In the output the test is listed under CAMTests.TestRefactoredMassoG3Post.TestRefactoredMassoG3Post. Test 80 is the test to check for tool order. Test 80 is the only test modified from the linuxcnc test routine. All other tests were maintained.
I have actually used the output of this routine on a Masso G3 in my basement.
As this is my first PR with FreeCAD, please pardon any negligence.
Regards and Thank you
Carl