Gadget icons may go missing - how to fix
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 11 2023, 4:37 PM

Description

We are making some changes in the mobile site to make it more consistent with desktop. This change may impact gadgets/user scripts which add icons to the Minerva skin as it will requires changes to addPortletLink support (T344006) that we can't easily provide backwards compatibility support for at this time. The fix is relatively simple. You can patch your gadgets before this change rolls out by following the instructions here

Is my gadget impacted?

If your gadget shows up here (and has not been patched already) it is impacted:
https://global-search.toolforge.org/?q=mw-ui-icon-portletlink-&regex=1&namespaces=2%2C8&title=.*%5C.css

How do I fix it ?

To address this please update any selectors using pseudo ::before to have the minerva-icon-- prefix.
Example here: https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-dark-mode-toggle-pagestyles.css&diff=1169842920&oldid=1160517217

e.g.

.mw-ui-icon-portletlink-pt-darkmode::before

becomes

.mw-ui-icon-portletlink-pt-darkmode::before,
.minerva-icon--pt-darkmode,

Related Objects

Mentioned In: T344006: Minerva Codex migration: Add support for gadget developers with new Codex markup
Mentioned Here: T344006: Minerva Codex migration: Add support for gadget developers with new Codex markup

Event Timeline

Jdlrobson created this task.Aug 11 2023, 4:37 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 11 2023, 4:37 PM

Jdlrobson updated the task description. (Show Details)Aug 11 2023, 4:39 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T344006: Minerva Codex migration: Add support for gadget developers with new Codex markup.Aug 11 2023, 4:41 PM

Hi, for Tech News, do you have any suggested wording? My best guess is something like this. (please confirm for accuracy, or tweak as needed):

A few gadgets/user scripts which add icons to the Minerva skin need to have their CSS updated. There are more details available including a search for all existing instances and how to update them.

Jdlrobson awarded a token.Aug 11 2023, 6:56 PM

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Aug 11 2023, 10:44 PM

R4356th edited subscribers, added: R4356th; removed: Masumrezarock100.Aug 12 2023, 1:08 PM

R4356th added a subscriber: Masumrezarock100.

Frostly moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Aug 13 2023, 7:30 AM

Yahya subscribed.Aug 15 2023, 9:09 AM

Anything left to do here?

Jdlrobson closed this task as Resolved.Nov 10 2023, 12:03 AM

Jdlrobson claimed this task.

Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Nov 20 2023, 12:30 AM