Rename references in tests from app/packs to app/javascript (shakacod…

…e#275)
willemorvets · Apr 4, 2023 · 2841d43 · 2841d43
1 parent 72ed559
commit 2841d43
Show file tree

Hide file tree

Showing 16 changed files with 24 additions and 24 deletions.
diff --git a/docs/troubleshooting.md b/docs/troubleshooting.md
@@ -188,7 +188,7 @@ Thus ProvidePlugin manages build-time dependencies to global symbols whereas the
 
 For instance, with [jQuery](https://jquery.com/):
 ```diff
-// app/packs/entrypoints/application.js
+// app/javascript/entrypoints/application.js
 
 - import jQuery from 'jquery'
 - window.jQuery = jQuery

diff --git a/lib/webpacker/helper.rb b/lib/webpacker/helper.rb
@@ -75,7 +75,7 @@ def favicon_pack_tag(name, **options)
   # Creates script tags that reference the js chunks from entrypoints when using split chunks API,
   # as compiled by webpack per the entries list in package/environments/base.js.
   # By default, this list is auto-generated to match everything in
-  # app/packs/entrypoints/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up.
+  # app/javascript/entrypoints/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up.
   # See: https://webpack.js.org/plugins/split-chunks-plugin/
   #
   # Example:
@@ -133,7 +133,7 @@ def preload_pack_asset(name, **options)
   # Creates link tags that reference the css chunks from entrypoints when using split chunks API,
   # as compiled by webpack per the entries list in package/environments/base.js.
   # By default, this list is auto-generated to match everything in
-  # app/packs/entrypoints/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up.
+  # app/javascript/entrypoints/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up.
   # See: https://webpack.js.org/plugins/split-chunks-plugin/
   #
   # Examples:

diff --git a/package/__tests__/config.js b/package/__tests__/config.js
@@ -40,6 +40,6 @@ describe('Config', () => {
   test('should allow overriding manifestPath', () => {
     process.env.WEBPACKER_CONFIG = 'config/webpacker_manifest_path.yml'
     const config = require('../config')
-    expect(config.manifestPath).toEqual(resolve('app/packs/manifest.json'))
+    expect(config.manifestPath).toEqual(resolve('app/javascript/manifest.json'))
   })
 })
diff --git a/package/environments/__tests__/base.js b/package/environments/__tests__/base.js
@@ -20,7 +20,7 @@ describe('Base config', () => {
   describe('config', () => {
     test('should return entry', () => {
       expect(baseConfig.entry.application).toEqual(
-        resolve('app', 'packs', 'entrypoints', 'application.js')
+        resolve('app', 'javascript', 'entrypoints', 'application.js')
       )
     })
 
@@ -39,8 +39,8 @@ describe('Base config', () => {
       expect(config.nested_entries).toEqual(false)
 
       expect(baseConfig.entry.multi_entry.sort()).toEqual([
-        resolve('app', 'packs', 'entrypoints', 'multi_entry.css'),
-        resolve('app', 'packs', 'entrypoints', 'multi_entry.js')
+        resolve('app', 'javascript', 'entrypoints', 'multi_entry.css'),
+        resolve('app', 'javascript', 'entrypoints', 'multi_entry.js')
       ])
       expect(baseConfig.entry['generated/something']).toEqual(undefined)
     })
@@ -53,14 +53,14 @@ describe('Base config', () => {
       expect(config.nested_entries).toEqual(true)
 
       expect(baseConfig.entry.application).toEqual(
-        resolve('app', 'packs', 'entrypoints', 'application.js')
+        resolve('app', 'javascript', 'entrypoints', 'application.js')
       )
       expect(baseConfig.entry.multi_entry.sort()).toEqual([
-        resolve('app', 'packs', 'entrypoints', 'multi_entry.css'),
-        resolve('app', 'packs', 'entrypoints', 'multi_entry.js')
+        resolve('app', 'javascript', 'entrypoints', 'multi_entry.css'),
+        resolve('app', 'javascript', 'entrypoints', 'multi_entry.js')
       ])
       expect(baseConfig.entry['generated/something']).toEqual(
-        resolve('app', 'packs', 'entrypoints', 'generated', 'something.js')
+        resolve('app', 'javascript', 'entrypoints', 'generated', 'something.js')
       )
     })
 
@@ -91,7 +91,7 @@ describe('Base config', () => {
 
     test('should return default resolve.modules with additions', () => {
       expect(baseConfig.resolve.modules).toEqual([
-        resolve('app', 'packs'),
+        resolve('app', 'javascript'),
         resolve('app/assets'),
         resolve('/etc/yarn'),
         resolve('some.config.js'),

diff --git a/package/rules/__tests__/__utils__/webpack.js b/package/rules/__tests__/__utils__/webpack.js
@@ -16,7 +16,7 @@ const createTrackLoader = () => {
 
 const node_modules = path.resolve("node_modules");
 const node_modules_included = path.resolve("node_modules/included");
-const app_javascript = path.resolve("app/packs");
+const app_javascript = path.resolve("app/javascript");
 
 const createInMemoryFs = () => {
   const fs = new MemoryFS();

diff --git a/spec/configuration_spec.rb b/spec/configuration_spec.rb
@@ -11,12 +11,12 @@
     end
 
     it "#source_path returns correct path" do
-      source_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/packs").to_s
+      source_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/javascript").to_s
       expect(config.source_path.to_s).to eq source_path
     end
 
     it "#source_entry_path returns correct path" do
-      source_entry_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/packs", "entrypoints").to_s
+      source_entry_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/javascript", "entrypoints").to_s
       expect(config.source_entry_path.to_s).to eq source_entry_path
     end
 
@@ -195,7 +195,7 @@
     )
 
     it "#manifest_path returns correct expected value" do
-      expected_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/packs", "manifest.json").to_s
+      expected_manifest_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/app/javascript", "manifest.json").to_s
       expect(config.manifest_path.to_s).to eq expected_manifest_path
     end
   end

diff --git a/spec/mounted_app/test/dummy/config/webpacker.yml b/spec/mounted_app/test/dummy/config/webpacker.yml
@@ -1,7 +1,7 @@
 # Note: You must restart bin/webpacker-dev-server for changes to take effect
 
 default: &default
-  source_path: app/packs
+  source_path: app/javascript
   source_entry_path: entrypoints
   public_output_path: packs
   cache_path: tmp/webpacker

diff --git a/..._app/app/packs/entrypoints/application.js → ...app/javascript/entrypoints/application.js b/..._app/app/packs/entrypoints/application.js → ...app/javascript/entrypoints/application.js
@@ -1,7 +1,7 @@
 /* eslint no-console:0 */
 // This file is automatically compiled by Webpack, along with any other files
 // present in this directory. You're encouraged to place your actual application logic in
-// a relevant structure within app/packs and only use these pack files to reference
+// a relevant structure within app/javascript and only use these pack files to reference
 // that code so it'll be compiled.
 //
 // To reference this file, add <%= javascript_pack_tag 'application' %> to the appropriate

diff --git a/.../packs/entrypoints/generated/something.js → ...script/entrypoints/generated/something.js b/.../packs/entrypoints/generated/something.js → ...script/entrypoints/generated/something.js
diff --git a/...app/app/packs/entrypoints/multi_entry.css → ...pp/javascript/entrypoints/multi_entry.css b/...app/app/packs/entrypoints/multi_entry.css → ...pp/javascript/entrypoints/multi_entry.css
diff --git a/..._app/app/packs/entrypoints/multi_entry.js → ...app/javascript/entrypoints/multi_entry.js b/..._app/app/packs/entrypoints/multi_entry.js → ...app/javascript/entrypoints/multi_entry.js
diff --git a/spec/test_app/config/webpacker.yml b/spec/test_app/config/webpacker.yml
@@ -1,7 +1,7 @@
 # Note: You must restart bin/webpacker-dev-server for changes to take effect
 
 default: &default
-  source_path: app/packs
+  source_path: app/javascript
   source_entry_path: entrypoints
   nested_entries: false
   public_root_path: public

diff --git a/spec/test_app/config/webpacker_css_extract_ignore_order_warnings.yml b/spec/test_app/config/webpacker_css_extract_ignore_order_warnings.yml
@@ -1,7 +1,7 @@
 # Note: You must restart bin/webpacker-dev-server for changes to take effect
 
 default: &default
-  source_path: app/packs
+  source_path: app/javascript
   source_entry_path: entrypoints
   nested_entries: true
   public_root_path: public

diff --git a/spec/test_app/config/webpacker_manifest_path.yml b/spec/test_app/config/webpacker_manifest_path.yml
@@ -1,15 +1,15 @@
 # Note: You must restart bin/webpack-dev-server for changes to take effect
 
 default: &default
-  source_path: app/packs
+  source_path: app/javascript
   source_entry_path: entrypoints
   public_root_path: public
   public_output_path: packs
   cache_path: tmp/webpacker
   webpack_compile_output: false
 
   # Location for manifest.json, defaults to {public_output_path}/manifest.json if unset
-  manifest_path: app/packs/manifest.json
+  manifest_path: app/javascript/manifest.json
 
   # Additional paths webpack should look up modules
   # ['app/assets', 'engine/foo/app/assets']

diff --git a/spec/test_app/config/webpacker_nested_entries.yml b/spec/test_app/config/webpacker_nested_entries.yml
@@ -1,7 +1,7 @@
 # Note: You must restart bin/webpacker-dev-server for changes to take effect
 
 default: &default
-  source_path: app/packs
+  source_path: app/javascript
   source_entry_path: entrypoints
   nested_entries: true
   public_root_path: public

diff --git a/spec/test_app/config/webpacker_other_location.yml b/spec/test_app/config/webpacker_other_location.yml
@@ -1,7 +1,7 @@
 # Note: You must restart bin/webpacker-dev-server for changes to take effect
 
 default: &default
-  source_path: app/packs
+  source_path: app/javascript
   source_entry_path: entrypoints
   public_root_path: public
   public_output_path: packs