Rename references in tests from app/packs to app/javascript #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahangarha FYI - I think you've tried to do something similar in #274 |
Closed
2 tasks
justin808
approved these changes
Apr 4, 2023
| @@ -188,7 +188,7 @@ Thus ProvidePlugin manages build-time dependencies to global symbols whereas the | |||
|
|
|||
| For instance, with [jQuery](https://jquery.com/): | |||
| ```diff | |||
| // app/packs/entrypoints/application.js | |||
| // app/javascript/entrypoints/application.js | |||
There was a problem hiding this comment.
This makes more sense, however, I've tended to keep the older packs rather than entrypoints term. Both work.
| @@ -133,7 +133,7 @@ def preload_pack_asset(name, **options) | |||
| # Creates link tags that reference the css chunks from entrypoints when using split chunks API, | |||
| # as compiled by webpack per the entries list in package/environments/base.js. | |||
| # By default, this list is auto-generated to match everything in | |||
| # app/packs/entrypoints/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up. | |||
| # app/javascript/entrypoints/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up. | |||
There was a problem hiding this comment.
Documentation should suggest the key or keys used from the webpacker.yml file that configure this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our default entry paths is
app/javascriptbut tests are still usingapp/packsin various places. Noticed this causing failures locally when runningyarn testThis should unify the handling throughout.
Pull Request checklist