Skip to content

fix(setData): allow empty objects to be set fix #1704 #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmiller1990 merged 3 commits into from
Oct 7, 2020
Merged

fix(setData): allow empty objects to be set fix #1704 #1705

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cda6e4b
fix(setData): allow empty objects to be set
Haroenv Oct 1, 2020
e304be2
fix formatting
Haroenv Oct 5, 2020
a9a9826
test
Haroenv Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(setData): allow empty objects to be set 
fixes #1704 

This is a tentative fix to show one possible solution, I can clean it up if you think it makes sense
  • Loading branch information
@Haroenv
Haroenv authored Oct 1, 2020
commit cda6e4b42970c6b468b13f5d62de60bf28c5a553
2 changes: 1 addition & 1 deletion packages/test-utils/src/recursively-set-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function recursivelySetData(vm, target, data) {
const val = data[key]
const targetVal = target[key]

if (isPlainObject(val) && isPlainObject(targetVal)) {
if (isPlainObject(val) && isPlainObject(targetVal) && Object.keys(val).length > 0) {
recursivelySetData(vm, targetVal, val)
} else {
vm.$set(target, key, val)
Expand Down