Skip to content

fix(setData): allow empty objects to be set fix #1704 #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmiller1990 merged 3 commits into from
Oct 7, 2020
Merged

fix(setData): allow empty objects to be set fix #1704 #1705

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cda6e4b
fix(setData): allow empty objects to be set
Haroenv Oct 1, 2020
e304be2
fix formatting
Haroenv Oct 5, 2020
a9a9826
test
Haroenv Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test
  • Loading branch information
@Haroenv
Haroenv committed Oct 7, 2020
commit a9a98264fffe6dfc6992245802042cb98e4223b4
25 changes: 25 additions & 0 deletions test/specs/wrapper/setData.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,4 +320,29 @@ describeWithShallowAndMount('setData', mountingMethod => {
await wrapper.setData({ selectedDate: testDate })
expect(wrapper.vm.selectedDate).toEqual(testDate)
})

it('allows empty objects to be set', () => {
const TestComponent = {
data() {
return {
someKey: { someValue: true }
}
},
render(h) {
return h('span')
}
}

const wrapper = mountingMethod(TestComponent)

expect(wrapper.vm.$data).toEqual({ someKey: { someValue: true } })

wrapper.setData({ someKey: {} })

expect(wrapper.vm.$data).toEqual({ someKey: {} })

wrapper.setData({ someKey: { someValue: false } })

expect(wrapper.vm.$data).toEqual({ someKey: { someValue: false } })
})
})