Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unsupported DDL parsing; squash revealed bugs #329

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Improve unsupported DDL parsing; squash revealed bugs #329

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6af6de9
fix #326: do not match unsupported ddl followed by open parens
tconbeer Nov 28, 2022
a32e211
refactor: parse unsupported DDL more granularly instead of with one b…
tconbeer Nov 28, 2022
58470b3
chore: update changelog
tconbeer Nov 28, 2022
de3f877
fix: catch SqlfmtSegmentError and handle appropriately, do not use fi…
tconbeer Nov 29, 2022
a7ed980
fix: stop using tail recursion for create_segments_from_lines
tconbeer Nov 30, 2022
adc0da4
chore: update primer refs
tconbeer Nov 30, 2022
20b035c
refactor: simplify create_segments, add tests
tconbeer Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update primer refs
  • Loading branch information
@tconbeer
tconbeer committed Nov 30, 2022
commit adc0da4a6dbb7d5bd746b799504ed3613e16947d
14 changes: 7 additions & 7 deletions src/sqlfmt_primer/primer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ def get_projects() -> List[SQLProject]:
SQLProject(
name="gitlab",
git_url="https://github.com/tconbeer/gitlab-analytics-sqlfmt.git",
git_ref="52dc37d", # sqlfmt a0e5254
expected_changed=4,
expected_unchanged=2413,
git_ref="90ffb23", # sqlfmt a7ed980
expected_changed=3,
expected_unchanged=2414,
expected_errored=0,
sub_directory=Path("transform/snowflake-dbt/"),
),
SQLProject(
name="rittman",
git_url="https://github.com/tconbeer/rittman_ra_data_warehouse.git",
git_ref="dd47b23", # sqlfmt a0e5254
git_ref="472d35a", # sqlfmt a7ed980
expected_changed=0,
expected_unchanged=307,
expected_errored=4, # true mismatching brackets
Expand All @@ -48,7 +48,7 @@ def get_projects() -> List[SQLProject]:
SQLProject(
name="http_archive",
git_url="https://github.com/tconbeer/http_archive_almanac.git",
git_ref="ec18b52", # sqlfmt 6aa20a1
git_ref="73e483c", # sqlfmt a7ed980
expected_changed=0,
expected_unchanged=1702,
expected_errored=0,
Expand All @@ -57,7 +57,7 @@ def get_projects() -> List[SQLProject]:
SQLProject(
name="aqi",
git_url="https://github.com/tconbeer/aqi_livibility_analysis.git",
git_ref="cab1292", # sqlfmt 6d33371
git_ref="b088ed1", # sqlfmt a7ed980
expected_changed=0,
expected_unchanged=7,
expected_errored=0,
Expand All @@ -75,7 +75,7 @@ def get_projects() -> List[SQLProject]:
SQLProject(
name="dbt_utils",
git_url="https://github.com/tconbeer/dbt-utils.git",
git_ref="a70e75d", # sqlfmt b792a79
git_ref="749446c", # sqlfmt a7ed980
expected_changed=2,
expected_unchanged=129,
expected_errored=0,
Expand Down