Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unsupported DDL parsing; squash revealed bugs #329

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Improve unsupported DDL parsing; squash revealed bugs #329

merged 7 commits into from
Nov 30, 2022

Conversation

tconbeer
Copy link
Owner

  • fix Unterminated Jinja block...Expected end tag: ({% endfor %}) #326: do not match unsupported ddl followed by open parens
  • refactor: parse unsupported DDL more granularly instead of with one big DATA token
  • chore: update changelog
  • fix: catch SqlfmtSegmentError and handle appropriately, do not use finally; fixes issue where we could drop lines entirely
  • fix: stop using tail recursion for create_segments_from_lines
  • chore: update primer refs

@tconbeer tconbeer merged commit 768f949 into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unterminated Jinja block...Expected end tag: ({% endfor %})
1 participant
@tconbeer