Allow for lazy context in machine.withConfig
#2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farskid
force-pushed
the
farskid/fix-withconfig-lazy-context-bug
branch
from
2f4c41f to
5a9500d
Compare
|
The tests are failing due to typing errors but the frustrating part is that the project isn't building locally for me (build command quits after 0.3s) and all tests pass 🤷♂️ |
Andarist
reviewed
Aug 19, 2021
Comment on lines
+213
to
+216
| const a = interpret(copiedMachine).start(); | ||
| const b = interpret(copiedMachine).start(); | ||
|
|
||
| expect(a.state.context.foo).not.toBe(b.state.context.foo); |
There was a problem hiding this comment.
this part could be moved to a separate test - that way we would have the tested requirement listed in the test summary etc
🦋 Changeset detectedLatest commit: 0f32769 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ne`/`useInterpret` when declared in the lazy context
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.