BREAKING: Use eslint for pattern ignoring; remove deglob #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore patterns should follow the .gitignore format rather than the `glob` pattern. So, you can use dir/ instead of dir/** now. There may be subtle differences in behavior. Fixes: #226
feross
changed the title
feross
changed the title
Flet
approved these changes
Oct 29, 2020
This was referenced Oct 31, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
BREAKING: Use eslint for file ignoring; remove deblog
Ignore patterns should follow the .gitignore format rather than the
globpattern. So, you can use dir/ instead of dir/** now. There may be subtle differences in behavior.Which issue (if any) does this pull request address?
Fixes: #226
Fixes: standard/standard#1333
Fixes: standard/standard#1117
Fixes: standard/standard#1023
Fixes: standard/standard#1384
Fixes: standard/standard#1182
Fixes: standard/standardx#36
Is there anything you'd like reviewers to focus on?